Looks Good.
Also as a heads up - I sent an email with an attachment --- looks like there is a side consequence to having Userid be part of the table type and not separate --- that side consequence occurs if…
won't this wipe out all thier pre-existing data every time PROMSFixes is run?
only need to delete the ones not already in the table. If we delete and re-add then will lose history of when truely added --- see comment below (around line 24278) for more complete,
Shouldn't need NameStr or RowID unless I am missing something as these are not columns in AnnotationSelections
Would suggest not having columns named both UserID and UserID in the same table as it is confusing which is the function of each,
I thought Name was being removed from AnntationsSelections and just going to be pulled from AnnotationsType?
I closed this previous comment since it moved down and reposted here - "Shouldn't need this as foreach loop below should loop 0 times if no rows."
still appears to be:
//dt.Rows.Add(DataPortal.Fetch()); //DataPortal.Fetch();
would think would want to do something like:
--this would delete only the ones for this User that are not in the uploaded table DELETE FROM AnnotationTypeSelections where UsrID in (Select…