Matthew Schill mschill
  • Joined on 2024-09-05
mschill pushed to DEV_Proj_File_Dependency_Update at Volian/SourceCode 2025-07-29 09:20:59 -04:00
d701935ddf DEV_Proj_File_Dependency_Update
mschill created branch DEV_Proj_File_Dependency_Update in Volian/SourceCode 2025-07-29 09:20:59 -04:00
mschill pushed to Development at Volian/SourceCode 2025-07-28 16:14:31 -04:00
94f0795247 Merge pull request 'B2025-039 Needed to include the Blue color to the RTF color table for formats that use a proportional font.' (#577) from B2025-039_PropFontColorRplWrds into Development
4def73d738 B2025-039 Needed to include the Blue color to the RTF color table for formats that use a proportional font.
Compare 2 commits »
mschill merged pull request Volian/SourceCode#577 2025-07-28 16:14:30 -04:00
B2025-039 Needed to include the Blue color to the RTF color table for formats that use a proportional font.
mschill commented on pull request Volian/SourceCode#574 2025-07-28 15:14:37 -04:00
C2025-027-AnnotationsTypeSelect

Also as a heads up - I sent an email with an attachment --- looks like there is a side consequence to having Userid be part of the table type and not separate --- that side consequence occurs if…

mschill commented on pull request Volian/SourceCode#574 2025-07-28 13:18:38 -04:00
C2025-027-AnnotationsTypeSelect

won't this wipe out all thier pre-existing data every time PROMSFixes is run?

mschill commented on pull request Volian/SourceCode#574 2025-07-28 09:25:10 -04:00
C2025-027-AnnotationsTypeSelect

if commented out, should this be removed?

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:19:21 -04:00
C2025-027-AnnotationsTypeSelect

see comments in SQL --- shouldn't need RowID

mschill suggested changes for Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

See Comments.

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

only need to delete the ones not already in the table. If we delete and re-add then will lose history of when truely added --- see comment below (around line 24278) for more complete,

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

shouldn't need a primary key on a type?

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

Shouldn't need NameStr or RowID unless I am missing something as these are not columns in AnnotationSelections

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

Would suggest not having columns named both UserID and UserID in the same table as it is confusing which is the function of each,

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

I thought Name was being removed from AnntationsSelections and just going to be pulled from AnnotationsType?

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

I closed this previous comment since it moved down and reposted here - "Shouldn't need this as foreach loop below should loop 0 times if no rows."

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

if have a try catch, should there be something in the catch?

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:17:55 -04:00
C2025-027-AnnotationsTypeSelect

if have a try catch, should there be something in the catch?

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:16:28 -04:00
C2025-027-AnnotationsTypeSelect

still appears to be:

//dt.Rows.Add(DataPortal.Fetch()); //DataPortal.Fetch();

mschill commented on pull request Volian/SourceCode#574 2025-07-28 08:13:51 -04:00
C2025-027-AnnotationsTypeSelect

would think would want to do something like:

--this would delete only the ones for this User that are not in the uploaded table DELETE FROM AnnotationTypeSelections where UsrID in (Select…