Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

It looks like this function is never called?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

see notes below. It looks like these sreg variables are never used.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Maybe I am missing something but I am not seeing this function being called anywhere?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not sure this comment is correct.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Maybe I am missing something, but it looks like the only place this is called from is StaticStripRtfCommands - which is never called --- so this code will never be called / executed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

A new class like this or extending an existing class should be in it's own cs file so it can be found easily. --- also, otherwise it may be difficult to tell when it will work or not.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Can simplify this to have less executions / possibly use LINQ. See recommendations that SonrLint Visual Studio Ext will give.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

What project is this that is being added to this solution?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

What is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not critical -- but just a side suggestion to make things easier for future possible changes ---- I would suggest reviewing this file and try to fix some of the spacing issues --- there are a lot of items showing as changes that are not actual changes (i.e. removed blank lines or added / removed spaces) -- this makes it difficult to tell what was / wasn't changed and more likely to miss something / make a mistake. It also means that all these items will show up in history as being changed by this project. This could make diagnosing future issues more difficult (i.e. something that may have always been a certain way may appear it was changed with this project.)

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

There are all these: galleryContainerSymbolsCM, CM3, galleryContainerSymbolsGrid, etc...