Matthew Schill mschill
  • Joined on 2024-09-05
mschill approved Volian/SourceCode#729 2026-03-10 13:04:18 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Looks good. Ready for QA.

mschill created pull request Volian/SourceCode#731 2026-03-10 07:01:48 -04:00
B2026-029 Update the Clipboard Copying in PROMS StepTabRibbon to retry
mschill pushed to B2026-029 at Volian/SourceCode 2026-03-10 07:00:35 -04:00
9ccdaef354 B2026-029 Update the Clipboard Copying in PROMS StepTabRibbon to retry
mschill created branch B2026-029 in Volian/SourceCode 2026-03-10 07:00:35 -04:00
mschill approved Volian/SourceCode#730 2026-03-09 14:32:15 -04:00
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

Looks good. Ready for QA.

mschill suggested changes for Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

see notes - let me know if you have any questions.

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill suggested changes for Volian/SourceCode#730 2026-03-09 07:17:43 -04:00
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

see note ---- could parsing the character as an int cause an exception if it can't be parsed or is null?

mschill commented on pull request Volian/SourceCode#730 2026-03-09 07:17:43 -04:00
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

Could there be an exception here with the int.Parse?

mschill suggested changes for Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

See notes.

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Ideally, these inserts would be done a different way as concatenating SQL together like this could risk sql injection --- that being said - I believe that would be beyond the scope of this project / CSM item.

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Does there need to be a null check / try parse here?