Matthew Schill mschill
  • Joined on 2024-09-05
mschill approved Volian/SourceCode#730 2026-03-09 14:32:15 -04:00
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

Looks good. Ready for QA.

mschill suggested changes for Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

see notes - let me know if you have any questions.

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 12:41:13 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill suggested changes for Volian/SourceCode#730 2026-03-09 07:17:43 -04:00
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

see note ---- could parsing the character as an int cause an exception if it can't be parsed or is null?

mschill commented on pull request Volian/SourceCode#730 2026-03-09 07:17:43 -04:00
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

Could there be an exception here with the int.Parse?

mschill suggested changes for Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

See notes.

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Ideally, these inserts would be done a different way as concatenating SQL together like this could risk sql injection --- that being said - I believe that would be beyond the scope of this project / CSM item.

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Does there need to be a null check / try parse here?

mschill commented on pull request Volian/SourceCode#729 2026-03-09 07:09:20 -04:00
B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Should commented out code be removed?

mschill pushed to B2026-019 at Volian/SourceCode 2026-03-02 14:12:16 -05:00
f66c6a93c5 Merge branch 'Development' into B2026-019
fe90af5aa4 Merge pull request 'B2026-021-some-symbols-not-being-displayed-correctly' (#726) from B2026-021-some-symbols-not-being-displayed-correctly into Development
7e672d91e9 Merge branch 'Development' of https://git.volian.com/Volian/SourceCode into Development
09f472bee2 Merge pull request 'F2026-011 Vogtle Units 3&4 Backgrounds. Adjusted the section title text for the section 5.0 continue message so that it aligns with the background text on the page' (#725) from F2026-011_VogtleBackgrounds_sect_title_adj into Development
30da0c5105 F2026-011 Vogtle Units 3&4 Backgrounds. Adjusted the section title text for the section 5.0 continue message so that it aligns with the background text on the page
Compare 10 commits »
mschill created pull request Volian/SourceCode#727 2026-03-02 14:12:07 -05:00
B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open