would not loop through this is will perform poorly and should not be necessary. It looks like my previous comment got removed with this change as it is now past the end of this file, so I will…
There is another comment around line 24235that is related to this. It just moved since there have been changes since that comment was made. That one should have likely the exact index needed.
still valid - this refers to the query in getAnnotationSelectListTypes around line: 24148
Comment still valid:
index should be UNIQUE by UsrID, TypeID and INCLUDE other columns pulled back like: ASTypeID
This is still valid.
I thought Name was being removed from AnntationsSelections and just going to be pulled from AnnotationsType?
Also, not sure what Config is for here?
So, shouldn't NameStr not be part of the AnnotationTypeSelections and instead pull from AnnotationTypes?
if commented out, should be removed or reason given why commented out?
I could be wrong but I thought some of these were being removed and joins done to the AnnotationType table to get things like Name, IsEpAnnotationType, etc...?