C024-039_Button_on_Applicability_Tab_to_change_all_at_same_level_for_setting_the_item_mode-2 #714
Reference in New Issue
Block a user
Delete Branch "C024-039_Button_on_Applicability_Tab_to_change_all_at_same_level_for_setting_the_item_mode-2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
C024-039 Add button on Applicability Tab to change all at same level for setting the item mode
please remove the commented out code.
Other than that, changes look good
@@ -273,0 +314,4 @@//StepTabRibbon.RefreshProcedureApp(MyEditItem);}//public void RefreshProcedure()please remove this commented out code
Agreed
@@ -354,0 +441,4 @@set{_MyEditItem = value;//if (DesignMode) return; // B2019-043 need to check if we are just saving changes to the user interfacePlease remove the commented out code
Agreed
Found some commented out code that should be removed.
@@ -44,6 +46,7 @@ namespace Volian.Controls.Libraryint apple = -1;if(_MyDisplayTabItem.MyStepTabPanel != null)apple = _MyDisplayTabItem.MyStepTabPanel.MyStepPanel.ApplDisplayMode;//_MyDisplayTabItem.MyStepTabPanel.MyStepTabRibbon.RefreshProcedureRemove commented out code
@@ -272,1 +284,4 @@}private void BtnApplicabilitychg_Click(object sender, System.EventArgs e){//ItemInfoRemove commented out code
@@ -273,0 +288,4 @@EditItem topEditItem = MyEditItem;Volian.Base.Library.BigNum MasterSlave_ApplicabilityTmp;StepConfig sc = MyItemInfo.MyConfig as StepConfig;//sc.MasterSlave_Applicability = Volian.Base.Library.BigNum.MakeBigNum(MyApplicability);Remove commented out code
@@ -273,0 +302,4 @@using (Content cnt = Content.Get(startitm.MyContent.ContentID)){sc2.MasterSlave_Applicability = (MasterSlave_ApplicabilityTmp);//sc.MasterSlave_Applicability = Volian.Base.Library.BigNum.MakeBigNum(MyApplicability);Remove commented out code
@@ -273,0 +309,4 @@startitm = startitm.GetNext();}//RefreshProcedure();Remove commented out code
@@ -273,0 +311,4 @@//RefreshProcedure();_MyDisplayTabItem.MyStepTabPanel.MyStepTabRibbon.RefreshProcedure();//StepTabRibbon.RefreshProcedureApp(MyEditItem);Remove commented out code
Not sure if I am missing something, but I am not seeing where topEditItem & MyEditItem are used --- looks like they are added and set but not used ---- are they needed or can all references to them be removed?
If I am missing where these are used, please let me know.
@@ -59,2 +64,4 @@if (_MyDisplayTabItem.MyStepTabPanel != null){MyItemInfo = _MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedItemInfo;MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;Not sure if I am missing something, but I am not seeing where this is used? -- is MyEditItem needed?
Looking over this, it looks like it is not need here. I will remove it.
@@ -273,0 +291,4 @@MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;ItemInfo startitm = MyItemInfo.FirstSibling;topEditItem = MyEditItem.MyStepPanel._LookupEditItems[startitm.ItemID];Not sure if I am missing something, but I am not seeing where this is used? -- is topEditItem needed?
Looking over this, it looks like it is not need here. I will remove it.
Just a couple instances of "MyEditItem" that I wanted to check on - as it looks like these are new and being set but not used?
@@ -273,0 +286,4 @@StepConfig sc = MyItemInfo.MyConfig as StepConfig;MasterSlave_ApplicabilityTmp = sc.MasterSlave_Applicability;MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;Is this still needed?
It was needed in one solution, but no longer needed.
@@ -351,6 +386,15 @@ namespace Volian.Controls.Library}}}private EditItem _MyEditItem;Is this still needed?
It was needed in one solution, but no longer needed.
@@ -352,2 +387,4 @@}}private EditItem _MyEditItem;public EditItem MyEditItemIs this still needed?
It was needed in one solution, but no longer needed.
Looks Good. Ready for QA.
@@ -4,2 +6,3 @@using System.Drawing;using System.Data;using System.Drawing;using System.Security.Cryptography;is System.Security.Cryptography needed? if so, why? If not, please remove.
Reference has been removed.
see comment.
I don't see why we need cyrptography.
changes look good
Looks Good. Ready for QA.