C024-039_Button_on_Applicability_Tab_to_change_all_at_same_level_for_setting_the_item_mode-2 #714

Merged
jjenko merged 5 commits from C024-039_Button_on_Applicability_Tab_to_change_all_at_same_level_for_setting_the_item_mode-2 into Development 2026-02-20 09:06:02 -05:00
Member

C024-039 Add button on Applicability Tab to change all at same level for setting the item mode

C024-039 Add button on Applicability Tab to change all at same level for setting the item mode
plarsen added 1 commit 2026-02-19 10:02:50 -05:00
plarsen requested review from jjenko 2026-02-19 10:03:04 -05:00
plarsen self-assigned this 2026-02-19 10:03:15 -05:00
djankowski was assigned by plarsen 2026-02-19 10:03:16 -05:00
jjenko was assigned by plarsen 2026-02-19 10:03:16 -05:00
mschill was assigned by plarsen 2026-02-19 10:03:16 -05:00
mvickers was assigned by plarsen 2026-02-19 10:03:16 -05:00
jjenko requested changes 2026-02-19 10:08:51 -05:00
Dismissed
jjenko left a comment
Owner

please remove the commented out code.
Other than that, changes look good

please remove the commented out code. Other than that, changes look good
@@ -273,0 +314,4 @@
//StepTabRibbon.RefreshProcedureApp(MyEditItem);
}
//public void RefreshProcedure()
Owner

please remove this commented out code

please remove this commented out code
Member

Agreed

Agreed
mschill marked this conversation as resolved
@@ -354,0 +441,4 @@
set
{
_MyEditItem = value;
//if (DesignMode) return; // B2019-043 need to check if we are just saving changes to the user interface
Owner

Please remove the commented out code

Please remove the commented out code
Member

Agreed

Agreed
mschill marked this conversation as resolved
mschill requested changes 2026-02-19 11:19:03 -05:00
Dismissed
mschill left a comment
Member

Found some commented out code that should be removed.

Found some commented out code that should be removed.
@@ -44,6 +46,7 @@ namespace Volian.Controls.Library
int apple = -1;
if(_MyDisplayTabItem.MyStepTabPanel != null)
apple = _MyDisplayTabItem.MyStepTabPanel.MyStepPanel.ApplDisplayMode;
//_MyDisplayTabItem.MyStepTabPanel.MyStepTabRibbon.RefreshProcedure
Member

Remove commented out code

Remove commented out code
mschill marked this conversation as resolved
@@ -272,1 +284,4 @@
}
private void BtnApplicabilitychg_Click(object sender, System.EventArgs e)
{
//ItemInfo
Member

Remove commented out code

Remove commented out code
mschill marked this conversation as resolved
@@ -273,0 +288,4 @@
EditItem topEditItem = MyEditItem;
Volian.Base.Library.BigNum MasterSlave_ApplicabilityTmp;
StepConfig sc = MyItemInfo.MyConfig as StepConfig;
//sc.MasterSlave_Applicability = Volian.Base.Library.BigNum.MakeBigNum(MyApplicability);
Member

Remove commented out code

Remove commented out code
mschill marked this conversation as resolved
@@ -273,0 +302,4 @@
using (Content cnt = Content.Get(startitm.MyContent.ContentID))
{
sc2.MasterSlave_Applicability = (MasterSlave_ApplicabilityTmp);
//sc.MasterSlave_Applicability = Volian.Base.Library.BigNum.MakeBigNum(MyApplicability);
Member

Remove commented out code

Remove commented out code
mschill marked this conversation as resolved
@@ -273,0 +309,4 @@
startitm = startitm.GetNext();
}
//RefreshProcedure();
Member

Remove commented out code

Remove commented out code
mschill marked this conversation as resolved
@@ -273,0 +311,4 @@
//RefreshProcedure();
_MyDisplayTabItem.MyStepTabPanel.MyStepTabRibbon.RefreshProcedure();
//StepTabRibbon.RefreshProcedureApp(MyEditItem);
Member

Remove commented out code

Remove commented out code
mschill marked this conversation as resolved
plarsen added 1 commit 2026-02-19 13:42:00 -05:00
mschill requested changes 2026-02-19 14:01:19 -05:00
Dismissed
mschill left a comment
Member

Not sure if I am missing something, but I am not seeing where topEditItem & MyEditItem are used --- looks like they are added and set but not used ---- are they needed or can all references to them be removed?

If I am missing where these are used, please let me know.

Not sure if I am missing something, but I am not seeing where topEditItem & MyEditItem are used --- looks like they are added and set but not used ---- are they needed or can all references to them be removed? If I am missing where these are used, please let me know.
@@ -59,2 +64,4 @@
if (_MyDisplayTabItem.MyStepTabPanel != null)
{
MyItemInfo = _MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedItemInfo;
MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;
Member

Not sure if I am missing something, but I am not seeing where this is used? -- is MyEditItem needed?

Not sure if I am missing something, but I am not seeing where this is used? -- is MyEditItem needed?
Author
Member

Looking over this, it looks like it is not need here. I will remove it.

Looking over this, it looks like it is not need here. I will remove it.
mschill marked this conversation as resolved
@@ -273,0 +291,4 @@
MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;
ItemInfo startitm = MyItemInfo.FirstSibling;
topEditItem = MyEditItem.MyStepPanel._LookupEditItems[startitm.ItemID];
Member

Not sure if I am missing something, but I am not seeing where this is used? -- is topEditItem needed?

Not sure if I am missing something, but I am not seeing where this is used? -- is topEditItem needed?
Author
Member

Looking over this, it looks like it is not need here. I will remove it.

Looking over this, it looks like it is not need here. I will remove it.
mschill marked this conversation as resolved
plarsen added 1 commit 2026-02-19 15:37:58 -05:00
mschill requested changes 2026-02-19 15:43:43 -05:00
Dismissed
mschill left a comment
Member

Just a couple instances of "MyEditItem" that I wanted to check on - as it looks like these are new and being set but not used?

Just a couple instances of "MyEditItem" that I wanted to check on - as it looks like these are new and being set but not used?
@@ -273,0 +286,4 @@
StepConfig sc = MyItemInfo.MyConfig as StepConfig;
MasterSlave_ApplicabilityTmp = sc.MasterSlave_Applicability;
MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;
Member

Is this still needed?

Is this still needed?
Author
Member

It was needed in one solution, but no longer needed.

It was needed in one solution, but no longer needed.
mschill marked this conversation as resolved
@@ -351,6 +386,15 @@ namespace Volian.Controls.Library
}
}
}
private EditItem _MyEditItem;
Member

Is this still needed?

Is this still needed?
Author
Member

It was needed in one solution, but no longer needed.

It was needed in one solution, but no longer needed.
mschill marked this conversation as resolved
@@ -352,2 +387,4 @@
}
}
private EditItem _MyEditItem;
public EditItem MyEditItem
Member

Is this still needed?

Is this still needed?
Author
Member

It was needed in one solution, but no longer needed.

It was needed in one solution, but no longer needed.
mschill marked this conversation as resolved
plarsen added 1 commit 2026-02-19 16:15:56 -05:00
mschill approved these changes 2026-02-20 06:28:23 -05:00
mschill left a comment
Member

Looks Good. Ready for QA.

Looks Good. Ready for QA.
@@ -4,2 +6,3 @@
using System.Drawing;
using System.Data;
using System.Drawing;
using System.Security.Cryptography;
Owner

is System.Security.Cryptography needed? if so, why? If not, please remove.

is System.Security.Cryptography needed? if so, why? If not, please remove.
Author
Member

Reference has been removed.

Reference has been removed.
jjenko marked this conversation as resolved
jjenko requested changes 2026-02-20 08:30:48 -05:00
Dismissed
jjenko left a comment
Owner

see comment.
I don't see why we need cyrptography.

see comment. I don't see why we need cyrptography.
plarsen added 1 commit 2026-02-20 09:01:28 -05:00
jjenko approved these changes 2026-02-20 09:05:46 -05:00
jjenko left a comment
Owner

changes look good

changes look good
jjenko merged commit fd50993fb9 into Development 2026-02-20 09:06:02 -05:00
mschill left a comment
Member

Looks Good. Ready for QA.

Looks Good. Ready for QA.
Member

Initially tested with PROMS version 2.3.2602.2009, retested with 2.3.2603.310. CSM items C2026-027 and C2026-028 were added, U2026-011 was added for the user manual updates.

Initially tested with PROMS version 2.3.2602.2009, retested with 2.3.2603.310. CSM items C2026-027 and C2026-028 were added, U2026-011 was added for the user manual updates.
Sign in to join this conversation.
No Reviewers
No labels
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#714