Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - this line is here twice - duplicate code - see lines 2877 & 2884

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor ---- in the future, would recommend

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - Performance String Concatenation

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - It looks like this is already being done in displayRO?

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

looks like there are other changes also?

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Are we removing functionality? ----- noticed we removed the this.txtFilter.TextBox.KeyPress?

mschill commented on pull request Volian/SourceCode#701 2026-02-04 06:38:56 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Agreed - this appears to be intendedly that some code was removed.

mschill commented on pull request Volian/SourceCode#701 2026-02-04 06:38:33 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Agreed - this appears to be intendedly that some code was removed.

mschill commented on pull request Volian/SourceCode#701 2026-02-03 13:53:04 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Should this be removed? --- Would check if tooltip for this button still shows appropriately - if so, then this is fine --- if not then this probably shouldn't be removed.

mschill approved Volian/SourceCode#701 2026-02-03 13:50:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

As a FYI - I am still seeing changes to StepTabRibbon.designer.cs & StepTabRibbon.resx --- I believe these were to be restored to match dev / i.e. they should not be any changes to these 2 files as part of this project.

mschill created pull request Volian/SourceCode#700 2026-02-03 13:30:42 -05:00
B2026-011 Improve the resolution of unit numbers in multi-unit background documents when printing.
mschill pushed to B2026-011 at Volian/SourceCode 2026-02-03 13:28:50 -05:00
1c56aa2eb1 B2026-011 Improve the resolution of unit numbers in multi-unit background documents when printing.
mschill created branch B2026-011 in Volian/SourceCode 2026-02-03 13:28:49 -05:00
mschill created pull request Volian/SourceCode#699 2026-02-02 15:27:53 -05:00
C2026-062 When Search clicked - Load the Incoming transitions for the Active Procedure
mschill pushed to C2026-062 at Volian/SourceCode 2026-02-02 15:25:36 -05:00
aa0b906a9f C2026-062 When Search clicked - Load the Incoming transitions for the Active Procedure
mschill created branch C2026-062 in Volian/SourceCode 2026-02-02 15:25:36 -05:00
mschill pushed to C2022-003-Change-Textboxes-to-RTF-3 at Volian/SourceCode 2026-01-30 14:39:29 -05:00
9e64e5a60e Merge branch 'Development' into C2022-003-Change-Textboxes-to-RTF-3
f43d1e5f47 Merge pull request 'B2026-009 For Vogtle Units 3&4, fixed bug where a double asterisk was place next to a continuous action RNO on the edit screen and printed with the CAS box shifted to the left.' (#697) from B2026-009_VogtleCAS into Development
63a74e1aef B2026-009 For Vogtle Units 3&4, fixed bug where a double asterisk was place next to a continuous action RNO on the edit screen and printed with the CAS box shifted to the left.
69e45e9ae8 Merge pull request 'F2026-003 Adjustments to the Vogtle Units 3&4 background step format that were needed for Jeff’s procedure importer tool' (#696) from F2026-003_VogtleBckGndChanges into Development
53cf35014c F2026-003 Adjustments to the Vogtle Units 3&4 background step format that were needed for Jeff’s procedure importer tool
Compare 52 commits »
mschill suggested changes for Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Branch needs updated as it is out of date with the development branch.

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor thing but concatenating together string like this takes memory - would recommend using

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor thing but concatenating together string like this takes memory - would recommend using