Matthew Schill mschill
  • Joined on 2024-09-05
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-16 14:22:44 -04:00
2784b57a05 C2025-023 - Electronic Procedures - Modifications to PROMS
mschill suggested changes for Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

I re-reviewed this morning.

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

Should this be named something other than buttonX1?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

Now, this is a method with everything inside commented out --- if no code is to execute, should the method be removed?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

commented out code should be removed or reason given for why it is commented out / should be in the code long term.

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

commented out code should be removed or reason given for why it is commented out / should be in the code long term.

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

just to check - is there a reason these 2 items (the id and NameStr) are global variables / should stay in memory while the form is open?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

just to double check --- Is there a reason we are updating the DisplayMember / ValueMember every time we go through the loop?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

I am not sure what this flag is?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

commented out code should be removed or reason given for why it is commented out / should be in the code long term.

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

Naming/casing should be consistent:

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

this should be removed if data set is set to something else (see 2 lines after this)

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:43 -04:00
C2025-027-AnnotationsTypeSelect

just to double check - was this intended to be commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:43 -04:00
C2025-027-AnnotationsTypeSelect

commented out code should be removed or reason given for why it is commented out / should be in the code long term. (lines 122-127)

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:43 -04:00
C2025-027-AnnotationsTypeSelect

So .... unless I have this backwards:

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:43 -04:00
C2025-027-AnnotationsTypeSelect

Should this table have any other indexes?

mschill pushed to C2025-024 at Volian/SourceCode 2025-07-16 10:07:52 -04:00
b9fc9748c7 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill commented on pull request Volian/SourceCode#574 2025-07-16 07:44:43 -04:00
C2025-027-AnnotationsTypeSelect

Now, this is a method with everything inside commented out --- if no code is to execute, should the method be removed?