mschill commented on pull request Volian/SourceCode#807 2026-09-02 15:05:58 -04:00
C2026-041-invisible-position-changes-as-differences

This seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.

mschill suggested changes for Volian/SourceCode#807 2026-09-02 15:02:29 -04:00
C2026-041-invisible-position-changes-as-differences

Sorry noticed one additional thing --- TruncatedDataFg was added as a global variable and set but is never used as this is passed to functions and used locally --- as such, shouldn't also be a global variable / be in memory and not used.

mschill commented on pull request Volian/SourceCode#807 2026-09-02 15:02:29 -04:00
C2026-041-invisible-position-changes-as-differences

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?

mschill suggested changes for Volian/SourceCode#807 2026-09-02 14:54:36 -04:00
C2026-041-invisible-position-changes-as-differences

Looks like only remaining needed changes are in frmBaseline.cs and are all related to added unused code and commented out unused code that needs cleaned up.

mschill commented on pull request Volian/SourceCode#807 2026-09-02 14:54:36 -04:00
C2026-041-invisible-position-changes-as-differences

not sure why this commented line was added - commented out code should be removed.

mschill commented on pull request Volian/SourceCode#807 2026-09-02 14:54:36 -04:00
C2026-041-invisible-position-changes-as-differences

Commented out code should be removed

mschill commented on pull request Volian/SourceCode#807 2026-09-02 14:54:36 -04:00
C2026-041-invisible-position-changes-as-differences

Commented out code should be removed

mschill commented on pull request Volian/SourceCode#807 2026-09-02 14:54:36 -04:00
C2026-041-invisible-position-changes-as-differences

This function is not called so should be removed.

mschill suggested changes for Volian/SourceCode#807 2026-09-02 09:21:10 -04:00
C2026-041-invisible-position-changes-as-differences

It looks like this still assumes that either both files are truncated or neither is.

mschill commented on pull request Volian/SourceCode#807 2026-09-02 09:21:10 -04:00
C2026-041-invisible-position-changes-as-differences

It looks like this still assumes that either both files are truncated or neither is.

mschill suggested changes for Volian/SourceCode#807 2026-09-02 08:56:50 -04:00
C2026-041-invisible-position-changes-as-differences
mschill commented on pull request Volian/SourceCode#807 2026-09-02 08:56:50 -04:00
C2026-041-invisible-position-changes-as-differences

Is this using used?

mschill suggested changes for Volian/SourceCode#807 2026-09-02 08:41:59 -04:00
C2026-041-invisible-position-changes-as-differences

see notes I will follow up with Devin and John and send an email.

mschill commented on pull request Volian/SourceCode#807 2026-09-02 08:41:59 -04:00
C2026-041-invisible-position-changes-as-differences

was changing the size of this intentional?

mschill commented on pull request Volian/SourceCode#807 2026-09-02 08:41:59 -04:00
C2026-041-invisible-position-changes-as-differences

This should not have been added / I believe this is not used.

mschill commented on pull request Volian/SourceCode#807 2026-09-02 08:41:59 -04:00
C2026-041-invisible-position-changes-as-differences

Write should be removed - it is not called from anywhere.

mschill pushed to C2026-043-Tech-Debt_v1 at Volian/SourceCode 2026-09-01 08:26:33 -04:00
dc5d547449 CSLA - Format, Minimal, VEObject
mschill pushed to C2026-043-Tech-Debt_v1 at Volian/SourceCode 2026-09-01 08:18:10 -04:00
dab65dbfb6 CSLA - Extension
mschill pushed to C2026-043-Tech-Debt_v1 at Volian/SourceCode 2026-08-31 10:59:42 -04:00
dcd2fbc294 Merge branch 'Development' into C2026-043-Tech-Debt_v1
298dfaeece Merge pull request 'F2026-021 Fixed the inheritance of the new step type “Step with Section Num” to allow RNO and sub items. Removed the period between the section number and high level step number.' (#811) from F2026-021_Ginna_Appendex_Num_Step_Prefix into Development
ae94400fff F2026-021 Fixed the inheritance of the new step type “Step with Section Num” to allow RNO and sub items. Removed the period between the section number and high level step number.
8a33bcafe8 Merge pull request 'F2026-021 Ginna EOP/AOP Format, added a high level step type called “Step with Section Num”' (#810) from F2026-021_Ginna_Appendex_Num_Step_Prefix into Development
dcf9c03738 F2026-021 Ginna EOP/AOP Format, added a high level step type called “Step with Section Num”
Compare 5 commits »
mschill pushed to Development at Volian/SourceCode 2026-08-28 14:36:02 -04:00
8a33bcafe8 Merge pull request 'F2026-021 Ginna EOP/AOP Format, added a high level step type called “Step with Section Num”' (#810) from F2026-021_Ginna_Appendex_Num_Step_Prefix into Development
dcf9c03738 F2026-021 Ginna EOP/AOP Format, added a high level step type called “Step with Section Num”
Compare 2 commits »