Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor thing but concatenating together string like this takes memory - would recommend using

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor thing but concatenating together string like this takes memory - would recommend using

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor thing but concatenating together string like this takes memory - would recommend using

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor thing but concatenating together string like this takes memory - would recommend using

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:45:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

this line (line 100), 104, 223, & 227 are examples of what I was referring to with changes changing spacing / format.

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:37:37 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Still valid - StepTabRibbon.cs was changed back but StepTabRibbon.designer.cs & StepTabRibbon.resx were not.

mschill commented on pull request Volian/SourceCode#676 2026-01-30 06:32:10 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Comment still here?

mschill commented on pull request Volian/SourceCode#676 2026-01-29 09:21:19 -05:00
C2022-003-Change-Textboxes-to-RTF-3

One side question --- not sure so figured I would check --- why are there changes to StepTabRibbon (StepTabRibbon.cs, StepTabRibbon.designer.cs, StepTabRibbon.resx)?

mschill suggested changes for Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

looks like the only original item still outstanding is minor:

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looping through each character in a string is likely to be time consuming and heavy processing

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looping through each character in a string is likely to be time consuming and heavy processing

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looping through each character in a string is likely to be time consuming and heavy processing

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looping through each character in a string is likely to be time consuming and heavy processing

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looping through each character in a string is likely to be time consuming and heavy processing

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

believe these comments may need rewritten as this is technically new code and replace words should not come into play in RO Editor.

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looping through each character in a string is likely to be time consuming and heavy processing

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

not sure this comment should be here since this is new code and doesn't seam related to SelectionFont?

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

same with comment

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

believe these comments may need rewritten as this is technically new code and this seems to reference PROMS functionality instead of RO Editor functionality..

mschill commented on pull request Volian/SourceCode#676 2026-01-28 16:03:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Should not include commented out code.