I would recommend either it should follow CSLA or it should notmainly for 2 reasons:
- if it half follows CSLA, then we could run into problems down the line if we upgrade CSLA or replace it…
unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?
may be missing something .... but if we are doing a "minimal" implementation --- i.e. not using csla (using sqlconnection and createcommand) for DB access, is there a reason we are using csla's DataPortal_Fetch?
may be missing something .... but if we are doing a "minimal" implementation --- i.e. not using csla (using sqlconnection and createcommand) for DB access, is there a reason we are using csla's DataPortal_Fetch?
might be missing something ---- but Not sure I am understanding why these are compile time --- i.e. System.Runtime.CompilerServices.MethodImpl
Just to double check ---- Since there are many annotation screens, should we be more specific / say this is related to Annotation type filtering through V->Options?
unless reason for keeping the commented out code --- commented out code shouldn't be checked in?
Not sure I understand why a _bak file was created and is being checked in for this?
Not sure I understand why this change was made? / It appears to be the only change to the file?
this should be a new branch based off of development.
07c7718320
Merge pull request 'C2025-038 Code cleanup to prevent multiple events from being assigned to the same method.' (#573) from C2025-038_EventCalls into Development
2953e977ef
C2025-038 Code cleanup to prevent multiple events from being assigned to the same method.
Looks good. Ready for QA testing.
If memory concerns occur, when remove eventhandler, can change: