Matthew Schill

mschill commented on pull request Volian/SourceCode#729

2026-03-09 12:41:13 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

here - it looks like you are concatenating a stringbuilder with a string --- should

mschill commented on pull request Volian/SourceCode#729

2026-03-09 12:41:13 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729

2026-03-09 12:41:13 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill suggested changes for Volian/SourceCode#730

2026-03-09 07:17:43 -04:00

B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

see note ---- could parsing the character as an int cause an exception if it can't be parsed or is null?

mschill commented on pull request Volian/SourceCode#730

2026-03-09 07:17:43 -04:00

B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash

Could there be an exception here with the int.Parse?

mschill suggested changes for Volian/SourceCode#729

2026-03-09 07:09:20 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

See notes.

mschill commented on pull request Volian/SourceCode#729

2026-03-09 07:09:20 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Ideally, these inserts would be done a different way as concatenating SQL together like this could risk sql injection --- that being said - I believe that would be beyond the scope of this project / CSM item.

mschill commented on pull request Volian/SourceCode#729

2026-03-09 07:09:20 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

should this be 160 or 166?

mschill commented on pull request Volian/SourceCode#729

2026-03-09 07:09:20 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Does there need to be a null check / try parse here?

mschill commented on pull request Volian/SourceCode#729

2026-03-09 07:09:20 -04:00

B2026-025_Unicode_removed_from_RO_menu_titles_in_treeview

Should commented out code be removed?

mschill approved Volian/SourceCode#728

2026-03-03 06:39:48 -05:00

B2026-026_RO_Values_in_the_RO_value_textbox_at_the_top_Step_Properties_panel_now_displays_symbols

Looks Good.

mschill pushed to B2026-019 at Volian/SourceCode

2026-03-02 14:12:16 -05:00

f66c6a93c5 Merge branch 'Development' into B2026-019

fe90af5aa4 Merge pull request 'B2026-021-some-symbols-not-being-displayed-correctly' (#726) from B2026-021-some-symbols-not-being-displayed-correctly into Development

7e672d91e9 Merge branch 'Development' of https://git.volian.com/Volian/SourceCode into Development

09f472bee2 Merge pull request 'F2026-011 Vogtle Units 3&4 Backgrounds. Adjusted the section title text for the section 5.0 continue message so that it aligns with the background text on the page' (#725) from F2026-011_VogtleBackgrounds_sect_title_adj into Development

30da0c5105 F2026-011 Vogtle Units 3&4 Backgrounds. Adjusted the section title text for the section 5.0 continue message so that it aligns with the background text on the page

Compare 10 commits »

mschill created pull request Volian/SourceCode#727

2026-03-02 14:12:07 -05:00

B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open

mschill pushed to B2026-019 at Volian/SourceCode

2026-03-02 14:10:12 -05:00

a7b5ee33e2 B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open

mschill approved Volian/SourceCode#726

2026-02-27 13:08:23 -05:00

B2026-021-some-symbols-not-being-displayed-correctly

Looks Good to me.

mschill pushed to B2026-019 at Volian/SourceCode

2026-02-27 10:05:30 -05:00

c42596811e Merge branch 'Development' into B2026-019

a657d03fb0 Merge pull request 'F2026-012 Vogtle Units 3&4 Background format. Fixed the step tab for FOP Criteria (foldout background information).' (#723) from F2026-012_VogtleBackgroundFOP into Development

4e829200f5 F2026-012 Vogtle Units 3&4 Background format. Fixed the step tab for FOP Criteria (foldout background information).

56f14323d1 Merge pull request 'B2026-017 Use Pre-typed in information when adding New Applicability' (#722) from B2026-017 into Development

4fcd22ca68 B2026-017 Use Pre-typed in information when adding New Applicability

Compare 8 commits »

mschill created pull request Volian/SourceCode#724

2026-02-27 10:05:22 -05:00

B2026-019

mschill pushed to B2026-019 at Volian/SourceCode

2026-02-27 10:04:14 -05:00

d095a19187 Merge branch 'B2026-019' of https://git.volian.com/Volian/SourceCode into B2026-019

8089e2c898 B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open

Compare 2 commits »

mschill created pull request Volian/SourceCode#722

2026-02-26 15:01:10 -05:00

B2026-017 Use Pre-typed in information when adding New Applicability

mschill pushed to B2026-017 at Volian/SourceCode

2026-02-26 14:59:57 -05:00

4fcd22ca68 B2026-017 Use Pre-typed in information when adding New Applicability