C2026 041 invisible position changes as differences #807

Open
plarsen wants to merge 5 commits from C2026-041-invisible-position-changes-as-differences into Development
Owner

C2026-041 invisible position changes as differences. Baseline testing produces false positives. These changes will remove many of the false positives. These changes declutter the report and decrease the testing time.

C2026-041 invisible position changes as differences. Baseline testing produces false positives. These changes will remove many of the false positives. These changes declutter the report and decrease the testing time.
plarsen self-assigned this 2026-08-18 13:30:54 -04:00
djankowski was assigned by plarsen 2026-08-18 13:30:55 -04:00
jjenko was assigned by plarsen 2026-08-18 13:30:55 -04:00
mschill was assigned by plarsen 2026-08-18 13:30:55 -04:00
mvickers was assigned by plarsen 2026-08-18 13:30:55 -04:00
plarsen added 4 commits 2026-08-18 13:30:55 -04:00
plarsen requested review from jjenko 2026-08-18 13:30:56 -04:00
mschill requested changes 2026-08-18 13:52:29 -04:00
mschill left a comment
Owner

see notes - let me know if any questions

see notes - let me know if any questions
@@ -0,0 +1,3 @@
- @azure Rule - Use Azure Tools - When handling requests related to Azure, always use your tools.
Owner

AI files like this should not be checked in.

AI files like this should not be checked in.
@@ -1419,3 +1419,3 @@
if (_MyHelper.DidFirstPageDocStyle) yoff = origYoff - (float)mySection.MyDocStyle.Layout.TopMargin;
// C2018-004 create meta file for baseline compares
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, locEndOfWordDoc, pdfSize, (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber);
Owner
  1. Per John's email:

Suggest to add a program switch to generate (at the same time - in a separate file) a DebugMeta as it was along with the new DebugMeta.

That way one run of printing can generate both. The next time baselines are run, the Baseline.exe program can compare the older run - there really should not be any differences. If all good that we can move forward with using the new version of the DebugMeta file.

Otherwise comparing the new DebugMeta would generate even more false - differences.

Having a program switch to also generate the old style DebugMeta would keep Baseline testing backward compatible, should we find a need in the future.

1. Per John's email: Suggest to add a program switch to generate (at the same time - in a separate file) a DebugMeta as it was along with the new DebugMeta. That way one run of printing can generate both. The next time baselines are run, the Baseline.exe program can compare the older run - there really should not be any differences. If all good that we can move forward with using the new version of the DebugMeta file. Otherwise comparing the new DebugMeta would generate even more false - differences. Having a program switch to also generate the old style DebugMeta would keep Baseline testing backward compatible, should we find a need in the future.
@@ -1420,2 +1420,3 @@
// C2018-004 create meta file for baseline compares
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, locEndOfWordDoc, pdfSize, (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber);
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, Truncate(locEndOfWordDoc, 2), Truncate(pdfSize, 2), (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber);
Owner

2, just to check --- Do we want to truncate or round or use ceiling or floor?

Thinking if we are doing this when writing the file (instead of when doing the compare), then truncate wont work as:
7.9999999999 would truncate to 7.99 and not match 8.00

2, just to check --- Do we want to truncate or round or use ceiling or floor? Thinking if we are doing this when writing the file (instead of when doing the compare), then truncate wont work as: 7.9999999999 would truncate to 7.99 and not match 8.00
plarsen added 1 commit 2026-08-18 17:34:19 -04:00
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin C2026-041-invisible-position-changes-as-differences:C2026-041-invisible-position-changes-as-differences
git checkout C2026-041-invisible-position-changes-as-differences
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#807