Matthew Schill mschill
  • Joined on 2024-09-05
mschill created branch B2025-065 in Volian/SourceCode 2026-01-02 15:10:50 -05:00
mschill suggested changes for Volian/SourceCode#676 2026-01-02 07:09:08 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I resolved the comments that have had changes.

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:44:22 -05:00
C2022-003-Change-Textboxes-to-RTF-3

This appears to still be in there.

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:35:49 -05:00
C2022-003-Change-Textboxes-to-RTF-3

//StartGridEditing(SelectionOption.Start); // If in a FlexGrid, start the editor for a cell //_MyStepRTB.InsertSymbol(Convert.ToInt32(b.Tag));

are still in code

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:34:29 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I am more questioning why these were removed

as these were here before this project?

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:14:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looks good now.

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:12:33 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looks good now.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 13:57:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

sorry missed it since the lines were changed. It was previously on line 11. - this is good. I will resolve this item.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 13:47:12 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I would say that is the case --- if there are are matches on the backslash not followed by a "u" those need to be replaced.

Likely would have to get matches and the loop through those specific…

mschill commented on pull request Volian/SourceCode#676 2025-12-23 10:14:41 -05:00
C2022-003-Change-Textboxes-to-RTF-3

sorry missed it since the lines were changed. It was previously on line 10. - this is good. I will resolve this item.

mschill suggested changes for Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

see notes. Let me know if you have any questions.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Where is tmp2 used?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

not sure I am understanding why this reference is needed. ctlXMLEdit should depend on RODBInterface instead of the other way around?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

This function doesn't appear to be called from anywhere / used anywhere -- should this be in here / changed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Is this reference needed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not if sure this makes sense --- will this ever get executed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code