C2022-003-Change-Textboxes-to-RTF-3 #701
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Volian/SourceCode#701
Reference in New Issue
Block a user
Delete Branch "C2022-003-Change-Textboxes-to-RTF-3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
C2022-003 The symbols that can be entered into the PROMS editor should be added to the RO editor.
As a FYI - I am still seeing changes to StepTabRibbon.designer.cs & StepTabRibbon.resx --- I believe these were to be restored to match dev / i.e. they should not be any changes to these 2 files as part of this project.
@@ -121,3 +120,3 @@<metadata name="superTooltip1.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"><value>17, 17</value></metadata><data name="btnSaveRO.SuperTooltip" xml:space="preserve">Should this be removed? --- Would check if tooltip for this button still shows appropriately - if so, then this is fine --- if not then this probably shouldn't be removed.
It is not used. I am leaving it as is.
@@ -641,0 +626,4 @@// btnFilter//this.btnFilter.Name = "btnFilter";this.btnFilter.Text = "Tree View Search:";this is missing this.btnFilter.Click += SubmitFilter;
Agreed - this appears to be intendedly that some code was removed.
I added the missing line last night.
@@ -641,0 +635,4 @@"ds in the Procedure Number or Title. Press enter or the Tree View Search button " +"to submit.", null, null, DevComponents.DotNetBar.eTooltipColor.Gray));this.txtFilter.TextBoxWidth = 120;this.txtFilter.WatermarkColor = System.Drawing.SystemColors.GrayText;in general, this txtFilter code looks different appears to be missing code from the orginal.
Agreed - this appears to be intendedly that some code was removed.
I added the missing lines last night.
@@ -1153,6 +1153,7 @@ namespace VEPROMS//this.displayRO.CurROLink = null;this.displayRO.Dock = System.Windows.Forms.DockStyle.Fill;this.displayRO.Font = new System.Drawing.Font("Microsoft Sans Serif", 8.25F, System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(0)));not sure why adding this font reference is needed. assume this was one of those automatic things Visual Studio did. Probably OK to keeep.
@@ -1170,6 +1171,7 @@ namespace VEPROMSthis.tc.ChgId = null;this.tc.Dock = System.Windows.Forms.DockStyle.Fill;this.tc.ForeColor = System.Drawing.SystemColors.ControlText;this.tc.IsInEditorialMode = false;this wasn't in original. assume this was some automatic thing from visual studio
I don't think that the files StepTabRibbon.designer.cs and StepTabRibbon.resx should be include in this push, in that StepTabRibbon.cs was not changed.
major - It appears there are some unintended changes to several files. I recommend undoing the changes to: frmVEPROMS.Designer.cs, frmVEPROMS.resx, StepTabRibbon.designer.cs, & StepTabRibbon.resx
minor - I recommend reviewing these to understand for future code but not necessarily changing currently in order to not hold up this project further.
@@ -280,6 +281,7 @@ namespace ROEditorthis.tbXYPlotWid.Size = new System.Drawing.Size(40, 22);this.tbXYPlotWid.TabIndex = 11;this.tbXYPlotWid.Text = "";this.tbXYPlotWid.KeyDown += new System.Windows.Forms.KeyEventHandler(this.txtBox_KeyDown);minor ---- in the future, would recommend
tbXYPlotWid.KeyDown += txtBox_KeyDown;
as we noticed that sometimes the designer does not like the new KeyPressEventHandler
see email from mschill@volian.com from "Thu 1/29/2026 7:38 AM" titled "RE: Do either of you get this when displaying the frmveproms form designer?"
Since this is minor, I will not be mentioning this in other places / files - I am simply mentioning it here so there is awareness for future projects/code changes.
@@ -589,0 +598,4 @@string clpBrd = Clipboard.GetText();if (clpBrd.Any(c => c > 166)){MessageBox.Show("Symbols are not allowed in the field. Clipbroad: '" + clpBrd + "'");minor - Performance String Concatenation
This is minor since it is not in a loop - but every time you add strings together it creates a string for each piece added together then destroys and re-creates when added. In a loop or when doing a lot of it, a stringbuilder is recommended. If it is one line and you simply want to put a variable into the string then string interpolation is the recommended way. SonarLint will even do a recommendation and can fix it for you (see screenshot attached).
with string interpolation this would look like:
MessageBox.Show("Symbols are not allowed in the field. Clipbroad: '{clpBrd)'");
you could also technically use string.format to create the interpolated string.
Since this is minor, I will not be mentioning this in other places / files - I am simply mentioning it here so there is awareness for future projects/code changes.
@@ -372,3 +384,4 @@private System.Windows.Forms.TreeView roTreeView;private System.Windows.Forms.ListView roListView;private System.Windows.Forms.ToolBar tbar;minor formatting / spacing concerns still remain - since we have previously discussed and mentioned these, will leave as-is.
@@ -1674,0 +1818,4 @@this.Controls.Add(this.panel1);this.Controls.Add(this.splitter1);this.Controls.Add(this.roTreeView);//this.Controls.Add(this.tbar);minor - remove commented out code
@@ -2609,2 +2754,2 @@tbtnSave.Enabled = false;tbtnSaveAs.Enabled = false;duplicate_active = false;minor - duplicate code - this line is in here twice -lines 2755 & 2761
@@ -2729,2 +2876,2 @@tbtnSave.Enabled = false;tbtnSaveAs.Enabled = false;menuROSave.Enabled = false;minor - this line is here twice - duplicate code - see lines 2877 & 2884
@@ -2808,2 +2958,2 @@tbtnSaveAs.Enabled = false;tbtnDuplicate.Enabled = true;duplicate_active = false;minor - duplicate code --- this line is here twice - lines 2959 & 2966
@@ -641,0 +634,4 @@this.superTooltip1.SetSuperTooltip(this.txtFilter, new DevComponents.DotNetBar.SuperTooltipInfo("Filter", "", "This will filter the Procedure Tree in PROMS to Procedures containing entered wor" +"ds in the Procedure Number or Title. Press enter or the Tree View Search button " +"to submit.", null, null, DevComponents.DotNetBar.eTooltipColor.Gray));this.txtFilter.TextBoxWidth = 120;Are we removing functionality? ----- noticed we removed the this.txtFilter.TextBox.KeyPress?
looks like there are other changes also?
like:
this.btnFilter.Click
&
this.txtFilter.TextBox.Font
now missing?
@@ -1153,6 +1158,7 @@ namespace VEPROMS//this.displayRO.CurROLink = null;this.displayRO.Dock = System.Windows.Forms.DockStyle.Fill;this.displayRO.Font = new System.Drawing.Font("Microsoft Sans Serif", 8.25F, System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(0)));minor - It looks like this is already being done in displayRO?
major - As such, since this appears to be the only intended change to frmVEPROMS.Designer.cs, frmVEPROMS.resx and there appear multiple unintended changes to these files, I would recommend not including this in your check in.
Looks Good.
Will need to wait to merge into Development when ready (we are going to wait until Vogtle 3/4 has gone out).
Once ready, will need to do 1 commit with an update of this branch to bring in any dev changes since last merged. Then this should be able to merge into dev (we may want a quick review for audit sake - though it will really be nothing more than a quick sign off)
approving changes.
Will hold on merging into development until after Vogtle release goes out