Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#574 2025-07-14 08:20:27 -04:00
C2025-027-AnnotationsTypeSelect

may be missing something .... but if we are doing a "minimal" implementation --- i.e. not using csla (using sqlconnection and createcommand) for DB access, is there a reason we are using csla's DataPortal_Fetch?

mschill commented on pull request Volian/SourceCode#574 2025-07-14 08:20:10 -04:00
C2025-027-AnnotationsTypeSelect

may be missing something .... but if we are doing a "minimal" implementation --- i.e. not using csla (using sqlconnection and createcommand) for DB access, is there a reason we are using csla's DataPortal_Fetch?

mschill commented on pull request Volian/SourceCode#574 2025-07-14 08:10:56 -04:00
C2025-027-AnnotationsTypeSelect

might be missing something ---- but Not sure I am understanding why these are compile time --- i.e. System.Runtime.CompilerServices.MethodImpl

mschill commented on pull request Volian/SourceCode#574 2025-07-14 07:59:28 -04:00
C2025-027-AnnotationsTypeSelect

Just to double check ---- Since there are many annotation screens, should we be more specific / say this is related to Annotation type filtering through V->Options?

mschill commented on pull request Volian/SourceCode#574 2025-07-14 07:57:59 -04:00
C2025-027-AnnotationsTypeSelect

unless reason for keeping the commented out code --- commented out code shouldn't be checked in?

mschill commented on pull request Volian/SourceCode#574 2025-07-14 07:56:58 -04:00
C2025-027-AnnotationsTypeSelect

Not sure I understand why a _bak file was created and is being checked in for this?

mschill commented on pull request Volian/SourceCode#574 2025-07-14 07:56:27 -04:00
C2025-027-AnnotationsTypeSelect

Not sure I understand why this change was made? / It appears to be the only change to the file?

mschill commented on pull request Volian/SourceCode#544 2025-07-14 07:53:14 -04:00
C2025-027-Develop-a-way-to-filter-annotations-so-the-user-can-view-only-the-types-they-want-to-see-EP

this should be a new branch based off of development.

mschill closed pull request Volian/SourceCode#544 2025-07-14 07:53:14 -04:00
C2025-027-Develop-a-way-to-filter-annotations-so-the-user-can-view-only-the-types-they-want-to-see-EP
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-11 15:25:16 -04:00
ec8e4c36a4 C2025-024 Electronic Procedures - Phase 2 (PROMS XML output)
mschill merged pull request Volian/SourceCode#573 2025-07-10 11:23:26 -04:00
C2025-038 Code cleanup to prevent multiple events from being assigned to the same method.
mschill pushed to Development at Volian/SourceCode 2025-07-10 11:23:26 -04:00
07c7718320 Merge pull request 'C2025-038 Code cleanup to prevent multiple events from being assigned to the same method.' (#573) from C2025-038_EventCalls into Development
2953e977ef C2025-038 Code cleanup to prevent multiple events from being assigned to the same method.
Compare 2 commits »
mschill commented on pull request Volian/SourceCode#573 2025-07-10 11:22:44 -04:00
C2025-038 Code cleanup to prevent multiple events from being assigned to the same method.

If memory concerns occur, when remove eventhandler, can change:

mschill created branch C2025-024 in Volian/SourceCode 2025-06-30 14:31:04 -04:00
mschill pushed to C2025-024 at Volian/SourceCode 2025-06-30 14:31:04 -04:00
92522b1229 C2025-024 Electronic Procedures - Phase 2 (PROMS XML output)
mschill commented on pull request Volian/SourceCode#565 2025-06-20 15:36:07 -04:00
C2025-023 Electronic Procedures - Modifications to PROMS (Phase 1)

you need to change the RevDate and a RevDescription in the the PROMSFixes file

updated revision wording

mschill pushed to C2025-023 at Volian/SourceCode 2025-06-20 15:34:48 -04:00
83e935a3f4 C2025-023 updated revision wording
mschill pushed to C2025-023 at Volian/SourceCode 2025-06-20 14:38:14 -04:00
4d96e73866 Remove from checkin - should be in phase 2
mschill pushed to C2025-023 at Volian/SourceCode 2025-06-20 14:32:32 -04:00
a55ce75e2e C2025-023 Bringing branch up to date to resolve merge conflicts