Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

There are all these: galleryContainerSymbolsCM, CM3, galleryContainerSymbolsGrid, etc...

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not critical -- but just a side suggestion to make things easier for future possible changes ---- I would suggest reviewing this file and try to fix some of the spacing issues --- there are a lot of items showing as changes that are not actual changes (i.e. removed blank lines or added / removed spaces) -- this makes it difficult to tell what was / wasn't changed and more likely to miss something / make a mistake. It also means that all these items will show up in history as being changed by this project. This could make diagnosing future issues more difficult (i.e. something that may have always been a certain way may appear it was changed with this project.)

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

What is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

What project is this that is being added to this solution?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Can simplify this to have less executions / possibly use LINQ. See recommendations that SonrLint Visual Studio Ext will give.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:52 -05:00
C2022-003-Change-Textboxes-to-RTF-3

It looks like this function isn't called by anything - we should remove code that isn't called.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:52 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code,

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:52 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Should these lines be removed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:52 -05:00
C2022-003-Change-Textboxes-to-RTF-3

remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:52 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what does this do? / is this used?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:52 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not seeing where this is needed - should this be here?

mschill created pull request Volian/SourceCode#674 2025-12-16 14:41:38 -05:00
Rollback_B2025-064
mschill pushed to Rollback_B2025-064 at Volian/SourceCode 2025-12-16 14:40:31 -05:00
7d63e7e417 Rollback_B2025-064 - Rolling back changes for B2025-064 - that CSM item will be re-opened and revisited late January once vogtle is out.