Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

commented out code should be removed or reason given for why it is commented out / should be in the code long term.

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:08:16 -04:00
C2025-027-AnnotationsTypeSelect

Would remove dltFlg and commented out code since no longer used.

mschill pushed to C2025-024 at Volian/SourceCode 2025-07-21 13:46:20 -04:00
ecb9a805e5 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-18 16:12:09 -04:00
0577acad93 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-18 14:51:00 -04:00
d7f83fa4d4 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-18 13:25:14 -04:00
4c4f4d52d2 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-17 13:58:03 -04:00
0bf9025c0d C2025-024 Electronic Procedures Phase 2 - XML Export
mschill commented on pull request Volian/SourceCode#574 2025-07-17 08:40:48 -04:00
C2025-027-AnnotationsTypeSelect

I would add them as 1 combined index as I don't think you would ever be providing one without the other ----- also, what should the included columns be for the index?

Should there be a…

mschill commented on pull request Volian/SourceCode#574 2025-07-16 15:29:17 -04:00
C2025-027-AnnotationsTypeSelect

not sure if this would help --- but just a thought - passing in a whole table of the annotationtypeselections instead of doing 1 update/insert at a time and then doing a merge with the current…

mschill commented on pull request Volian/SourceCode#574 2025-07-16 15:24:10 -04:00
C2025-027-AnnotationsTypeSelect

sounds good. Just wanted to double check since this existed before your changes that removing it wasn't going to impact something else.

mschill commented on pull request Volian/SourceCode#574 2025-07-16 15:16:21 -04:00
C2025-027-AnnotationsTypeSelect

was this (ProcItem = CurrentItem.MyProcedure;) intended to be removed?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 15:12:29 -04:00
C2025-027-AnnotationsTypeSelect

UsrID is the id of the PROMS user. Userid is the user id that created the annotation type.

can we either --- use something else like CreatedBy or add a comment in the SQL.

mschill commented on pull request Volian/SourceCode#574 2025-07-16 15:11:13 -04:00
C2025-027-AnnotationsTypeSelect

I would add them as 1 combined index as I don't think you would ever be providing one without the other ----- also, what should the included columns be for the index?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 15:09:17 -04:00
C2025-027-AnnotationsTypeSelect

Must be missing something .... Not sure I understand why we are deleting items and reentering them ...... wouldn't we lose history on when they were originally put in if we do that?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 14:28:04 -04:00
C2025-027-AnnotationsTypeSelect

this line is: cbGridAnnoType.DataSource = AnnotationTypeInfoList.Get().Clone();

2-4 lines below have:

cbGridAnnoType.DataSource = VEPROMS.CSLA.Library.AnnotationstypeSelections.Get(MyUserInf…

mschill pushed to C2025-024 at Volian/SourceCode 2025-07-16 14:22:44 -04:00
2784b57a05 C2025-023 - Electronic Procedures - Modifications to PROMS
mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

Now, this is a method with everything inside commented out --- if no code is to execute, should the method be removed?

mschill commented on pull request Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

Should this be named something other than buttonX1?

mschill suggested changes for Volian/SourceCode#574 2025-07-16 10:25:44 -04:00
C2025-027-AnnotationsTypeSelect

I re-reviewed this morning.