this should be removed if data set is set to something else (see 2 lines after this)
unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?
commented out code should be removed or reason given for why it is commented out / should be in the code long term.
just to double check --- Is there a reason we are updating the DisplayMember / ValueMember every time we go through the loop?
just to check - is there a reason these 2 items (the id and NameStr) are global variables / should stay in memory while the form is open?
commented out code should be removed or reason given for why it is commented out / should be in the code long term.
commented out code should be removed or reason given for why it is commented out / should be in the code long term.
commented out code should be removed or reason given for why it is commented out / should be in the code long term. (lines 122-127)
Now, this is a method with everything inside commented out --- if no code is to execute, should the method be removed?
I would recommend either it should follow CSLA or it should notmainly for 2 reasons:
- if it half follows CSLA, then we could run into problems down the line if we upgrade CSLA or replace it…
unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?