Matthew Schill mschill
  • Joined on 2024-09-05
mschill created branch C2026-012 in Volian/SourceCode 2026-02-04 13:23:38 -05:00
mschill pushed to C2026-012 at Volian/SourceCode 2026-02-04 13:23:38 -05:00
22280bf1e3 C2026-012 Manage Security - Remove cancel from the prompts related to deleting groups/users/members.
mschill approved Volian/SourceCode#701 2026-02-04 11:11:48 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looks Good.

mschill pushed to C2022-003-Change-Textboxes-to-RTF-3 at Volian/SourceCode 2026-02-04 10:45:54 -05:00
30aedb6eec C2022-003-Change-Textboxes-to-RTF-3
mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:40 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - remove commented out code

mschill suggested changes for Volian/SourceCode#701 2026-02-04 07:41:40 -05:00
C2022-003-Change-Textboxes-to-RTF-3

major - It appears there are some unintended changes to several files. I recommend undoing the changes to: frmVEPROMS.Designer.cs, frmVEPROMS.resx, StepTabRibbon.designer.cs, & StepTabRibbon.resx

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Are we removing functionality? ----- noticed we removed the this.txtFilter.TextBox.KeyPress?

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

looks like there are other changes also?

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - It looks like this is already being done in displayRO?

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - Performance String Concatenation

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor ---- in the future, would recommend

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - this line is here twice - duplicate code - see lines 2877 & 2884

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - duplicate code - this line is in here twice -lines 2755 & 2761

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor - duplicate code --- this line is here twice - lines 2959 & 2966

mschill commented on pull request Volian/SourceCode#701 2026-02-04 07:41:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

minor formatting / spacing concerns still remain - since we have previously discussed and mentioned these, will leave as-is.

mschill commented on pull request Volian/SourceCode#701 2026-02-04 06:38:56 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Agreed - this appears to be intendedly that some code was removed.

mschill commented on pull request Volian/SourceCode#701 2026-02-04 06:38:33 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Agreed - this appears to be intendedly that some code was removed.

mschill commented on pull request Volian/SourceCode#701 2026-02-03 13:53:04 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Should this be removed? --- Would check if tooltip for this button still shows appropriately - if so, then this is fine --- if not then this probably shouldn't be removed.

mschill approved Volian/SourceCode#701 2026-02-03 13:50:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

As a FYI - I am still seeing changes to StepTabRibbon.designer.cs & StepTabRibbon.resx --- I believe these were to be restored to match dev / i.e. they should not be any changes to these 2 files as part of this project.

mschill created pull request Volian/SourceCode#700 2026-02-03 13:30:42 -05:00
B2026-011 Improve the resolution of unit numbers in multi-unit background documents when printing.