Matthew Schill mschill
  • Joined on 2024-09-05
mschill commented on pull request Volian/SourceCode#676 2025-12-23 10:14:41 -05:00
C2022-003-Change-Textboxes-to-RTF-3

sorry missed it since the lines were changed. It was previously on line 10. - this is good. I will resolve this item.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Maybe I am missing something but I am not seeing this function being called anywhere?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

see notes below. It looks like these sreg variables are never used.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

It looks like this function is never called?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Remove commented out code

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

what is this needed for?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not if sure this makes sense --- will this ever get executed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Is this reference needed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

This function doesn't appear to be called from anywhere / used anywhere -- should this be in here / changed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

not sure I am understanding why this reference is needed. ctlXMLEdit should depend on RODBInterface instead of the other way around?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Where is tmp2 used?

mschill suggested changes for Volian/SourceCode#676 2025-12-23 08:56:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

see notes. Let me know if you have any questions.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

A new class like this or extending an existing class should be in it's own cs file so it can be found easily. --- also, otherwise it may be difficult to tell when it will work or not.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Maybe I am missing something, but it looks like the only place this is called from is StaticStripRtfCommands - which is never called --- so this code will never be called / executed?

mschill commented on pull request Volian/SourceCode#676 2025-12-23 08:56:53 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not sure this comment is correct.