Matthew Schill mschill
0 Followers · 0 Following
  • Joined on 2024-09-05
Repositories Projects Packages Public Activity Starred Repositories
mschill commented on pull request Volian/SourceCode#574 2025-07-28 07:48:20 -04:00
C2025-027-AnnotationsTypeSelect

This is still valid.

I thought Name was being removed from AnntationsSelections and just going to be pulled from AnnotationsType?

Also, not sure what Config is for here?

mschill pushed to C2025-024 at Volian/SourceCode 2025-07-24 08:07:12 -04:00
8c32d18aec C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-23 15:25:39 -04:00
20c31153de C2025-024 Electronic Procedures Phase 2 - XML Export
mschill commented on pull request Volian/SourceCode#574 2025-07-22 16:01:25 -04:00
C2025-027-AnnotationsTypeSelect

As FYI - still valid

mschill commented on pull request Volian/SourceCode#574 2025-07-22 16:00:44 -04:00
C2025-027-AnnotationsTypeSelect

As FYI - still valid

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Shouldn't need this as foreach loop below should loop 0 times if no rows.

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

I am not sure why this has an IsEPAnnotationType?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Can there be Config Data for this?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

if commented out, should be removed or reason given why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Wouldn't you want the index on UsrID,TypeID?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

see earlier note - will get better performance if

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

If commented out, would remove or give reason why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Wouldn't this delete ones by other users?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Can name be different than the AnnotationTypes.Name?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

I could be wrong but I thought some of these were being removed and joins done to the AnnotationType table to get things like Name, IsEpAnnotationType, etc...?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

if commented out, should be removed or reason given why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

If commented out, would remove or give reason why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

So, shouldn't NameStr not be part of the AnnotationTypeSelections and instead pull from AnnotationTypes?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

If commented out, would remove or give reason why commented out?

mschill suggested changes for Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Let me know if you have any questions on my added notes.