Also as a heads up - I sent an email with an attachment --- looks like there is a side consequence to having Userid be part of the table type and not separate --- that side consequence occurs if…
won't this wipe out all thier pre-existing data every time PROMSFixes is run?
I closed this previous comment since it moved down and reposted here - "Shouldn't need this as foreach loop below should loop 0 times if no rows."
I thought Name was being removed from AnntationsSelections and just going to be pulled from AnnotationsType?
Would suggest not having columns named both UserID and UserID in the same table as it is confusing which is the function of each,
Shouldn't need NameStr or RowID unless I am missing something as these are not columns in AnnotationSelections
only need to delete the ones not already in the table. If we delete and re-add then will lose history of when truely added --- see comment below (around line 24278) for more complete,
still appears to be:
//dt.Rows.Add(DataPortal.Fetch()); //DataPortal.Fetch();
would think would want to do something like:
--this would delete only the ones for this User that are not in the uploaded table DELETE FROM AnnotationTypeSelections where UsrID in (Select…
would not loop through this is will perform poorly and should not be necessary. It looks like my previous comment got removed with this change as it is now past the end of this file, so I will…
There is another comment around line 24235that is related to this. It just moved since there have been changes since that comment was made. That one should have likely the exact index needed.
still valid - this refers to the query in getAnnotationSelectListTypes around line: 24148
Comment still valid:
index should be UNIQUE by UsrID, TypeID and INCLUDE other columns pulled back like: ASTypeID