Matthew Schill mschill
  • Joined on 2024-09-05
mschill suggested changes for Volian/SourceCode#676 2026-01-06 14:44:54 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I resolved the comments that have had changes.

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:41:14 -05:00
C2022-003-Change-Textboxes-to-RTF-3

still outstanding?

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:40:12 -05:00
C2022-003-Change-Textboxes-to-RTF-3

still outstanding?

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:39:30 -05:00
C2022-003-Change-Textboxes-to-RTF-3

still outstanding?

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:39:22 -05:00
C2022-003-Change-Textboxes-to-RTF-3

still outstanding?

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:36:15 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Not seeing any changes here - not sure if I am missing something.

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:35:37 -05:00
C2022-003-Change-Textboxes-to-RTF-3

resolving this item - with stringbuilder, should at least be better memory / performance wise.

mschill commented on pull request Volian/SourceCode#676 2026-01-06 14:33:58 -05:00
C2022-003-Change-Textboxes-to-RTF-3

not sure if I am missing something but it looks like changes / reg-ex to AccPageID are still in here?

mschill commented on pull request Volian/SourceCode#676 2026-01-06 08:12:12 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Sta minimum - would suggest not concatenating strings in a loop and using stringbuilder instead.

Here is an article I found detailing why shouldn't concat strings in a loop - they explain it…

mschill created pull request Volian/SourceCode#677 2026-01-02 15:11:53 -05:00
B2025-065 When Printing a Word Section containing XY Plot ROs - when there is a title on the XY Plot, only the first line is indented.
mschill created branch B2025-065 in Volian/SourceCode 2026-01-02 15:10:50 -05:00
mschill pushed to B2025-065 at Volian/SourceCode 2026-01-02 15:10:50 -05:00
dae850616d B2025-065 When Printing a Word Section containing XY Plot ROs - when there is a title on the XY Plot, only the first line is indented.
mschill suggested changes for Volian/SourceCode#676 2026-01-02 07:09:08 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I resolved the comments that have had changes.

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:44:22 -05:00
C2022-003-Change-Textboxes-to-RTF-3

This appears to still be in there.

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:35:49 -05:00
C2022-003-Change-Textboxes-to-RTF-3

//StartGridEditing(SelectionOption.Start); // If in a FlexGrid, start the editor for a cell //_MyStepRTB.InsertSymbol(Convert.ToInt32(b.Tag));

are still in code

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:34:29 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I am more questioning why these were removed

as these were here before this project?

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:14:01 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looks good now.

mschill commented on pull request Volian/SourceCode#676 2026-01-02 06:12:33 -05:00
C2022-003-Change-Textboxes-to-RTF-3

Looks good now.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 13:57:39 -05:00
C2022-003-Change-Textboxes-to-RTF-3

sorry missed it since the lines were changed. It was previously on line 11. - this is good. I will resolve this item.

mschill commented on pull request Volian/SourceCode#676 2025-12-23 13:47:12 -05:00
C2022-003-Change-Textboxes-to-RTF-3

I would say that is the case --- if there are are matches on the backslash not followed by a "u" those need to be replaced.

Likely would have to get matches and the loop through those specific…