Matthew Schill mschill
0 Followers · 0 Following
  • Joined on 2024-09-05
Repositories Projects Packages Public Activity Starred Repositories
mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

commented out code should be removed or reason given for why it is commented out / should be in the code long term.

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Shouldn't need this as foreach loop below should loop 0 times if no rows.

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

I am not sure why this has an IsEPAnnotationType?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Can there be Config Data for this?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

if commented out, should be removed or reason given why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Wouldn't you want the index on UsrID,TypeID?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

see earlier note - will get better performance if

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

If commented out, would remove or give reason why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Wouldn't this delete ones by other users?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

Can name be different than the AnnotationTypes.Name?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

I could be wrong but I thought some of these were being removed and joins done to the AnnotationType table to get things like Name, IsEpAnnotationType, etc...?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

if commented out, should be removed or reason given why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:29:01 -04:00
C2025-027-AnnotationsTypeSelect

If commented out, would remove or give reason why commented out?

mschill commented on pull request Volian/SourceCode#574 2025-07-22 10:08:16 -04:00
C2025-027-AnnotationsTypeSelect

Would remove dltFlg and commented out code since no longer used.

mschill pushed to C2025-024 at Volian/SourceCode 2025-07-21 13:46:20 -04:00
ecb9a805e5 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-18 16:12:09 -04:00
0577acad93 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-18 14:51:00 -04:00
d7f83fa4d4 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-18 13:25:14 -04:00
4c4f4d52d2 C2025-024 Electronic Procedures Phase 2 - XML Export
mschill pushed to C2025-024 at Volian/SourceCode 2025-07-17 13:58:03 -04:00
0bf9025c0d C2025-024 Electronic Procedures Phase 2 - XML Export
mschill commented on pull request Volian/SourceCode#574 2025-07-17 08:40:48 -04:00
C2025-027-AnnotationsTypeSelect

I would add them as 1 combined index as I don't think you would ever be providing one without the other ----- also, what should the included columns be for the index?

Should there be a…