this should be removed if data set is set to something else (see 2 lines after this)
unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?
commented out code should be removed or reason given for why it is commented out / should be in the code long term.
commented out code should be removed or reason given for why it is commented out / should be in the code long term. (lines 122-127)
Now, this is a method with everything inside commented out --- if no code is to execute, should the method be removed?
I would recommend either it should follow CSLA or it should notmainly for 2 reasons:
- if it half follows CSLA, then we could run into problems down the line if we upgrade CSLA or replace it…
unless reason for keeping the commented out code (should be explained in the comments) --- commented out code shouldn't be checked in?
may be missing something .... but if we are doing a "minimal" implementation --- i.e. not using csla (using sqlconnection and createcommand) for DB access, is there a reason we are using csla's DataPortal_Fetch?
may be missing something .... but if we are doing a "minimal" implementation --- i.e. not using csla (using sqlconnection and createcommand) for DB access, is there a reason we are using csla's DataPortal_Fetch?
might be missing something ---- but Not sure I am understanding why these are compile time --- i.e. System.Runtime.CompilerServices.MethodImpl
Just to double check ---- Since there are many annotation screens, should we be more specific / say this is related to Annotation type filtering through V->Options?
unless reason for keeping the commented out code --- commented out code shouldn't be checked in?