Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 #762

Merged
jjenko merged 3 commits from B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 into Development 2026-05-04 09:11:34 -04:00
Conversation 6 Commits 3 Files Changed 1
+2 -10
plarsen commented 2026-04-30 16:51:11 -04:00
Owner
Copy Link
Copy Source

B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4

B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4
B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column.docx
166 KiB
plarsen self-assigned this 2026-04-30 16:51:12 -04:00
djankowski was assigned by plarsen 2026-04-30 16:51:12 -04:00
jjenko was assigned by plarsen 2026-04-30 16:51:12 -04:00
mvickers was assigned by plarsen 2026-04-30 16:51:12 -04:00
plarsen added 1 commit 2026-04-30 16:51:12 -04:00
C2026-027-New-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 1b1dc78548
plarsen requested review from jjenko 2026-04-30 16:51:25 -04:00
mschill requested changes 2026-05-01 06:28:07 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

With both if statements --- if it is null, do we want it enabled or not?
currently, it wouldn't hit either statement?

With both if statements --- if it is null, do we want it enabled or not? currently, it wouldn't hit either statement?
mschill requested changes 2026-05-01 06:57:40 -04:00
Dismissed
PROMS/Volian.Controls.Library/DisplayApplicability.cs Outdated
@@ -403,3 +406,3 @@
{
if (this.Visible == false) return;
if (_MyItemInfo.IsRNOPart == true) // Check if step is an RNO disable "Set All To Level" button.
if (MyItemInfo != null)
mschill commented 2026-05-01 06:57:30 -04:00
Owner
Copy Link
Copy Source

Also, I am not sure how this would ever get hit as isn't this basically the same check as line 405?

Also, I am not sure how this would ever get hit as isn't this basically the same check as line 405?
jjenko commented 2026-05-01 09:17:08 -04:00
Owner
Copy Link
Copy Source

in addition to Matt's comment, the MyItemInfo references should be "_MyItemInfo" as we are in the Set portion of "MyItemInfo". All of the other references in this Set code use "_MyItemInfo".

in addition to Matt's comment, the MyItemInfo references should be "_MyItemInfo" as we are in the Set portion of "MyItemInfo". All of the other references in this Set code use "_MyItemInfo".
plarsen commented 2026-05-01 16:05:53 -04:00
Author
Owner
Copy Link
Copy Source

The default is enabled. If there _MyItemInfo is null, then the users have not entered a step yet.

The default is enabled. If there _MyItemInfo is null, then the users have not entered a step yet.
mschill commented 2026-05-04 05:54:36 -04:00
Owner
Copy Link
Copy Source

As mentioned above this 2nd if statement that you added is unnecessary - I took a screenshot and attached here to re-illustrate. The part with a purple square is unnecessary because that is already done by the part in the red square.

As mentioned above this 2nd if statement that you added is unnecessary - I took a screenshot and attached here to re-illustrate. The part with a purple square is unnecessary because that is already done by the part in the red square.
CodeReview_5_4_2026.jpg
54 KiB
CodeReview_5_4_2026.jpg
plarsen added 1 commit 2026-05-01 16:26:03 -04:00
B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 90c215d4c1
mschill requested changes 2026-05-04 05:57:47 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

Please let me know if you have any questions - I did a screenshot of the code to re-illustrate.

Please let me know if you have any questions - I did a screenshot of the code to re-illustrate.
plarsen added 1 commit 2026-05-04 08:46:31 -04:00
B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 d0cae8c2fc
mschill approved these changes 2026-05-04 08:48:53 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

With latest change, looks good to me. Ready for QA!

With latest change, looks good to me. Ready for QA!
jjenko approved these changes 2026-05-04 09:10:50 -04:00
jjenko left a comment
Owner
Copy Link
Copy Source

looks good.

looks good.
jjenko merged commit f1e04396de into Development 2026-05-04 09:11:34 -04:00
mvickers commented 2026-05-04 15:40:55 -04:00
Member
Copy Link
Copy Source

Tested with 2.3.2605.409 and found two issues - discussed with software, created videos and reported B2026-044 and C2026-035. After sending that information out, Paul responded that he already knew of B2026-044 and reported as B2026-043. I updated the Word document to reflect the testing requirements for B2026-042 because the document had been submitted as a duplicate of C2026-027.

Tested with 2.3.2605.409 and found two issues - discussed with software, created videos and reported B2026-044 and C2026-035. After sending that information out, Paul responded that he already knew of B2026-044 and reported as B2026-043. I updated the Word document to reflect the testing requirements for B2026-042 because the document had been submitted as a duplicate of C2026-027.
B2026-042_MRV corrected May 4 2026.docx
33 KiB
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
jjenko
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees plarsen djankowski jjenko mvickers
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#762
Delete Branch "B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?