Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Wiki Activity

C2026 043 tech debt v1 #817

Open
mschill wants to merge 43 commits from C2026-043-Tech-Debt_v1 into Development
pull from: C2026-043-Tech-Debt_v1
merge into: :Development
Conversation 3 Commits 43 Files Changed 514
+40371 -80430
mschill commented 2026-09-15 08:31:08 -04:00
Owner
Copy Link
Copy Source

C2026-043 Technical Debt

Phase 1 – This is a clean-up of comments, unnecessary code, etc.. to reduce the overhead when making changes to PROMS in the future,

• Perform Full Functional Testing – executable to use for testing at:
V:\Proms Versions\Test Version\Tech_Debt
• Use this version internally for several weeks for changes to the PROMS manual.

This should not be merged into the Dev branch until the following have been completed.

C2026-043 Technical Debt Phase 1 – This is a clean-up of comments, unnecessary code, etc.. to reduce the overhead when making changes to PROMS in the future, • Perform Full Functional Testing – executable to use for testing at: V:\Proms Versions\Test Version\Tech_Debt • Use this version internally for several weeks for changes to the PROMS manual. This should not be merged into the Dev branch until the following have been completed.
C2026-043_GIT_testing.docx
37 KiB
djankowski was assigned by mschill 2026-09-15 08:31:08 -04:00
jjenko was assigned by mschill 2026-09-15 08:31:08 -04:00
mvickers was assigned by mschill 2026-09-15 08:31:08 -04:00
mschill added 37 commits 2026-09-15 08:31:08 -04:00
C2026-043-Tech-Debt_v1 - Stash 1 9486b37300
Merge branch 'Development' into C2026-043-Tech-Debt_v1 06c3136566
Print Library, Svg Library, Utils Library, XYPlots f67d37801a
AdjustBuildRevision, FlexMsgBx, Formats, LBWordLib, VlnStatus, RoAccessToSql, TablePicker, VG e492f12602
Bring Branch up to date 9c97394f5e
Bring Up to Date 6f0fcdded2
Updates to DropDownPanel, Baseline, & Controls 6d7d127b63
Volian.Base.Library & Baseline b1427f4997
Bring Up To Date with Dev 752d30ba8f
Additional XYPlot cleanup f2e01803bc
Bring branch up to date 23a296df86
VEPROMS_UI / remove BouncyCastle 0c3e4bb3e9
Bring up to date with removed items 3124f64e03
Unfortunately iTextSharp is dependant on BouncyCastle 90398c15ae
Merge branch 'Development' into C2026-043-Tech-Debt_v1 d2883ea2eb
Merge branch 'Development' into C2025-043-Tech-Debt_v1 a567a32064
Fix dlgAnnotationsSelect Designer in solution twice d0587706a2
CSLA Config cleanup f88f8a1c75
Merge branch 'Development' into C2026-043-Tech-Debt_v1 dcd2fbc294
CSLA - Extension dab65dbfb6
CSLA - Format, Minimal, VEObject dc5d547449
CSLA - Generated - Batch - As 222371302f
CSLA - Generated - C Items 8a55eb57d6
Bring Tech Debt up to current Development c21f366bb9
CLSA - Ds a69a2270a6
CSLA - E & F f2b064f459
CSLA - G da8d25082f
Merge branch 'Development' into C2026-043-Tech-Debt_v1 8674b93723
CSLA - Is e41a4ea65d
CSLA - M through P d9f8f6cb37
CSLA - R - Group 1 d238d6aed2
CSLA - R to Z 1c6f3e3e3c
Merge branch 'Development' into C2026-043-Tech-Debt_v1 42f1c1735d
Remove commented out code ac773b8ada
Make Sure Connection is open when working with Local Context 5d4e5d9a1f
Check if connection state is closed before opening 7c95b115e4
avoid Local Context fe95afcf8f
mschill requested review from jjenko 2026-09-15 08:31:08 -04:00
mschill added 1 commit 2026-09-15 13:10:16 -04:00
Merge branch 'Development' into C2026-043-Tech-Debt_v1 17e9a88a16
mschill added 1 commit 2026-09-15 13:27:31 -04:00
Add back in removed side effect code for printing grids with merged cells / checking boundaries a680e8800d
jjenko requested changes 2026-09-21 14:19:00 -04:00
Dismissed
jjenko left a comment
Owner
Copy Link
Copy Source

comments (only one) on the first 75 files.

comments (only one) on the first 75 files.
PROMS/VEPROMS User Interface/frmVEPROMS.cs Outdated
@@ -315,2 +289,4 @@
// cleanup from previous run:
TmpFile.RemoveAllTmps();
if (VlnSettings.DebugMode)
jjenko commented 2026-09-21 13:40:26 -04:00
Owner
Copy Link
Copy Source

This entire If/else statement can be replaced with
Database.ConnectionName = "VEPROMS_LOCAL";

since Rich's computers are no longer active and user BODINE is no longer an employee.

This entire If/else statement can be replaced with Database.ConnectionName = "VEPROMS_LOCAL"; since Rich's computers are no longer active and user BODINE is no longer an employee.
mschill commented 2026-09-22 09:00:05 -04:00
Author
Owner
Copy Link
Copy Source

Pushed change removing this.

Pushed change removing this.
jjenko marked this conversation as resolved
mschill added 1 commit 2026-09-22 08:59:40 -04:00
Clean up in frmVEPROMS.cs --- hard coded based on RICH's PC name 874f9241b8
jjenko requested changes 2026-09-22 16:11:32 -04:00
Dismissed
PROMS/VEPROMS.CSLA.Library/Generated/FormatContents.cs
@@ -213,2 +185,3 @@
private int _FormatID;
public FormatIDCriteria(int formatID) => _FormatID = formatID;
private int _FormatID;
public int FormatID
jjenko commented 2026-09-22 15:57:26 -04:00
Owner
Copy Link
Copy Source

should this be?

public int FormatID =>_formatID;

should this be? public int FormatID =>_formatID;
mschill commented 2026-09-23 05:23:22 -04:00
Author
Owner
Copy Link
Copy Source

Hey John,

Give me a quick call when you get in in the morning and have a minute ---

--- There were a couple items like this:  Since it is Serializable/part of a Serializable class, I didn’t want to change it / it didn’t come up as a compiler suggestion.
     If designing from scratch, definitely would have changed it to expression syntax. Also, since I am going to have to revisit and rewrite all the CSLA files, I wasn't sure it was worth the extra testing time up front.
     Let me know when you have a minute and we can discuss if it is worth changing or not?
Hey John, Give me a quick call when you get in in the morning and have a minute --- --- There were a couple items like this: Since it is Serializable/part of a Serializable class, I didn’t want to change it / it didn’t come up as a compiler suggestion. If designing from scratch, definitely would have changed it to expression syntax. Also, since I am going to have to revisit and rewrite all the CSLA files, I wasn't sure it was worth the extra testing time up front. Let me know when you have a minute and we can discuss if it is worth changing or not?
jjenko marked this conversation as resolved
mschill added 1 commit 2026-09-23 11:00:29 -04:00
Remove SCLA Scoping 8c8c876309
jjenko approved these changes 2026-09-25 10:09:40 -04:00
jjenko left a comment
Owner
Copy Link
Copy Source

Code changes look good and all finding addressed.
Can move to Development once successful testing is completed.

Code changes look good and all finding addressed. Can move to Development once successful testing is completed.
mschill added 1 commit 2026-09-30 10:20:09 -04:00
Bring up to date with Dev -- clearing merge conflicts b2741d341c
mschill added 1 commit 2026-10-01 10:12:07 -04:00
Merge branch 'Development' into C2026-043-Tech-Debt_v1 49a3e647a2
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin C2026-043-Tech-Debt_v1:C2026-043-Tech-Debt_v1
git checkout C2026-043-Tech-Debt_v1
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees djankowski jjenko mvickers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#817