Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

B2026 056 syntax problem in x/y plot #801

Merged
jjenko merged 8 commits from B2026-056-Syntax-problem-in-X/Y-plot into Development 2026-08-10 11:11:09 -04:00
Conversation 6 Commits 8 Files Changed 6
+59 -21
plarsen commented 2026-08-07 12:21:43 -04:00
Owner
Copy Link
Copy Source

B2026-056 Syntax-problem in XY Plot. Add functionality to PROMS to suppress warning and error popups while running PROMS automatically for baseline testing.

B2026-056 Syntax-problem in XY Plot. Add functionality to PROMS to suppress warning and error popups while running PROMS automatically for baseline testing.
B2026-056-Syntac-problem-in-XY-plot.docx
33 KiB
plarsen self-assigned this 2026-08-07 12:21:43 -04:00
djankowski was assigned by plarsen 2026-08-07 12:21:43 -04:00
jjenko was assigned by plarsen 2026-08-07 12:21:43 -04:00
mschill was assigned by plarsen 2026-08-07 12:21:43 -04:00
mvickers was assigned by plarsen 2026-08-07 12:21:43 -04:00
plarsen added 6 commits 2026-08-07 12:21:43 -04:00
Merge branch 'Development' of https://git.volian.com/Volian/SourceCode into Development 9643a71ba5
Merge branch 'Development' of https://git.volian.com/Volian/SourceCode into Development 3c5265cecf
Merge branch 'Development' of https://git.volian.com/Volian/SourceCode into Development 1d634d96fe
B2026-056-Syntax-problem-in-XY-plot 70aa1f4024
B2026-056-Syntac-problem-in-XY-Plot cd9eaaaba1
B2026-056-Syntax-problem-in-XY-plot 70f132540f
plarsen requested review from jjenko 2026-08-07 12:21:43 -04:00
mschill requested review from mschill 2026-08-07 12:33:36 -04:00
jjenko approved these changes 2026-08-07 13:46:04 -04:00
Dismissed
jjenko left a comment
Owner
Copy Link
Copy Source

changes look good

changes look good
mschill requested changes 2026-08-07 13:55:40 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

Looks good except 2 small items with BaseLnSettings.cs related to TechDebt. Let me know if you have any questions.

Looks good except 2 small items with BaseLnSettings.cs related to TechDebt. Let me know if you have any questions.
PROMS/Volian.Base.Library/BaseLnSettings.cs Outdated
@@ -0,0 +1,18 @@
using System;
mschill commented 2026-08-07 13:54:24 -04:00
Owner
Copy Link
Copy Source

These usings appear to be unnecessary.

These usings appear to be unnecessary.
mschill commented 2026-08-10 05:49:02 -04:00
Owner
Copy Link
Copy Source

These usings are here but appear to still be unnecessary - thus should be removed.

These usings are here but appear to still be unnecessary - thus should be removed.
Unnecessary_usings.jpg
72 KiB
Unnecessary_usings.jpg
mschill marked this conversation as resolved
PROMS/Volian.Base.Library/BaseLnSettings.cs
@@ -0,0 +9,4 @@
public static class BaseLnSettings
{
private static bool _blBaseLine = false;
public static bool blBaseLine
mschill commented 2026-08-07 13:54:41 -04:00
Owner
Copy Link
Copy Source

can this be an autoproperty?

can this be an autoproperty?
plarsen added 1 commit 2026-08-09 23:12:19 -04:00
B2026-056-Syntax-problem-in-XY-Plot 6a42800d2c
mschill requested changes 2026-08-10 05:53:33 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

Looks like there are still the unnecessary usings in Baseline.cs - other than that looks good. I pulled down a local copy and took a screenshot to show what I was referring to - let me know if any questions.

This would be 1C in the list of things to check for

Summary of Items to Check For:

  1. Review before check-in
    A. unnecessary changes
    B. unrelated changes
    C. unused check-ins

  2. String Concatenation

  3. Comments / Commented out Code

  4. Unnecessary Code

  5. SonarLint Suggestions

  6. Minor Style (not as important)
    A. Auto properties
    B. Expression Body

Recording of that meeting is saved at: V:\Active Project Files\PROMS Upgrades\2026\Upgrade Technical Debt

Looks like there are still the unnecessary usings in Baseline.cs - other than that looks good. I pulled down a local copy and took a screenshot to show what I was referring to - let me know if any questions. This would be 1C in the list of things to check for **Summary of Items to Check For:** 1. Review before check-in A. unnecessary changes B. unrelated changes C. unused check-ins 2. String Concatenation 3. Comments / Commented out Code 4. Unnecessary Code 5. SonarLint Suggestions 6. Minor Style (not as important) A. Auto properties B. Expression Body Recording of that meeting is saved at: V:\Active Project Files\PROMS Upgrades\2026\Upgrade Technical Debt
Unnecessary_usings.jpg
72 KiB
Unnecessary_usings.jpg
plarsen added 1 commit 2026-08-10 09:59:20 -04:00
B2026-056-Syntax-problem-in-XY-Plot 30b34c3a50
mschill approved these changes 2026-08-10 10:01:21 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

Looks Good to me. Ready for QA.

Looks Good to me. Ready for QA.
jjenko approved these changes 2026-08-10 11:10:56 -04:00
jjenko left a comment
Owner
Copy Link
Copy Source

changes look good

changes look good
jjenko merged commit 7ba3ea8b13 into Development 2026-08-10 11:11:09 -04:00
mvickers commented 2026-08-10 15:55:16 -04:00
Member
Copy Link
Copy Source

Tested and verified the x/y plot syntax error no longer occurs during baseline print, but still displays during regular print. MV 2.3.2608.1011 on 8/10/26.

Tested and verified the x/y plot syntax error no longer occurs during baseline print, but still displays during regular print. MV 2.3.2608.1011 on 8/10/26.
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
jjenko
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees plarsen djankowski jjenko mschill mvickers
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#801