Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2026-046-RO-symbols-and-Annotations #768

Merged
jjenko merged 2 commits from B2026-046-RO-symbols-and-Annotations into Development 2026-05-13 13:43:13 -04:00
Conversation 4 Commits 2 Files Changed 1
+9 -5
plarsen commented 2026-05-13 13:08:54 -04:00
Owner
Copy Link
Copy Source

B2026-046 -RO symbols and Annotations. Symbols were not displayed correctly in the annotations panel.

B2026-046 -RO symbols and Annotations. Symbols were not displayed correctly in the annotations panel.
B2026-046-RO-symbols-and-Annotations.docx
32 KiB
plarsen self-assigned this 2026-05-13 13:08:54 -04:00
djankowski was assigned by plarsen 2026-05-13 13:08:54 -04:00
jjenko was assigned by plarsen 2026-05-13 13:08:54 -04:00
mschill was assigned by plarsen 2026-05-13 13:08:54 -04:00
mvickers was assigned by plarsen 2026-05-13 13:08:54 -04:00
plarsen added 1 commit 2026-05-13 13:08:55 -04:00
B2026-046-RO-symbols-and-Annotations 4b5b06210c
plarsen requested review from mschill 2026-05-13 13:08:55 -04:00
mschill requested changes 2026-05-13 13:13:15 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

looks good other than commented out code

looks good other than commented out code
PROMS/Volian.Controls.Library/AnnotationDetails.cs
@@ -221,3 +222,3 @@
if (!DesignMode) // B2019-043 need to check if we are just saving changes to the user interface
{
rtxbComment.Text = value;
//rtxbComment.Text = value;
mschill commented 2026-05-13 13:11:20 -04:00
Owner
Copy Link
Copy Source

would remove commented out code

would remove commented out code
mschill marked this conversation as resolved
plarsen added 1 commit 2026-05-13 13:35:06 -04:00
B2026-046-RO-symbols-and-Annotations 70782cd655
mschill approved these changes 2026-05-13 13:37:13 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

Looks good to me. Ready for QA!

Looks good to me. Ready for QA!
mschill requested review from jjenko 2026-05-13 13:40:25 -04:00
jjenko approved these changes 2026-05-13 13:42:49 -04:00
jjenko left a comment
Owner
Copy Link
Copy Source

changes look good

changes look good
jjenko merged commit 2d93b652e8 into Development 2026-05-13 13:43:13 -04:00
mvickers commented 2026-05-14 13:48:50 -04:00
Member
Copy Link
Copy Source

works as expected with version 2.3.2605.1314.

works as expected with version 2.3.2605.1314.
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
jjenko
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees plarsen djankowski jjenko mschill mvickers
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#768
Delete Branch "B2026-046-RO-symbols-and-Annotations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?