Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function #765

Merged
jjenko merged 9 commits from B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function into Development 2026-05-07 15:07:29 -04:00
Conversation 8 Commits 9 Files Changed 2
+60 -18
plarsen commented 2026-05-05 07:20:49 -04:00
Owner
Copy Link
Copy Source

B2026-043 Fix Error for Set_At_All_Level button in the Applicability tab evaluates having the button grayed out for the RNO column when-clicked executes function. In the fix I had to move the Set_At_All_Level button above the set of check boxes.

B2026-043 Fix Error for Set_At_All_Level button in the Applicability tab evaluates having the button grayed out for the RNO column when-clicked executes function. In the fix I had to move the Set_At_All_Level button above the set of check boxes.
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function.docx
34 KiB
plarsen self-assigned this 2026-05-05 07:20:49 -04:00
djankowski was assigned by plarsen 2026-05-05 07:20:49 -04:00
jjenko was assigned by plarsen 2026-05-05 07:20:49 -04:00
mschill was assigned by plarsen 2026-05-05 07:20:49 -04:00
mvickers was assigned by plarsen 2026-05-05 07:20:49 -04:00
plarsen added 2 commits 2026-05-05 07:20:50 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function a0e0b1e788
B2026-043-Fix-Error-for-Set_At_AAll_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function ec5229101f
plarsen requested review from jjenko 2026-05-05 07:20:50 -04:00
mschill requested changes 2026-05-05 07:42:27 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

Let me know if any questions.

Mostly just some commented out code that should be cleaned up ---- but could be a small issue with the gpSubItem being dynamically added to gpItem when both are static that could arise if garbage collection happens to occur while running.

Let me know if any questions. Mostly just some commented out code that should be cleaned up ---- but could be a small issue with the gpSubItem being dynamically added to gpItem when both are static that could arise if garbage collection happens to occur while running.
PROMS/Volian.Controls.Library/DisplayApplicability.Designer.cs
@@ -1,3 +1,4 @@
using System.Drawing;
mschill commented 2026-05-05 07:27:05 -04:00
Owner
Copy Link
Copy Source

Is this using necessary to be added?

Is this using necessary to be added?
mschill commented 2026-05-06 15:24:06 -04:00
Owner
Copy Link
Copy Source

if commenting out , should remove

if commenting out , should remove
PROMS/Volian.Controls.Library/DisplayApplicability.Designer.cs Outdated
@@ -36,2 +37,3 @@
this.gpItem = new DevComponents.DotNetBar.Controls.GroupPanel();
this.btnApplicabilitychg2 = new DevComponents.DotNetBar.ButtonItem();
this.gpSubItem = new DevComponents.DotNetBar.Controls.GroupPanel();
//this.btnApplicabilitychg2 = new DevComponents.DotNetBar.ButtonItem();
mschill commented 2026-05-05 07:25:53 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code.

Should not keep commented out code.
mschill marked this conversation as resolved
PROMS/Volian.Controls.Library/DisplayApplicability.Designer.cs Outdated
@@ -113,3 +115,3 @@
this.gpItem.Margin = new System.Windows.Forms.Padding(4);
this.gpItem.Name = "gpItem";
this.gpItem.Padding = new System.Windows.Forms.Padding(13, 12, 13, 37);
//this.gpItem.Padding = new System.Windows.Forms.Padding(13, 20, 13, 37);
mschill commented 2026-05-05 07:26:02 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code.

Should not keep commented out code.
PROMS/Volian.Controls.Library/DisplayApplicability.Designer.cs
@@ -171,2 +199,3 @@
private DevComponents.DotNetBar.Controls.GroupPanel gpItem;
private DevComponents.DotNetBar.ButtonItem btnApplicabilitychg2;
private DevComponents.DotNetBar.Controls.GroupPanel gpSubItem;
//private DevComponents.DotNetBar.ButtonItem btnApplicabilitychg2;
mschill commented 2026-05-05 07:26:15 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code.

Should not keep commented out code.
PROMS/Volian.Controls.Library/DisplayApplicability.cs
@@ -59,6 +60,8 @@ namespace Volian.Controls.Library
foreach (string name in names)
AddItemMode(name.Trim(), (++i).ToString());
AddItemMode("None", "0");
gpItem.Controls.Add(gpSubItem);
mschill commented 2026-05-05 07:37:18 -04:00
Owner
Copy Link
Copy Source

gpSubItem is a pre-existing control - i.e. it is created in the Designer.
gpItem is also a pre-existing control.

Not sure that these should Adding one to another one like this (like it was a dynamic / built on the fly control) here.

Would be difficult to test for --- but
What happens if gpSubItem gets destroyed / garbage collected and you try to add it to gpItem
unlike dynamic controls (like the checkboxes / buttons created here in the code behind, this is not being dynamically created each time the code behind executes.)?

Thinking it (gpSubItem) should either entirely be created dynamically in the code behind or never removed/re-added from the parent control (gpItem) to avoid any issues with garbage collection....

Also, another possibility ---- instead of adding / removing, is it possible to use properties on gpSubItem like Visible and Enabled?

gpSubItem is a pre-existing control - i.e. it is created in the Designer. gpItem is also a pre-existing control. Not sure that these should Adding one to another one like this (like it was a dynamic / built on the fly control) here. Would be difficult to test for --- but What happens if gpSubItem gets destroyed / garbage collected and you try to add it to gpItem unlike dynamic controls (like the checkboxes / buttons created here in the code behind, this is not being dynamically created each time the code behind executes.)? Thinking it (gpSubItem) should either entirely be created dynamically in the code behind or never removed/re-added from the parent control (gpItem) to avoid any issues with garbage collection.... Also, another possibility ---- instead of adding / removing, is it possible to use properties on gpSubItem like Visible and Enabled?
mschill marked this conversation as resolved
PROMS/Volian.Controls.Library/DisplayApplicability.cs
@@ -131,11 +134,17 @@ namespace Volian.Controls.Library
private void AddItemMode(string name, string value)
{
CheckBox cb = new CheckBox();
//cb.BackColor = Color.Beige;
mschill commented 2026-05-05 07:38:02 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code.

Should not keep commented out code.
PROMS/Volian.Controls.Library/DisplayApplicability.cs
@@ -136,3 +143,3 @@
cb.Tag = value;
cb.Dock = DockStyle.Top;
gpItem.Controls.Add(cb);
//cb.Dock = DockStyle.Left;
mschill commented 2026-05-05 07:28:22 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code.

Should not keep commented out code.
PROMS/Volian.Controls.Library/DisplayApplicability.cs
@@ -137,2 +144,3 @@
cb.Dock = DockStyle.Top;
gpItem.Controls.Add(cb);
//cb.Dock = DockStyle.Left;
//gpItem.Controls.Add(cb);
mschill commented 2026-05-05 07:28:33 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code.

Should not keep commented out code.
plarsen added 2 commits 2026-05-05 22:25:50 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function 2a0849fae5
Merge branch 'Development' into B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function 2e39102e7c
mschill requested changes 2026-05-06 06:18:49 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

I believe this still has the same issue as before with the gpsubItem being created in the constructor --- i.e. it is statically part of the class and will be created in the constructor and could potentially be garbage collected as it is removed from the control.

Look at
private void AddItemMode(string name, string value)
as an example - how a new Checkbox cb is created and added to the control on the fly.

I would suggest creating and adding the button in a sub procedure that is called right before the line:
AddItemMode("All", "-1");

I believe this still has the same issue as before with the gpsubItem being created in the constructor --- i.e. it is statically part of the class and will be created in the constructor and could potentially be garbage collected as it is removed from the control. Look at private void AddItemMode(string name, string value) as an example - how a new Checkbox cb is created and added to the control on the fly. I would suggest creating and adding the button in a sub procedure that is called right before the line: AddItemMode("All", "-1");
mschill reviewed 2026-05-06 06:20:25 -04:00
PROMS/Volian.Controls.Library/DisplayApplicability.Designer.cs
@@ -113,3 +110,3 @@
this.gpItem.Margin = new System.Windows.Forms.Padding(4);
this.gpItem.Name = "gpItem";
this.gpItem.Padding = new System.Windows.Forms.Padding(13, 12, 13, 37);
//this.gpItem.Padding = new System.Windows.Forms.Padding(13, 20, 13, 37);
mschill commented 2026-05-06 06:20:25 -04:00
Owner
Copy Link
Copy Source

Should not keep commented out code

Should not keep commented out code
plarsen commented 2026-05-06 07:53:51 -04:00
Author
Owner
Copy Link
Copy Source

removed

removed
mschill marked this conversation as resolved
mschill reviewed 2026-05-06 06:20:42 -04:00
PROMS/Volian.Controls.Library/DisplayApplicability.Designer.cs
@@ -170,3 +168,3 @@
private DevComponents.DotNetBar.Controls.GroupPanel gpMode;
private DevComponents.DotNetBar.Controls.GroupPanel gpItem;
private DevComponents.DotNetBar.ButtonItem btnApplicabilitychg2;
//private DevComponents.DotNetBar.ButtonItem btnApplicabilitychg2;
mschill commented 2026-05-06 06:20:42 -04:00
Owner
Copy Link
Copy Source

should not keep commented out code

should not keep commented out code
plarsen commented 2026-05-06 07:54:03 -04:00
Author
Owner
Copy Link
Copy Source

Removed

Removed
mschill marked this conversation as resolved
plarsen added 1 commit 2026-05-06 07:53:20 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function 3924e2fca5
plarsen added 1 commit 2026-05-07 11:27:41 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function 7bbf62d735
plarsen added 1 commit 2026-05-07 11:31:59 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function 194ca84d38
plarsen added 1 commit 2026-05-07 13:29:00 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function 401fa12851
mschill requested changes 2026-05-07 14:42:53 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

overall looks good - just 1 or 2 unused lines to remove.

overall looks good - just 1 or 2 unused lines to remove.
PROMS/Volian.Controls.Library/DisplayApplicability.cs
@@ -37,1 +38,3 @@
DocVersionConfig dcfg = _MyDisplayTabItem.MyItemInfo.MyDocVersion.MyConfig as DocVersionConfig;
//B2026-043 Fix "Set All At Level" button.
DevComponents.DotNetBar.Controls.GroupPanel gpSubItem = InitializegpSubItem();
gpSubItem.Controls.Clear();
mschill commented 2026-05-07 14:36:47 -04:00
Owner
Copy Link
Copy Source

just a minor thing - but shouldn't need to clear it since it was just created.

just a minor thing - but shouldn't need to clear it since it was just created.
mschill marked this conversation as resolved
PROMS/Volian.Controls.Library/DisplayApplicability.cs
@@ -498,6 +545,7 @@ namespace Volian.Controls.Library
public DisplayApplicability()
{
InitializeComponent();
//InitializegpSubItem(); //B2026-043 Fix "Set All At Level" button.
mschill commented 2026-05-07 14:38:45 -04:00
Owner
Copy Link
Copy Source

should remove commented out code

should remove commented out code
mschill marked this conversation as resolved
plarsen added 1 commit 2026-05-07 14:53:29 -04:00
B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function d07e132216
mschill approved these changes 2026-05-07 14:56:26 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

Looks good to me. Ready for QA.

Looks good to me. Ready for QA.
jjenko approved these changes 2026-05-07 15:07:16 -04:00
jjenko left a comment
Owner
Copy Link
Copy Source

changes look good

changes look good
jjenko merged commit be8bb9c4e1 into Development 2026-05-07 15:07:29 -04:00
mvickers commented 2026-05-07 16:19:58 -04:00
Member
Copy Link
Copy Source

2.3.2605.715 tested and works as expected.

2.3.2605.715 tested and works as expected.
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
jjenko
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees plarsen djankowski jjenko mschill mvickers
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#765
Delete Branch "B2026-043-Fix-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-when-clicked-executes-function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?