Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

C2025-038 Code cleanup to prevent multiple events from being assigned to the same method. #573

Merged
mschill merged 1 commits from C2025-038_EventCalls into Development 2025-07-10 11:23:26 -04:00
Conversation 1 Commits 1 Files Changed 18 +71 -1
jjenko commented 2025-07-10 10:47:20 -04:00
Owner
Copy Link

C2025-038
Code cleanup to prevent multiple events from being assigned to the same method.
This was done in places where we dynamically assign event handlers.

C2025-038 Code cleanup to prevent multiple events from being assigned to the same method. This was done in places where we dynamically assign event handlers.
C2025-038-code_cleanup_events.docx
32 KiB
djankowski was assigned by jjenko 2025-07-10 10:47:20 -04:00
mschill was assigned by jjenko 2025-07-10 10:47:20 -04:00
mvickers was assigned by jjenko 2025-07-10 10:47:20 -04:00
jjenko added 1 commit 2025-07-10 10:47:20 -04:00
jjenko requested review from mschill 2025-07-10 10:47:21 -04:00
mschill approved these changes 2025-07-10 11:22:44 -04:00
mschill left a comment
Owner
Copy Link

Looks good. Ready for QA testing.

Looks good. Ready for QA testing.
PROMS/DropDownPanel/Controls/DropDownPanel.cs
@ -28,7 +28,9 @@ namespace AT.STO.UI.Win
_dropDownHelper = new DropDownWindowHelper();
_dropDownHelper.DropDownClosed -= new DropDownClosedEventHandler(DropDownHelper_DropDownClosed);
mschill commented 2025-07-10 11:19:49 -04:00
Owner
Copy Link

If memory concerns occur, when remove eventhandler, can change:

_dropDownHelper.DropDownClosed -= new DropDownClosedEventHandler(DropDownHelper_DropDownClosed);

to

_dropDownHelper.DropDownClosed -= DropDownHelper_DropDownClosed;

--just adding this for reference, would apply throughout. Can be addressed later if anything comes up - just wanted to add this here for reference in case it comes up down the line.

If memory concerns occur, when remove eventhandler, can change: _dropDownHelper.DropDownClosed -= new DropDownClosedEventHandler(DropDownHelper_DropDownClosed); to _dropDownHelper.DropDownClosed -= DropDownHelper_DropDownClosed; --just adding this for reference, would apply throughout. Can be addressed later if anything comes up - just wanted to add this here for reference in case it comes up down the line.
mschill marked this conversation as resolved
mschill merged commit 07c7718320 into Development 2025-07-10 11:23:26 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees djankowski mschill mvickers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#573
No description provided.
Delete Branch "C2025-038_EventCalls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?