Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C2025-036 - Cleaned up logic in PROMS code that generates the step/sub-step tabs to reduce un-needed processing in certain cases #569

Merged
mschill merged 1 commits from C2025-036_CleanupTabCode into Development 2025-06-18 09:29:11 -04:00
Conversation 2 Commits 1 Files Changed 2
+64 -51
jjenko commented 2025-06-18 09:21:15 -04:00
Owner
Copy Link
Copy Source

C2025-036
Cleaned up logic in PROMS code that generates the step/sub-step tabs to reduce un-needed processing in certain cases:

  • reduced blind calls to string replacement of tokens
  • grouped special formatting logic where obvious to avoided extra checking (for example, of the same format flag)

The code still processes the step tabs more than once, even when just expanding the steps in the editor. Reason is complicated due to side-affect code and difficult to control.

C2025-036 Cleaned up logic in PROMS code that generates the step/sub-step tabs to reduce un-needed processing in certain cases: - reduced blind calls to string replacement of tokens - grouped special formatting logic where obvious to avoided extra checking (for example, of the same format flag) The code still processes the step tabs more than once, even when just expanding the steps in the editor. Reason is complicated due to side-affect code and difficult to control.
C2025-036_codecleanup.docx
32 KiB
djankowski was assigned by jjenko 2025-06-18 09:21:15 -04:00
mschill was assigned by jjenko 2025-06-18 09:21:15 -04:00
mvickers was assigned by jjenko 2025-06-18 09:21:15 -04:00
jjenko added 1 commit 2025-06-18 09:21:15 -04:00
C2025-036 - Cleaned up logic in PROMS code that generates the step/sub-step tabs to reduce un-needed processing in certain cases abec4d9281
jjenko requested review from mschill 2025-06-18 09:21:16 -04:00
mschill approved these changes 2025-06-18 09:28:16 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

Looks good. Ready for QA testing.

Looks good. Ready for QA testing.
mschill merged commit 49bc67a64f into Development 2025-06-18 09:29:11 -04:00
mvickers commented 2025-06-20 12:31:19 -04:00
Member
Copy Link
Copy Source

2.2.2506.1810 - works as expected; additional testing - lydia ran baselines on several sets.

2.2.2506.1810 - works as expected; additional testing - lydia ran baselines on several sets.
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees djankowski mschill mvickers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#569