C2025-027-Develop-a-way-to-filter-annotations-so-the-user-can-view-only-the-types-they-want-to-see-EP #544
jjenko
mschill
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "C2025-027-Develop-a-way-to-filter-annotations-so-the-user-can-view-only-the-types-they-want-to-see-EP"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Develop a way to filter annotations so the user can view only the types they want to see.
May need to discuss --- looks like this branch was based off Development and not C2025-023.
As a result, this has other items included that are not part of this request item ---- this could cause conflicts down the line when we try to merge the multiple branches together.
One other thing I am noticing with this, is it looks like there are quite a few places where there is commented out / un-used code. If there is a reason for this (or John disagrees with me then I am good with it), but IMO at least I think we should reduce the size of the code base by removing the code if it is commented and no longer serves a purpose (i.e. - was the code written and commented out because of possible future changes needed or just stuff for when something was being worked through and not used but left in? - I will comment on an individual example or what I am referring to but there are a number of places this is the case)
I agree with Matt's comments. It does look like this was based off of Development (noticed that It wants to included Matt's latest changes to VLNSvgPageHeader.cs).
Also, looking at the screen shot in the Source Control document, noticed the Select Annotation Type does not have header over the two columns. This could be confusing to customers, especially once Annotation were selected for filtering.
If we want any of the commented out code to hang around, then some text should be added to explain why, even if it say something like keep until it clears testing.
@ -24032,0 +24051,4 @@[DTS] [datetime] NOT NULL,[UserID] [nvarchar](100) NOT NULL,[LastChanged] [timestamp] NOT NULL,[IsEPAnnotationType] [bit] NOT NULLMight be missing something, but not sure why this would have a Is EPAnnotationType?
Since this has a TypeID --- would assume that would get this from:
Select AnnotationTypes.IsEPAnnotationType FROM AnnotationTypes where AnnotationTypes.TypeID = AnnotationTypeSelections.TypeID
Thoughts are if it is being stored in 2 places - how do you keep them in synch / what if they are not in synch?
Again - could easily be missing the reason for this flag, but figured I would double check?
@ -24032,0 +24068,4 @@GO-- =============================================-- Author: <Author,,Name>Should this have Author / description info in it?
@ -24032,0 +24106,4 @@GO-- =============================================-- Author: Matthew SchillShould this have different author / description/etc...?
@ -24032,0 +24110,4 @@-- Create date: 3/21/2025-- Description: Add EP to AnnotationTypes-- =============================================CREATE PROCEDURE [dbo].[getAnnotationTypes2]Should this be something like get AnnotationTypeSelections since it gets the selections not the type details?
@ -24032,0 +24142,4 @@SET QUOTED_IDENTIFIER ONGO-- =============================================Should this have different author / description/etc...?
@ -24032,0 +24185,4 @@GO-- =============================================-- Author: <Author,,Name>Should this have different author / description/etc...?
@ -0,0 +67,4 @@dt.Rows.Add(row);}//row = dt.NewRow();This is an example of what I was referring to with the commented out code as it is very similar to the uncommented code above.
@ -24032,0 +24044,4 @@CREATE TABLE [dbo].[AnnotationTypeSelections]([ASTypeID] [int] IDENTITY(1,1) NOT NULL,[TypeID] [int] NULL,I might be missing something - but seams strange to have this setting at the item level (i.e. turning off showing Annotation types at the item level) --- wouldn't this be overall (under options) or at the MyDocVersion / Section level?
--- again, could easily be missing something but figured I would bring it up.
@ -24032,0 +24042,4 @@SET QUOTED_IDENTIFIER ONGOCREATE TABLE [dbo].[AnnotationTypeSelections](Should there be indexes on this?
a Primary Key / TypeID and ItemID combo?
Checkout
From your project repository, check out a new branch and test the changes.