Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

B2025-004 Remove dependency on stored procedure (GetDisplayTabdata). #492

Merged
jjenko merged 1 commits from B2025-004_v2 into Development 2025-01-22 10:39:24 -05:00
Conversation 2 Commits 1 Files Changed 2
+2 -5
mschill commented 2025-01-22 10:35:54 -05:00
Owner
Copy Link
Copy Source

B2025-004 Remove dependency on stored procedure (GetDisplayTabdata).

Currently, when opening an old sql version with a new executable, GetDisplayTabdata missing causes PROMS to crash and possibly get stuck in a loop. This change is to when it fails to load tabbed data to instead open PROMS but treat it as if no tabs were previously open.

-- Found during testing that needed a few additional items that needed to not create hard errors

B2025-004 Remove dependency on stored procedure (GetDisplayTabdata). Currently, when opening an old sql version with a new executable, GetDisplayTabdata missing causes PROMS to crash and possibly get stuck in a loop. This change is to when it fails to load tabbed data to instead open PROMS but treat it as if no tabs were previously open. -- Found during testing that needed a few additional items that needed to not create hard errors
B2025-004_GIT_testing.docx
36 KiB
mschill added 1 commit 2025-01-22 10:35:54 -05:00
B2025-004 Remove dependency on stored procedure (GetDisplayTabdata). 8803ae2274 
-- Found during testing that needed a few additional items that needed to not create hard errors
mschill requested review from jjenko 2025-01-22 10:36:00 -05:00
djankowski was assigned by mschill 2025-01-22 10:36:07 -05:00
jjenko was assigned by mschill 2025-01-22 10:36:07 -05:00
mvickers was assigned by mschill 2025-01-22 10:36:07 -05:00
jjenko approved these changes 2025-01-22 10:39:06 -05:00
jjenko left a comment
Owner
Copy Link
Copy Source

changes look good

changes look good
jjenko merged commit dba1331556 into Development 2025-01-22 10:39:24 -05:00
mvickers commented 2025-01-22 11:04:19 -05:00
Member
Copy Link
Copy Source

Tested by running an older version of sql fixes, running PROMS version 2.2.2501.2210. Works as expected.

Tested by running an older version of sql fixes, running PROMS version 2.2.2501.2210. Works as expected.
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees djankowski jjenko mvickers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#492