Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS-2 #418

Merged
mschill merged 1 commits from C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS-2 into Development 2024-10-04 09:42:55 -04:00
Conversation 3 Commits 1 Files Changed 4 +389 -1
plarsen commented 2024-10-03 15:14:13 -04:00
Owner
Copy Link

PROMS now remembers which procedures are open in the PROMS edit window and reopen them after the application is closed and re-opened. PROMS remembers the open procedures for every user.

PROMS now remembers which procedures are open in the PROMS edit window and reopen them after the application is closed and re-opened. PROMS remembers the open procedures for every user.
C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS.docx
174 KiB
plarsen self-assigned this 2024-10-03 15:14:13 -04:00
djankowski was assigned by plarsen 2024-10-03 15:14:13 -04:00
jjenko was assigned by plarsen 2024-10-03 15:14:13 -04:00
mvickers was assigned by plarsen 2024-10-03 15:14:13 -04:00
plarsen added 1 commit 2024-10-03 15:14:13 -04:00
plarsen requested review from jjenko 2024-10-03 15:14:28 -04:00
djankowski requested review from mschill 2024-10-04 09:00:30 -04:00
jjenko approved these changes 2024-10-04 09:03:18 -04:00
jjenko left a comment
Owner
Copy Link

code changes look goo.

code changes look goo.
mschill approved these changes 2024-10-04 09:28:16 -04:00
mschill left a comment
Owner
Copy Link

Looks good --- one long term question: We are Deactivating Tabs (i.e. setting DisplayTabTmp.Active = 0) but will records forever remain in that table?

If we never clean it out, over time if the table becomes huge, will there be performance issues?
Not sure if this could be a concern or not, but figured I would mention it in case.

Looks good --- one long term question: We are Deactivating Tabs (i.e. setting DisplayTabTmp.Active = 0) but will records forever remain in that table? If we never clean it out, over time if the table becomes huge, will there be performance issues? Not sure if this could be a concern or not, but figured I would mention it in case.
mschill merged commit a73a8fb993 into Development 2024-10-04 09:42:55 -04:00
mschill commented 2024-10-04 09:52:52 -04:00
Owner
Copy Link

One possibility (to make sure the table does not grow exponentially over time) would be in:
DeactivateStateDisplayTabTmp.sql

at the beginning before setting all to Inactive, if Tabs are already inactive for the user, and older than a week or two, could delete them from the table....

likely other options as well - just one that came to mind if this could be a concern.

One possibility (to make sure the table does not grow exponentially over time) would be in: DeactivateStateDisplayTabTmp.sql at the beginning before setting all to Inactive, if Tabs are already inactive for the user, and older than a week or two, could delete them from the table.... likely other options as well - just one that came to mind if this could be a concern.
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
mschill
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees plarsen djankowski jjenko mvickers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#418
No description provided.
Delete Branch "C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?