Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2024-058-RevisionDate-field-Print-dialog #390

Merged
kruffing merged 5 commits from B2024-058-RevisionDate-field-Print-dialog into Development 2024-08-14 12:04:37 -04:00
Conversation 3 Commits 5 Files Changed 2
+57 -21
plarsen commented 2024-08-13 14:08:24 -04:00
Owner
Copy Link
Copy Source

B2024-058 Revision Date field Print dialog. Added validation to make sure a date is entered in the correct format.

B2024-058 Revision Date field Print dialog. Added validation to make sure a date is entered in the correct format.
B2024-058-RevisionDate-field-Print-dialog.docx
33 KiB
plarsen self-assigned this 2024-08-13 14:08:24 -04:00
djankowski was assigned by plarsen 2024-08-13 14:08:24 -04:00
kruffing was assigned by plarsen 2024-08-13 14:08:24 -04:00
mvickers was assigned by plarsen 2024-08-13 14:08:24 -04:00
plarsen added 4 commits 2024-08-13 14:08:24 -04:00
B2024-058-RevisionDate-field-Print-dialog 4248d40917
B2024-058-RevisionDate-field-Print-dialog d7f829737a
B2024-058-RevisionDate-field-Print-dialog 4bf42be80a
B2024-058-RevisionDate-field-Print-dialog 0eadd3fe33
plarsen requested review from kruffing 2024-08-13 14:08:33 -04:00
kruffing requested changes 2024-08-14 06:33:12 -04:00
Dismissed
kruffing left a comment
Owner
Copy Link
Copy Source

2 comments:

  1. add a comment for the bug/ccr from CSM for change
  2. not sure what tbxRevDate_Validating code is used for:
    private void txbRevDate_Validating(object sender, EventArgs e)
    {
    string x = "";
    x = "this is it";
    }
2 comments: 1) add a comment for the bug/ccr from CSM for change 2) not sure what tbxRevDate_Validating code is used for: private void txbRevDate_Validating(object sender, EventArgs e) { string x = ""; x = "this is it"; }
plarsen added 1 commit 2024-08-14 09:37:27 -04:00
B2024-058-RevisionDate-field-Print-dialog 3f3281e2f4
kruffing approved these changes 2024-08-14 12:04:23 -04:00
kruffing left a comment
Owner
Copy Link
Copy Source

Code review completed successfully

Code review completed successfully
kruffing merged commit 4a6c0ba447 into Development 2024-08-14 12:04:37 -04:00
mvickers commented 2024-08-15 09:26:00 -04:00
Member
Copy Link
Copy Source

Tested with version 2.2.2408.1412 and verified the "Invalid Format" message box displays if an invalid date is entered into the Rev Date field.

Tested with version 2.2.2408.1412 and verified the "Invalid Format" message box displays if an invalid date is entered into the Rev Date field.
Sign in to join this conversation.
Reviewers
No Reviewers
kruffing
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees plarsen djankowski kruffing mvickers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#390