B2024-042 - When replacing a procedure, this change will now replace the procedure correctly and add it to the tree node, previously it would replace th eprocedure, then add a whole new procedure to the node, incorrectly using the copy procedure which … #358

Merged

kruffing merged 2 commits from B2024-042 into Development 2024-07-22 09:45:18 -04:00

Conversation 2 Commits 2 Files Changed 1 +5 -8

klaskey commented 2024-07-19 08:50:43 -04:00

Owner

Copy Link

"Copy Of' being appended to procedures that are replaced where the procedure replaced is the only one in the folder. This should fix that issue. (The problem was related to this specific instance where the copied procedure was actually simply being added as if it was copied and pasted as opposed to simply using the replace functionality. The copied and pasted path appends "Copy Of" to the front, where replacement does not.

"Copy Of' being appended to procedures that are replaced where the procedure replaced is the only one in the folder. This should fix that issue. (The problem was related to this specific instance where the copied procedure was actually simply being added as if it was copied and pasted as opposed to simply using the replace functionality. The copied and pasted path appends "Copy Of" to the front, where replacement does not.

B2024-042.docx

29 KiB

klaskey self-assigned this 2024-07-19 08:50:43 -04:00

djankowski was assigned by klaskey 2024-07-19 08:50:43 -04:00

kruffing was assigned by klaskey 2024-07-19 08:50:43 -04:00

mvickers was assigned by klaskey 2024-07-19 08:50:43 -04:00

klaskey added 1 commit 2024-07-19 08:50:43 -04:00

B2024-042 - When replacing a procedure, this change will now replace the procedure correctly and add it to the tree node, previously it would replace th eprocedure, then add a whole new procedure to the node, incorrectly using the copy procedure which appended "copy of". a1380dbb8a

klaskey requested review from kruffing 2024-07-19 08:50:49 -04:00

klaskey added 1 commit 2024-07-22 09:39:53 -04:00

B2024-042 - Update TreeNodeReplace section when adding a node to working draft (remove unneeded code) bf72a6bf78

kruffing approved these changes 2024-07-22 09:44:29 -04:00

kruffing left a comment

Owner

Copy Link

Code review was successful

Code review was successful

kruffing merged commit c25f501909 into Development 2024-07-22 09:45:18 -04:00

kruffing referenced this issue from a commit 2024-07-22 09:45:20 -04:00

Merge pull request 'B2024-042 - When replacing a procedure, this change will now replace the procedure correctly and add it to the tree node, previously it would replace th eprocedure, then add a whole new procedure to the node, incorrectly using the copy procedure which …' (#358) from B2024-042 into Development

mvickers commented 2024-07-22 10:25:20 -04:00

Member

Copy Link

Version 2.2.2407.2209 - everything tested correctly. Note that typo in the last step of testing on page 1 of the Word file should say "....and the words Copy of should NOT be appended."

Version 2.2.2407.2209 - everything tested correctly. Note that typo in the last step of testing on page 1 of the Word file should say "....and the words Copy of should NOT be appended."

Sign in to join this conversation.

Reviewers

No Reviewers

kruffing

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

djankowski jjenko lbutler mschill mvickers plarsen

No Assignees klaskey djankowski kruffing mvickers

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Volian/SourceCode#358

No description provided.