C2026-041-invisible-position-changes-as-differences #807

Merged
jjenko merged 14 commits from C2026-041-invisible-position-changes-as-differences into Development 2026-09-03 08:56:33 -04:00
Owner

C2026-041 invisible position changes as differences. Baseline testing produces false positives. These changes will remove many of the false positives. These changes declutter the report and decrease the testing time.

C2026-041 invisible position changes as differences. Baseline testing produces false positives. These changes will remove many of the false positives. These changes declutter the report and decrease the testing time.
plarsen self-assigned this 2026-08-18 13:30:54 -04:00
djankowski was assigned by plarsen 2026-08-18 13:30:55 -04:00
jjenko was assigned by plarsen 2026-08-18 13:30:55 -04:00
mschill was assigned by plarsen 2026-08-18 13:30:55 -04:00
mvickers was assigned by plarsen 2026-08-18 13:30:55 -04:00
plarsen added 4 commits 2026-08-18 13:30:55 -04:00
plarsen requested review from jjenko 2026-08-18 13:30:56 -04:00
mschill requested changes 2026-08-18 13:52:29 -04:00
Dismissed
mschill left a comment
Owner

see notes - let me know if any questions

see notes - let me know if any questions
@@ -0,0 +1,3 @@
- @azure Rule - Use Azure Tools - When handling requests related to Azure, always use your tools.
Owner

AI files like this should not be checked in.

AI files like this should not be checked in.
mschill marked this conversation as resolved
@@ -1419,3 +1419,3 @@
if (_MyHelper.DidFirstPageDocStyle) yoff = origYoff - (float)mySection.MyDocStyle.Layout.TopMargin;
// C2018-004 create meta file for baseline compares
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, locEndOfWordDoc, pdfSize, (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber);
Owner
  1. Per John's email:

Suggest to add a program switch to generate (at the same time - in a separate file) a DebugMeta as it was along with the new DebugMeta.

That way one run of printing can generate both. The next time baselines are run, the Baseline.exe program can compare the older run - there really should not be any differences. If all good that we can move forward with using the new version of the DebugMeta file.

Otherwise comparing the new DebugMeta would generate even more false - differences.

Having a program switch to also generate the old style DebugMeta would keep Baseline testing backward compatible, should we find a need in the future.

1. Per John's email: Suggest to add a program switch to generate (at the same time - in a separate file) a DebugMeta as it was along with the new DebugMeta. That way one run of printing can generate both. The next time baselines are run, the Baseline.exe program can compare the older run - there really should not be any differences. If all good that we can move forward with using the new version of the DebugMeta file. Otherwise comparing the new DebugMeta would generate even more false - differences. Having a program switch to also generate the old style DebugMeta would keep Baseline testing backward compatible, should we find a need in the future.
Author
Owner

For the program switch are you referring to the new checkbox in the baseline program or a PROMS switch? I added the new checkbox to baseline.

For the program switch are you referring to the new checkbox in the baseline program or a PROMS switch? I added the new checkbox to baseline.
Owner

this is an old item from a week or two ago.

outstanding items include:

1 performance item --- passing strings and if statements added to BaselineMetaFile.WriteLine
1 cleanup unnecessary usings
1 change to finding debug file ---- should check inside findfiles on an individual file basis whether to use truncated or not. also, should not concatinate strings --- should use path.combine or interpolated strings

this is an old item from a week or two ago. outstanding items include: 1 performance item --- passing strings and if statements added to BaselineMetaFile.WriteLine 1 cleanup unnecessary usings 1 change to finding debug file ---- should check inside findfiles on an individual file basis whether to use truncated or not. also, should not concatinate strings --- should use path.combine or interpolated strings
mschill marked this conversation as resolved
@@ -1420,2 +1420,3 @@
// C2018-004 create meta file for baseline compares
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, locEndOfWordDoc, pdfSize, (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber);
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, Truncate(locEndOfWordDoc, 2), Truncate(pdfSize, 2), (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber);
Owner

2, just to check --- Do we want to truncate or round or use ceiling or floor?

Thinking if we are doing this when writing the file (instead of when doing the compare), then truncate wont work as:
7.9999999999 would truncate to 7.99 and not match 8.00

2, just to check --- Do we want to truncate or round or use ceiling or floor? Thinking if we are doing this when writing the file (instead of when doing the compare), then truncate wont work as: 7.9999999999 would truncate to 7.99 and not match 8.00
mschill marked this conversation as resolved
plarsen added 1 commit 2026-08-18 17:34:19 -04:00
mschill requested changes 2026-08-20 06:33:03 -04:00
Dismissed
mschill left a comment
Owner

see email from 8/19:

Devin, Michelle, & I had a conversation on this this morning and we came to a few decisions:

  1. For Now, we will do changes in the output files --- long term we likely want to change the compare in the baseline program.
  2. Truncate will be fine for now – we will not use Round, Ceiling, or Floor. (we do recognize that there may still be some false positives due to this)
  3. We would like to output 2 files - DebugMeta.txt & DebugMeta_truncate.txt (see code below with potential changes to public static class BaselineMetaFile for a starting point – note it was decided to keep the old file as-is and make the new file truncate --- instead of using full as in the code below)
  4. There will need to be a small change to the UI in the baseline program --- a checkbox for use of truncate decimals when comparing.
    If not checked, will behave as does currently.
    If button is checked, will use DebugMeta_truncate.txt if it exists (instead of DebugMeta.txt). If DebugMeta_truncate.txt does not exist, it will use DebugMeta.txt
    Let’s also have the box checked by Default.
see email from 8/19: Devin, Michelle, & I had a conversation on this this morning and we came to a few decisions: 1. For Now, we will do changes in the output files --- long term we likely want to change the compare in the baseline program. 2. Truncate will be fine for now – we will not use Round, Ceiling, or Floor. (we do recognize that there may still be some false positives due to this) 3. We would like to output 2 files - DebugMeta.txt & DebugMeta_truncate.txt (see code below with potential changes to public static class BaselineMetaFile for a starting point – note it was decided to keep the old file as-is and make the new file truncate --- instead of using full as in the code below) 4. There will need to be a small change to the UI in the baseline program --- a checkbox for use of truncate decimals when comparing. If not checked, will behave as does currently. If button is checked, will use DebugMeta_truncate.txt if it exists (instead of DebugMeta.txt). If DebugMeta_truncate.txt does not exist, it will use DebugMeta.txt Let’s also have the box checked by Default.
plarsen added 1 commit 2026-08-24 10:48:13 -04:00
jjenko requested changes 2026-08-24 11:49:25 -04:00
Dismissed
jjenko left a comment
Owner

see my comments in DebugPrint.cs

see my comments in DebugPrint.cs
@@ -1,7 +1,10 @@
using DevComponents.DotNetBar;
using Org.BouncyCastle.Utilities;
Owner

Looks like Visual Studio was trying to be "helpful". I don't think BouncyCastle is needed.

Looks like Visual Studio was trying to be "helpful". I don't think BouncyCastle is needed.
mschill marked this conversation as resolved
@@ -2,3 +4,3 @@
using System.Collections.Generic;
using System.Text;
using System.IO;
using System.Net.NetworkInformation;
Owner

is System.Net.NetworkInformation needed?

is System.Net.NetworkInformation needed?
Owner

Agreed should be removing unnecessary usings.

Agreed should be removing unnecessary usings.
Owner

What is DevComponents.DotNetBar needed for?

What is DevComponents.DotNetBar needed for?
Owner

This was removed but it looks like another unneeded using was added. This is still an open item as of 8/26

This was removed but it looks like another unneeded using was added. This is still an open item as of 8/26
Author
Owner

Which using are you referring to?

Which using are you referring to?
Owner

From the above - it looks like you added:
using System.Windows.Forms;
to
[PROMS/Volian.Base.Library/DebugPrint.cs]

that being said, in VIsual Studio, should be clicking on the side item and selecting remove unnecessary usings. I will forward the emails related to this / the Technical Debt cleanup

From the above - it looks like you added: using System.Windows.Forms; to [PROMS/Volian.Base.Library/DebugPrint.cs] that being said, in VIsual Studio, should be clicking on the side item and selecting remove unnecessary usings. I will forward the emails related to this / the Technical Debt cleanup
mschill marked this conversation as resolved
mschill requested changes 2026-08-24 12:00:26 -04:00
Dismissed
mschill left a comment
Owner

See notes.

1 performance item
1 cleanup unnecessary usings
1 change to finding debug file.

See notes. 1 performance item 1 cleanup unnecessary usings 1 change to finding debug file.
@@ -724,1 +713,3 @@
FindFiles fnd = new FindFiles(cbFile1.Text, cbFile2.Text, "DebugMeta.txt",MyIgnore);
if (cbUseTruncatedData.Checked)
{
fnd = new FindFiles(cbFile1.Text, cbFile2.Text, "DebugMeta_Truncate.txt", MyIgnore);
Owner

Not sure this works as intended. If not checked is fine but if checked should use "DebugMeta_Truncate.txt" if found - if not found should use "DebugMeta.txt"

Not sure this works as intended. If not checked is fine but if checked should use "DebugMeta_Truncate.txt" if found - if not found should use "DebugMeta.txt"
Owner

May need further changes --- what if (for example):

cbFile1.Text was ran the old way so it only has a DebugMeta.txt
but cbFile2.Text has a "DebugMeta_Truncate.txt"?

May need further changes --- what if (for example): cbFile1.Text was ran the old way so it only has a DebugMeta.txt but cbFile2.Text has a "DebugMeta_Truncate.txt"?
Owner

This is still an open item as of 8/26

This is still an open item as of 8/26
mschill marked this conversation as resolved
@@ -159,2 +194,2 @@
public static void Show()
{ _MyDebugPrint.Show(); }
{
if(args.Length > 8)
Owner

There could be additional args added so, would not go by this ---- My recommendation as below is 3 WriteLine functions. If have to use additional arguments would use boolean not strings and named arguments.

There could be additional args added so, would not go by this ---- My recommendation as below is 3 WriteLine functions. If have to use additional arguments would use boolean not strings and named arguments.
Owner

This is still an open item as of 8/26

This is still an open item as of 8/26
Author
Owner

My concern is to know which argument will tell PROMS that there is a truncated version being saved. So I chose that it will be the last one in any arg list. I chose a name arg instead of a Boolean because it is possible that another writeline statement to DebugMeta.txt may have a boolean as the last arg which will be a mistake. I could change the flag to a single letter which might simplify things.

My concern is to know which argument will tell PROMS that there is a truncated version being saved. So I chose that it will be the last one in any arg list. I chose a name arg instead of a Boolean because it is possible that another writeline statement to DebugMeta.txt may have a boolean as the last arg which will be a mistake. I could change the flag to a single letter which might simplify things.
Owner

My recommendation is still:

              I would recommend that there be 3 WriteLine functions and not use an argument for it -
              
              A regular WriteLine that writes to both files.
              A WriteLineTruncated that writes to Only the Truncated file
              A WriteLineFullOnly that write to only the full file

when truncated text is the same would call WriteLine
when would have different would call both WriteLineTruncated & WriteLineFullOnly - each with their respected text.

Write should not be needed - it does not appear to be called in PROMS and thus should be removed / would be as part of tech debt clean-up.

If it needs to be an argument, it should be a boolean -- that being said as mentioned above better to do the 3 separate functions.
public static void WriteLine(string format, params object[] args) //writes both
public static void WriteLine_Individual(string format, params object[] args, bool isTruncated)

My recommendation is still: I would recommend that there be 3 WriteLine functions and not use an argument for it - A regular WriteLine that writes to both files. A WriteLineTruncated that writes to Only the Truncated file A WriteLineFullOnly that write to only the full file when truncated text is the same would call WriteLine when would have different would call both WriteLineTruncated & WriteLineFullOnly - each with their respected text. Write should not be needed - it does not appear to be called in PROMS and thus should be removed / would be as part of tech debt clean-up. If it needs to be an argument, it should be a boolean -- that being said as mentioned above better to do the 3 separate functions. public static void WriteLine(string format, params object[] args) //writes both public static void WriteLine_Individual(string format, params object[] args, bool isTruncated)
mschill marked this conversation as resolved
@@ -1422,0 +1421,4 @@
Volian.Base.Library.BaselineMetaFile.WriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, locEndOfWordDoc, pdfSize, (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber, "truncate_false");
Volian.Base.Library.BaselineMetaFile.TruncateWriteLine("WD Height={0} Width={1} scPgCnt={2} locEnd={3} pdfSz={4} xOff={5} yOff={6} ScPgNum {7}", fgPage.Height, fgPage.Width, sectPageCount, Truncate(locEndOfWordDoc, 2), Truncate(pdfSize, 2), (float)(mySection.MyDocStyle.Layout.MSWordXAdj ?? 0.0), (float)(mySection.MyDocStyle.Layout.MSWordYAdj ?? 0.0) + yoff, pageNumber, "truncate_true");
Owner

For performance concerns. I would not recommend having additional paramaters with a string based option like "truncate_true" for example.

I would recommend that there be 3 WriteLine functions -

  1. A regular WriteLine that writes to both files.
  2. A WriteLineTruncated that writes to Only the Truncated file
  3. A WriteLineFullOnly that write to only the full file
For performance concerns. I would not recommend having additional paramaters with a string based option like "truncate_true" for example. I would recommend that there be 3 WriteLine functions - 1. A regular WriteLine that writes to both files. 2. A WriteLineTruncated that writes to Only the Truncated file 3. A WriteLineFullOnly that write to only the full file
Owner

This is still an open item as of 8/26. Also, it looks like you made changes to the Write function - but it is not used in PROMS - only WriteLine is.

This is still an open item as of 8/26. Also, it looks like you made changes to the Write function - but it is not used in PROMS - only WriteLine is.
mschill marked this conversation as resolved
plarsen added 1 commit 2026-08-24 13:43:22 -04:00
mschill requested changes 2026-08-24 14:01:41 -04:00
Dismissed
mschill left a comment
Owner

See notes.

1 performance item
1 cleanup unnecessary usings
1 change to finding debug file.

See notes. 1 performance item 1 cleanup unnecessary usings 1 change to finding debug file.
mschill requested changes 2026-08-24 14:02:04 -04:00
Dismissed
mschill left a comment
Owner

See notes.

1 performance item
1 cleanup unnecessary usings
1 change to finding debug file.

See notes. 1 performance item 1 cleanup unnecessary usings 1 change to finding debug file.
plarsen added 1 commit 2026-08-26 10:11:45 -04:00
plarsen changed title from C2026 041 invisible position changes as differences to C2026-050 invisible position changes as differences 2026-08-26 10:48:25 -04:00
plarsen changed title from C2026-050 invisible position changes as differences to C2026-050 Modify the baseline compare program so that it only uses two digits 2026-08-26 10:52:27 -04:00
plarsen changed title from C2026-050 Modify the baseline compare program so that it only uses two digits to C2026-041-invisible-position-changes-as-differences 2026-08-26 11:51:45 -04:00
plarsen added 3 commits 2026-09-02 08:00:40 -04:00
mschill requested changes 2026-09-02 08:41:57 -04:00
Dismissed
mschill left a comment
Owner

see notes I will follow up with Devin and John and send an email.

see notes I will follow up with Devin and John and send an email.
@@ -264,3 +278,3 @@
this.lbProcedures.Location = new System.Drawing.Point(0, 0);
this.lbProcedures.Name = "lbProcedures";
this.lbProcedures.Size = new System.Drawing.Size(707, 25);
this.lbProcedures.Size = new System.Drawing.Size(150, 46);
Owner

was changing the size of this intentional?

was changing the size of this intentional?
mschill marked this conversation as resolved
@@ -879,2 +851,2 @@
/// <param name="myIgnore">Ignore list</param>
public FindFiles(string path1, string path2, string fileName,IgnoreLines myIgnore)
private readonly string _FileName;
private object _fileName;
Owner

This should not have been added / I believe this is not used.

This should not have been added / I believe this is not used.
mschill marked this conversation as resolved
@@ -155,2 +160,3 @@
}
public static void Write(string format, params object[] args)
{ _MyDebugPrint.Write(format, args); }
{
Owner

Write should be removed - it is not called from anywhere.

Write should be removed - it is not called from anywhere.
mschill marked this conversation as resolved
mschill requested changes 2026-09-02 08:56:50 -04:00
Dismissed
@@ -56,2 +47,3 @@
using System.Xml;
using System.Linq;
using System.Runtime.InteropServices;
using System.Runtime.InteropServices.ComTypes;
Owner

Is this using used?

Is this using used?
mschill marked this conversation as resolved
mschill requested changes 2026-09-02 09:21:10 -04:00
Dismissed
mschill left a comment
Owner

It looks like this still assumes that either both files are truncated or neither is.

It looks like this still assumes that either both files are truncated or neither is.
@@ -994,0 +980,4 @@
{
if (!foundFileFg) // flag to indicate if the correct DebugMeta file has been found.
{
fileName = getDebubMetaFile(di1, di2, ref foundFileFg); // C2026-041 Check if the DebugMeta_Truncate.txt file is found in the baseline bench mark and the new release being tested.
Owner

It looks like this still assumes that either both files are truncated or neither is.

It looks like this still assumes that either both files are truncated or neither is.
mschill marked this conversation as resolved
plarsen added 1 commit 2026-09-02 14:44:17 -04:00
mschill requested changes 2026-09-02 14:54:34 -04:00
Dismissed
mschill left a comment
Owner

Looks like only remaining needed changes are in frmBaseline.cs and are all related to added unused code and commented out unused code that needs cleaned up.

Looks like only remaining needed changes are in frmBaseline.cs and are all related to added unused code and commented out unused code that needs cleaned up.
@@ -211,0 +209,4 @@
TruncatedDataFg = item.Checked;
}
//}
Owner

not sure why this commented line was added - commented out code should be removed.

not sure why this commented line was added - commented out code should be removed.
Author
Owner

I cleaned this up

I cleaned this up
mschill marked this conversation as resolved
@@ -992,2 +973,3 @@
private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore)
private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore, bool isTruncatedChecked = false, bool foundFileFg = false)
{
//if (isTruncatedChecked) // C2026-041 is the "Use Truncated Data" checked
Owner

Commented out code should be removed

Commented out code should be removed
Author
Owner

I cleaned this up

I cleaned this up
mschill marked this conversation as resolved
@@ -998,2 +987,3 @@
FillByCompare(diChild1, diChild2, fileName,myIgnore);// Recursively work on Sub-Folders
FillByCompare(diChild1, diChild2, fileName,myIgnore, isTruncatedChecked, foundFileFg);// Recursively work on Sub-Folders
}
//foreach (FileInfo fiChild1 in di1.GetFiles(fileName))
Owner

Commented out code should be removed

Commented out code should be removed
mschill marked this conversation as resolved
@@ -1007,3 +1027,4 @@
}
}
}
private string getDebubMetaFile(DirectoryInfo di1, DirectoryInfo di2, ref bool foundFileFg) // C2026-041
Owner

This function is not called so should be removed.

This function is not called so should be removed.
Author
Owner

I removed it

I removed it
mschill marked this conversation as resolved
mschill requested changes 2026-09-02 15:02:28 -04:00
Dismissed
mschill left a comment
Owner

Sorry noticed one additional thing --- TruncatedDataFg was added as a global variable and set but is never used as this is passed to functions and used locally --- as such, shouldn't also be a global variable / be in memory and not used.

Sorry noticed one additional thing --- TruncatedDataFg was added as a global variable and set but is never used as this is passed to functions and used locally --- as such, shouldn't also be a global variable / be in memory and not used.
@@ -82,2 +73,4 @@
public IgnoreLines MyIgnore { get; set; } = new IgnoreLines();
private LastWas myLast = LastWas.Search;
private Settings MySettings;
public bool TruncatedDataFg { get; set; } = false;
Owner

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?
Author
Owner

I cleaned this up

I cleaned this up
Owner

This is still commented out code - commented out code should be removed.

This is still commented out code - commented out code should be removed.
mschill marked this conversation as resolved
mschill requested changes 2026-09-02 15:05:58 -04:00
Dismissed
mschill left a comment
Owner

private void cbUseTruncatedData_Click(object sender, EventArgs e)

seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.

private void cbUseTruncatedData_Click(object sender, EventArgs e) seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.
@@ -208,6 +203,13 @@ namespace Baseline
MyIgnore = IgnoreLines.Get(saveOriginal);
}
}
private void cbUseTruncatedData_Click(object sender, EventArgs e)
Owner

This seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.

This seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.
Author
Owner

I removed the function

I removed the function
mschill marked this conversation as resolved
plarsen added 1 commit 2026-09-02 15:44:58 -04:00
mschill requested changes 2026-09-02 16:04:27 -04:00
Dismissed
mschill left a comment
Owner

Looks like there is still some commented out code and there was an added parameter that is unused.

Looks like there is still some commented out code and there was an added parameter that is unused.
@@ -990,3 +964,3 @@
return false;
}
private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore)
private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore, bool isTruncatedChecked = false, bool foundFileFg = false)
Owner

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.
Author
Owner

I removed foundFileFg

I removed foundFileFg
mschill marked this conversation as resolved
@@ -997,2 +970,3 @@
DirectoryInfo diChild2 = new DirectoryInfo(Path.Combine(di2.FullName, diChild1.Name));
if (diChild2.Exists)
FillByCompare(diChild1, diChild2, fileName,myIgnore);// Recursively work on Sub-Folders
FillByCompare(diChild1, diChild2, fileName,myIgnore, isTruncatedChecked, foundFileFg);// Recursively work on Sub-Folders
Owner

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.
Author
Owner

I removed foundFileFg

I removed foundFileFg
plarsen added 1 commit 2026-09-02 16:24:25 -04:00
mschill approved these changes 2026-09-03 06:16:46 -04:00
mschill left a comment
Owner

Looks Good. Ready for QA.

Looks Good. Ready for QA.
jjenko approved these changes 2026-09-03 08:55:42 -04:00
jjenko left a comment
Owner

changes look good.

changes look good.
jjenko merged commit e16b3262d9 into Development 2026-09-03 08:56:33 -04:00
Sign in to join this conversation.
No Reviewers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#807