Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

B2026-022-Adding-RO-Editor-symbols-to-RO-Tables #738

Merged
jjenko merged 5 commits from B2026-022-Adding-RO-Editor-symbols-to-RO-Tables into Development 2026-03-17 16:09:56 -04:00
Conversation 4 Commits 5 Files Changed 3 +13 -1
plarsen commented 2026-03-16 23:22:10 -04:00
Owner
Copy Link

B2026-022-Adding-RO-Editor-symbols-to-RO-Tables.

B2026-022-Adding-RO-Editor-symbols-to-RO-Tables.
B2026-022-Adding-RO-Editor-symbols-to-RO-Tables.docx
187 KiB
plarsen self-assigned this 2026-03-16 23:22:11 -04:00
djankowski was assigned by plarsen 2026-03-16 23:22:11 -04:00
jjenko was assigned by plarsen 2026-03-16 23:22:11 -04:00
mvickers was assigned by plarsen 2026-03-16 23:22:11 -04:00
plarsen added 3 commits 2026-03-16 23:22:12 -04:00
B2026-022-Adding-RO-Editor-symbols-to-RO-Tables 7636fe7686
B2026-022-Adding-RO-Editor-symbols-to-RO-Tables e9ad57f588
B2026-022-Adding-RO-Editor-symbols-to-RO-Tables ed615dbb31
plarsen requested review from jjenko 2026-03-16 23:22:56 -04:00
mschill requested changes 2026-03-17 07:52:51 -04:00
mschill left a comment
Owner
Copy Link

See notes - let me know if you have any questions.
Also, this branch needs updated as it is out of date with dev. --- can click the "Update Branch by Merge" button below but then be sure to pull those changes down to your local repo.

See notes - let me know if you have any questions. Also, this branch needs updated as it is out of date with dev. --- can click the "Update Branch by Merge" button below but then be sure to pull those changes down to your local repo.
PROMS/ReferencedObjects/LibSource/RODBInterface/RODBInterface.cs
@@ -2147,6 +2147,7 @@ namespace RODBInterface
foreach (int chr in chrAry)
{
if (chr > 166)
mschill commented 2026-03-17 07:52:07 -04:00
Owner
Copy Link

Should there be a blank line inserted here?

Should there be a blank line inserted here?
plarsen commented 2026-03-17 15:36:38 -04:00
Author
Owner
Copy Link

I removed the blank line

I removed the blank line
mschill marked this conversation as resolved
PROMS/ReferencedObjects/LibSource/RODBInterface/RODBInterface.cs
@@ -2204,6 +2205,7 @@ namespace RODBInterface
foreach (int chr in chrAry)
{
if (chr > 166)
mschill commented 2026-03-17 07:52:17 -04:00
Owner
Copy Link

Should there be a blank line inserted here?

Should there be a blank line inserted here?
plarsen commented 2026-03-17 15:34:54 -04:00
Author
Owner
Copy Link

I removed the blank line

I removed the blank line
mschill marked this conversation as resolved
PROMS/Volian.Controls.Library/VlnFlexGrid.cs Outdated
@@ -2476,0 +2479,4 @@
foreach (Match match in Regex.Matches(rtn, pattern, RegexOptions.IgnoreCase))
{
mValue = match.Value;
mValue2 = @"\f1 " + mValue + @"\f0";
mschill commented 2026-03-17 07:49:32 -04:00
Owner
Copy Link

Performance - Would avoid adding together strings - would suggest string interpolation.

mValue2 = $"\f1 {mValue}\f0";

note that this viewer changes the double slashes to single ones (unless you click edit on the comment - so see screenshot below)

Performance - Would avoid adding together strings - would suggest string interpolation. mValue2 = $"\\f1 {mValue}\\f0"; note that this viewer changes the double slashes to single ones (unless you click edit on the comment - so see screenshot below)
double_slash.jpg
17 KiB
double_slash.jpg
plarsen commented 2026-03-17 15:35:27 -04:00
Author
Owner
Copy Link

I made the change.

I made the change.
mschill marked this conversation as resolved
PROMS/Volian.Controls.Library/VlnFlexGrid.cs
@@ -2476,0 +2481,4 @@
mValue = match.Value;
mValue2 = @"\f1 " + mValue + @"\f0";
rtn = rtn.Replace(match.Value, mValue2);
// @"\f1\u9474 ?\f0")
mschill commented 2026-03-17 07:48:12 -04:00
Owner
Copy Link

Commented out code should be removed or have text designating why it is not?

Commented out code should be removed or have text designating why it is not?
mschill marked this conversation as resolved
PROMS/Volian.Controls.Library/VlnFlexGrid.cs Outdated
@@ -3827,6 +3840,9 @@ namespace Volian.Controls.Library
this.MergedRanges.Clear();
this.Clear();
this.IsRoTable = true;
//valtext = valtext.Replace(@"\u8209?", "-");
mschill commented 2026-03-17 07:49:53 -04:00
Owner
Copy Link

Commented out code should be removed or have text designating why it is not?

Commented out code should be removed or have text designating why it is not?
plarsen commented 2026-03-17 15:36:01 -04:00
Author
Owner
Copy Link

I remove the comment

I remove the comment
mschill marked this conversation as resolved
plarsen added 1 commit 2026-03-17 08:37:31 -04:00
Merge branch 'Development' into B2026-022-Adding-RO-Editor-symbols-to-RO-Tables fd59b9d5f0
jjenko requested changes 2026-03-17 09:11:28 -04:00
Dismissed
jjenko left a comment
Owner
Copy Link

Please clean up per Matt's comments

Please clean up per Matt's comments
plarsen added 1 commit 2026-03-17 15:29:00 -04:00
B2026-022-Adding-RO-Editor-symbols-to-RO-Tables 4b479b3ceb
mschill requested review from jjenko 2026-03-17 16:05:56 -04:00
mschill requested review from mschill 2026-03-17 16:05:59 -04:00
jjenko approved these changes 2026-03-17 16:09:18 -04:00
jjenko left a comment
Owner
Copy Link

changes look good

changes look good
jjenko merged commit c3cacaf407 into Development 2026-03-17 16:09:56 -04:00
mvickers commented 2026-03-20 10:10:37 -04:00
Member
Copy Link

Tested with Version 2.3.2603.1716. Note that only the RO table portion was corrected under this CSM item even though the x/y plot problem was also reported on the same CSM item. The X/Y portion will be fixed under B2026-023 which was for the Find Doc Ro not working properly. The RO Tables are working as expected. I updated the testing document and it is attached. MV

Tested with Version 2.3.2603.1716. Note that only the RO table portion was corrected under this CSM item even though the x/y plot problem was also reported on the same CSM item. The X/Y portion will be fixed under B2026-023 which was for the Find Doc Ro not working properly. The RO Tables are working as expected. I updated the testing document and it is attached. MV
B2026-022-Adding-RO-Editor-symbols-to-RO-Tables_updated MRV Mar 18 2026.docx
100 KiB
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
jjenko
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees plarsen djankowski jjenko mvickers
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#738
Delete Branch "B2026-022-Adding-RO-Editor-symbols-to-RO-Tables"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?