Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

C2024-003-Print-Sub-Section #241

Merged
jjenko merged 11 commits from C2024-003 into Development 2024-02-28 10:46:06 -05:00
Conversation 7 Commits 11 Files Changed 8 +1079 -967
plarsen commented 2024-02-23 09:31:25 -05:00
Owner
Copy Link

Added the ability to print Sub Sections individually.

Added the ability to print Sub Sections individually.
C2024-003 PROMS Print Sub Sections.docx
66 KiB
Sub Section Screenshot.png
48 KiB
Sub Section Screenshot.png
plarsen self-assigned this 2024-02-23 09:31:25 -05:00
jjenko was assigned by plarsen 2024-02-23 09:31:25 -05:00
plarsen added 1 commit 2024-02-23 09:31:25 -05:00
plarsen requested review from jjenko 2024-02-23 09:31:41 -05:00
jjenko requested changes 2024-02-23 12:41:14 -05:00
jjenko left a comment
Owner
Copy Link

VEPROSM User Interface
DlgPrintProcedure.cs
line 62, need comment, with CSM item number, explaining change

	line 430-432, the comment got shifted over to the right
	- also lines 533-535, 568, 727-728, 776, 962-964

frmPDFStatusForm.cs
	Line 94, need comment, with CSM item number, explaining change

frmVEPROMS.cs
	Line 1200, need comment, with CSM item number, explaining change

Volian.Controls.library
vlnTreeView.cs
Line 2806, the comment got shifted over to the right
Also line 2835, 2882

Volian.Print.Library
PromsPrinter.cs
line 182, need comment, with CSM item number, explaining change
Also line 362, 364, 380, 816, 836, 839, 849, 986, 1639, 3022

VlnPageHelper.cs
	line 88, need comment, with CSM item number, explaining change

	Lines 265-266, the comment got shifted over to the right
	- Also lines 1372-1373

vlnParagraph.cs

*** in general - after review this file I didn't see any changes need for for this update.
*** Please verify and if no changes were made (for this update) please resore your local file and remove this from the update
*** Otherwise, below is list of areas that need resovoled - especially the Unicode charater issue.
*** The characters that got switched to Unicode should be plain ascii characters
*** Is there a setting in Visual Studio that is not correct?

	Line 1 - remove unicode character [U+FEFF]

	Line 271 - the comment got shifted over to the right
	Also Lines 422-424, 768-769, 962, 977, 1125-1130, 1211, 1457-1459, 1503-1506, 2084-2085

	Line 2838 - remove unicode character [U+0095]  (was a bullet character to a astrisk *)

	Line 2841 - remove unicode characters [U+0095]  (was a bullet character to a astrisk *)
	Line 2842- remove unicode characters [U+0093] & [U+0094]  (were a double quotes)
	Line 2843- remove unicode characters [U+0093] & [U+0094]  (were a double quotes)
	Line 2844 - remove unicode character [U+0095]  (was a bullet character to a astrisk *)

	Line 2973-2975 - the comment got shifted over to the right
	Also Lines3036-3040, 3058, 4002-4005, 4081
	
	Line 4496- remove unicode character [U+0092]  (was a single quote character)

	Line 4874 - the comment got shifted over to the right

	Line 5378 - the comment got shifted over to the right

	Lines 5805 - 5817 check formatting of comment

	Line 6254-6256 - the comment got shifted over to the right
VEPROSM User Interface DlgPrintProcedure.cs line 62, need comment, with CSM item number, explaining change line 430-432, the comment got shifted over to the right - also lines 533-535, 568, 727-728, 776, 962-964 frmPDFStatusForm.cs Line 94, need comment, with CSM item number, explaining change frmVEPROMS.cs Line 1200, need comment, with CSM item number, explaining change Volian.Controls.library vlnTreeView.cs Line 2806, the comment got shifted over to the right Also line 2835, 2882 Volian.Print.Library PromsPrinter.cs line 182, need comment, with CSM item number, explaining change Also line 362, 364, 380, 816, 836, 839, 849, 986, 1639, 3022 VlnPageHelper.cs line 88, need comment, with CSM item number, explaining change Lines 265-266, the comment got shifted over to the right - Also lines 1372-1373 vlnParagraph.cs *** in general - after review this file I didn't see any changes need for for this update. *** Please verify and if no changes were made (for this update) please resore your local file and remove this from the update *** Otherwise, below is list of areas that need resovoled - especially the Unicode charater issue. *** The characters that got switched to Unicode should be plain ascii characters *** Is there a setting in Visual Studio that is not correct? Line 1 - remove unicode character [U+FEFF] Line 271 - the comment got shifted over to the right Also Lines 422-424, 768-769, 962, 977, 1125-1130, 1211, 1457-1459, 1503-1506, 2084-2085 Line 2838 - remove unicode character [U+0095] (was a bullet character to a astrisk *) Line 2841 - remove unicode characters [U+0095] (was a bullet character to a astrisk *) Line 2842- remove unicode characters [U+0093] & [U+0094] (were a double quotes) Line 2843- remove unicode characters [U+0093] & [U+0094] (were a double quotes) Line 2844 - remove unicode character [U+0095] (was a bullet character to a astrisk *) Line 2973-2975 - the comment got shifted over to the right Also Lines3036-3040, 3058, 4002-4005, 4081 Line 4496- remove unicode character [U+0092] (was a single quote character) Line 4874 - the comment got shifted over to the right Line 5378 - the comment got shifted over to the right Lines 5805 - 5817 check formatting of comment Line 6254-6256 - the comment got shifted over to the right
C2024-003 - sub-section Print code review.docx
280 KiB
plarsen added 2 commits 2024-02-26 10:03:45 -05:00
jjenko requested changes 2024-02-26 10:54:33 -05:00
jjenko left a comment
Owner
Copy Link

still issues with VlnParagraph.cs

some comments shifted to the right - not lined up as before

Still some Unicode Characters in the file

still issues with VlnParagraph.cs some comments shifted to the right - not lined up as before Still some Unicode Characters in the file
plarsen added 1 commit 2024-02-26 12:47:27 -05:00
jjenko requested changes 2024-02-26 14:34:53 -05:00
jjenko left a comment
Owner
Copy Link

Still Unicode and formatting issues with VlnParagraph.cs

Still Unicode and formatting issues with VlnParagraph.cs
plarsen added 2 commits 2024-02-26 16:08:16 -05:00 
This reverts commit 82fa4f1e74882ba3024656ea735087d8dc0f7c79.
plarsen added 1 commit 2024-02-26 22:59:03 -05:00
jjenko requested changes 2024-02-27 08:42:09 -05:00
jjenko left a comment
Owner
Copy Link

VlnTreeView would wipe out previous out of memory fix from Git #237

Please merger with current code

VlnTreeView would wipe out previous out of memory fix from Git #237 Please merger with current code
plarsen added 2 commits 2024-02-27 10:46:06 -05:00
cglavan commented 2024-02-27 11:38:02 -05:00
Contributor
Copy Link

Instructed Paul to manually change the code for vlnTreeView.cs to add the changes made in Git #237 and re-commit his code.

NOTE
After discussing with Paul and reviewing his Git procedure I had him merge the existing remote Development branch into his local branch before committing his local branch. When opening VS to review the code it was found that the changes to vlnTreeView.cs were not taking effect on his local machine. After troubleshooting potential issues I had him commit his branch and then reviewed the Pull Request that he created. The PR indicated that the #237 we still going to be overridden. Since this file appears to be the only one that would be affected, having him manually add the changes and committing again would be the simplest solution rather than reverting the entire branch and having him redo all of his code changes again.

@jjenko and @kruffing should review any files included in this PR to determine if changes that they made previously are going to be affected by merging this PR into the remote Development branch.

Instructed Paul to manually change the code for vlnTreeView.cs to add the changes made in Git #237 and re-commit his code. **NOTE** After discussing with Paul and reviewing his Git procedure I had him merge the existing remote Development branch into his local branch before committing his local branch. When opening VS to review the code it was found that the changes to vlnTreeView.cs were not taking effect on his local machine. After troubleshooting potential issues I had him commit his branch and then reviewed the Pull Request that he created. The PR indicated that the #237 we still going to be overridden. Since this file appears to be the only one that would be affected, having him manually add the changes and committing again would be the simplest solution rather than reverting the entire branch and having him redo all of his code changes again. @jjenko and @kruffing should review any files included in this PR to determine if changes that they made previously are going to be affected by merging this PR into the remote Development branch.
plarsen added 1 commit 2024-02-27 12:01:30 -05:00
plarsen added 1 commit 2024-02-28 09:15:39 -05:00
jjenko approved these changes 2024-02-28 10:45:38 -05:00
jjenko left a comment
Owner
Copy Link

Approving this but please note that changes in these file included some kind of automatic reformatting of some of the code and comments. There really are no changes to pagination.cs, but the compare showed the reformatting of code and comments. We will need to fix these as we go on from here.

Approving this but please note that changes in these file included some kind of automatic reformatting of some of the code and comments. There really are no changes to pagination.cs, but the compare showed the reformatting of code and comments. We will need to fix these as we go on from here.
jjenko merged commit 8fa08b09fa into Development 2024-02-28 10:46:06 -05:00
mvickers commented 2024-02-28 11:41:24 -05:00
Member
Copy Link

Tested using version 2.1.2402.2810 following the testing requirements and various testing with the additional settings page. No issues were found.

Tested using version 2.1.2402.2810 following the testing requirements and various testing with the additional settings page. No issues were found.
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees plarsen jjenko
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#241
No description provided.
Delete Branch "C2024-003"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?