Development #153

djankowski · 2023-11-09T09:28:41-05:00

djankowski commented

2023-11-09 09:28:41 -05:00

Merging F2023-140, F2023-123, B2023-007, B2023-108, F2023-139, F2023-138 and B2023-103

djankowski added 15 commits 2023-11-09 09:28:42 -05:00

B2023-103: Improve User Interface for Incoming Transitions a5ca7187c7

F2023-138 For all of the used Barakah formats, set the color of the ECI footer text to Red and changed the font size to 12pt and font style to Bold 8233f15315

F2023-138 continuation - missed a spot in the Alarm format 30330c175e

F2023-139 Replaced hardcoded “Step Description Table” the section title and removed the section number that was preceding the step numbers in the background document 7834cf634f

Merge branch 'GenWork' of https://git.volian.com/Volian/SourceCode into GenWork ac49c3f297

B2023-108: Crash during import of procedure set 128b5d81cc

Merge pull request 'GenWork' (#148 ) from GenWork into Development e1249dccee

code change looks good.  formats listed are OK too.  The format files should not have been in this check-in, but I verified that last changes to these BNPP formats are still there.

B2023-007 The Dashed Explicit AND sub-step type was not putting a blank line before printing the “AND” separator text. Needed to add EveryNLines=”1” to the sub-step definition. c5381df38a

Merge pull request 'B2023-007 The Dashed Explicit AND sub-step type was not putting a blank line before printing the “AND” separator text. Needed to add EveryNLines=”1” to the sub-step definition.' (#149 ) from B2023-007_dashed_expl_AND into Development 911a86dbf1

format only change. No code review required.

Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Word section (with the arrow icon instead of a plus icon). When printed or approved, PROMS tries to process it as Word section but some information in that database record is null. PROMS will now handle these pieces of information that is null and record the issue in the error log and not try to convert it to a Docx, allowing to continue printing or approving. 7b4b6323bf

~Added format flag NoBlankLastNoteCautionWarn to the PrintData node to address line spacing at the bottom border 2c93444385

~Added format flag SpaceIn to address the spacing between the word Note or Caution
~Adjusted TxtWidth value to fix text spacing issue where text was being cut off at the right side

Merge pull request 'F2023-123' (#151 ) from F2023-123 into Development 1d52c9f469

Merging into development.  No code review needed due to format change.

Merge pull request 'Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Wo…' (#150 ) from B2023-109_NULL_Reference_Approve into Development 602682b88d

Merging into Development after successful Code review

Merged format changes made by Barakah into the official PROMS version of the formats. 0e9d6ac391

Merge pull request 'Merged format changes made by Barakah into the official PROMS version of the formats.' (#152 ) from F2023-140_BNPP_Formats_Merge into Development ca665d9fc8

format only changes

djankowski merged commit 355537f2ab into master

2023-11-09 10:33:40 -05:00

djankowski referenced this issue from a commit

2023-11-09 10:33:41 -05:00

Merge pull request 'Development' (#153) from Development into master

cglavan was assigned by djankowski

2023-11-09 10:33:47 -05:00

jjenko was assigned by djankowski

2023-11-09 10:33:47 -05:00

kruffing was assigned by djankowski

2023-11-09 10:33:47 -05:00

mvickers was assigned by djankowski

2023-11-09 10:33:48 -05:00

lbutler was assigned by djankowski

2023-11-09 10:33:48 -05:00

plarsen was assigned by djankowski

2023-11-09 10:33:48 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Volian/SourceCode#153