Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Wo… #150

2023-11-03T09:58:55-04:00

jjenko commented

2023-11-03 09:58:55 -04:00

B2023-109
Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Word section (with the arrow icon instead of a plus icon). When printed or approved, PROMS tries to process it as Word section but some information in that database record is null. PROMS will now handle these pieces of information that is null and record the issue in the error log and not try to convert it to a Docx, allowing to continue printing or approving.

B2023-109 Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Word section (with the arrow icon instead of a plus icon). When printed or approved, PROMS tries to process it as Word section but some information in that database record is null. PROMS will now handle these pieces of information that is null and record the issue in the error log and not try to convert it to a Docx, allowing to continue printing or approving.

B2023-109.docx

15 KiB

jjenko added 1 commit 2023-11-03 09:58:55 -04:00

Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Word section (with the arrow icon instead of a plus icon). When printed or approved, PROMS tries to process it as Word section but some information in that database record is null. PROMS will now handle these pieces of information that is null and record the issue in the error log and not try to convert it to a Docx, allowing to continue printing or approving. 7b4b6323bf

jjenko requested review from cglavan 2023-11-03 09:59:03 -04:00

cglavan approved these changes 2023-11-06 10:43:16 -05:00

cglavan left a comment

Code review completed successfully.

cglavan merged commit 602682b88d into Development

2023-11-06 10:44:58 -05:00

cglavan referenced this issue from a commit

2023-11-06 10:44:59 -05:00

Merge pull request 'Added better logic to catch null references when PROMS tries to convert an older Word section to use the Docx file format. The real issue was bad data where the tree view looks like it’s a step editor section, but the PROMS editor depicts it as a Wo…' (#150) from B2023-109_NULL_Reference_Approve into Development

mvickers was assigned by cglavan

2023-11-06 10:45:11 -05:00

djankowski was assigned by cglavan

2023-11-06 10:45:33 -05:00

mvickers was unassigned by cglavan

2023-11-06 10:45:33 -05:00

mvickers was assigned by djankowski

2023-11-06 11:00:30 -05:00

mvickers commented

2023-11-09 09:02:14 -05:00

Verified that the procedure did not crash when printed. No issues found.

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Volian/SourceCode#150