commented out code should be removed or reason given for why it is commented out / should be in the code long term.
Shouldn't need this as foreach loop below should loop 0 times if no rows.
if commented out, should be removed or reason given why commented out?
I would add them as 1 combined index as I don't think you would ever be providing one without the other ----- also, what should the included columns be for the index?
Should there be a…
not sure if this would help --- but just a thought - passing in a whole table of the annotationtypeselections instead of doing 1 update/insert at a time and then doing a merge with the current…
sounds good. Just wanted to double check since this existed before your changes that removing it wasn't going to impact something else.
was this (ProcItem = CurrentItem.MyProcedure;) intended to be removed?
UsrID is the id of the PROMS user. Userid is the user id that created the annotation type.
can we either --- use something else like CreatedBy or add a comment in the SQL.
I would add them as 1 combined index as I don't think you would ever be providing one without the other ----- also, what should the included columns be for the index?