Volian/SourceCode
8
0 Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C2026-041-invisible-position-changes-as-differences #807

Merged
jjenko merged 14 commits from C2026-041-invisible-position-changes-as-differences into Development 2026-09-03 08:56:33 -04:00
Conversation 16 Commits 14 Files Changed 9
+3 -4
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit edc5bc611b - Show all commits
PROMS/Baseline/frmBaseline.cs
+3 -4
View File
1
 @@ -73,7 +73,6 @@ namespace Baseline
public IgnoreLines MyIgnore { get; set; } = new IgnoreLines(); public IgnoreLines MyIgnore { get; set; } = new IgnoreLines();
private LastWas myLast = LastWas.Search; private LastWas myLast = LastWas.Search;
private Settings MySettings; private Settings MySettings;
//public bool TruncatedDataFg { get; set; } = false;
public string MyStatus public string MyStatus
mschill marked this conversation as resolved Outdated
mschill commented 2026-09-02 15:01:13 -04:00
Outdated
Review
Copy link
Copy source

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?
plarsen commented 2026-09-02 15:56:45 -04:00
Outdated
Review
Copy link
Copy source

I cleaned this up

I cleaned this up
mschill commented 2026-09-02 15:58:04 -04:00
Outdated
Review
Copy link
Copy source

This is still commented out code - commented out code should be removed.

This is still commented out code - commented out code should be removed.
{ {
get { return tsslStatus.Text; } get { return tsslStatus.Text; }
8
 @@ -856,7 +855,7 @@ namespace Baseline
DirectoryInfo di1 = new DirectoryInfo(path1); DirectoryInfo di1 = new DirectoryInfo(path1);
DirectoryInfo di2 = new DirectoryInfo(path2); DirectoryInfo di2 = new DirectoryInfo(path2);
_FileName = fileName; _FileName = fileName;
FillByCompare(di1, di2, fileName, myIgnore, TruncatedDataFg, false); FillByCompare(di1, di2, fileName, myIgnore, TruncatedDataFg);
} }
/// <summary> /// <summary>
/// Fill for a search /// Fill for a search
@@ -963,13 +962,13 @@ namespace Baseline
} }
return false; return false;
} }
private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore, bool isTruncatedChecked = false, bool foundFileFg = false) private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore, bool isTruncatedChecked = false)
{ {
mschill marked this conversation as resolved Outdated
mschill commented 2026-09-02 16:01:16 -04:00
Outdated
Review
Copy link
Copy source

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.
plarsen commented 2026-09-02 16:25:24 -04:00
Outdated
Review
Copy link
Copy source

I removed foundFileFg

I removed foundFileFg
foreach (DirectoryInfo diChild1 in di1.GetDirectories()) foreach (DirectoryInfo diChild1 in di1.GetDirectories())
{ {
DirectoryInfo diChild2 = new DirectoryInfo(Path.Combine(di2.FullName, diChild1.Name)); DirectoryInfo diChild2 = new DirectoryInfo(Path.Combine(di2.FullName, diChild1.Name));
if (diChild2.Exists) if (diChild2.Exists)
FillByCompare(diChild1, diChild2, fileName,myIgnore, isTruncatedChecked, foundFileFg);// Recursively work on Sub-Folders FillByCompare(diChild1, diChild2, fileName,myIgnore, isTruncatedChecked);// Recursively work on Sub-Folders
} }
mschill commented 2026-09-02 16:01:45 -04:00
Outdated
Review
Copy link
Copy source

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.
plarsen commented 2026-09-02 16:25:26 -04:00
Outdated
Review
Copy link
Copy source

I removed foundFileFg

I removed foundFileFg
foreach (FileInfo fiChild1 in di1.GetFiles(fileName)) foreach (FileInfo fiChild1 in di1.GetFiles(fileName))
{ {
6