Volian/SourceCode
8
0 Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C2026-041-invisible-position-changes-as-differences #807

Merged
jjenko merged 14 commits from C2026-041-invisible-position-changes-as-differences into Development 2026-09-03 08:56:33 -04:00
Conversation 16 Commits 14 Files Changed 9
+2 -50
2 changed files with 2 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c32121c4c4 - Show all commits

No files matched your search

PROMS/Baseline/frmBaseline.Designer.cs
Generated
-1
View File
@@ -99,7 +99,6 @@
this.cbUseTruncatedData.Text = "Use Truncated Data";
this.tt.SetToolTip(this.cbUseTruncatedData, "Set the Search to be Case Sensitive\r\nUppercase and Lowercase will not match");
this.cbUseTruncatedData.UseVisualStyleBackColor = true;
this.cbUseTruncatedData.Click += new System.EventHandler(this.cbUseTruncatedData_Click);
//
// btnUC
//
1
PROMS/Baseline/frmBaseline.cs
+2 -49
View File
1
 @@ -73,7 +73,7 @@ namespace Baseline
public IgnoreLines MyIgnore { get; set; } = new IgnoreLines();
private LastWas myLast = LastWas.Search;
private Settings MySettings;
public bool TruncatedDataFg { get; set; } = false;
//public bool TruncatedDataFg { get; set; } = false;
mschill marked this conversation as resolved Outdated
mschill commented 2026-09-02 15:01:13 -04:00
Outdated
Review
Copy link
Copy source

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?

Wait this is both a global variable --- but it looks like it is passed as a paramater to functions --- if it is being passed as a paramaeter used locally in functions, why is it also a global variable?
plarsen commented 2026-09-02 15:56:45 -04:00
Outdated
Review
Copy link
Copy source

I cleaned this up

I cleaned this up
mschill commented 2026-09-02 15:58:04 -04:00
Outdated
Review
Copy link
Copy source

This is still commented out code - commented out code should be removed.

This is still commented out code - commented out code should be removed.
public string MyStatus
{
get { return tsslStatus.Text; }
@@ -203,13 +203,6 @@ namespace Baseline
MyIgnore = IgnoreLines.Get(saveOriginal);
}
}
private void cbUseTruncatedData_Click(object sender, EventArgs e)
{
System.Windows.Forms.CheckBox item = (System.Windows.Forms.CheckBox)sender;
TruncatedDataFg = item.Checked;
}
//}
/// <summary>
mschill marked this conversation as resolved Outdated
mschill commented 2026-09-02 15:05:24 -04:00
Outdated
Review
Copy link
Copy source

This seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.

This seems unnecessary as it is setting a global variable TruncatedDataFg - which is never used.
plarsen commented 2026-09-02 15:57:28 -04:00
Outdated
Review
Copy link
Copy source

I removed the function

I removed the function
/// Process DebugPagination.txt in all sub-folders
/// </summary>
6
 @@ -972,29 +965,12 @@ namespace Baseline
}
private void FillByCompare(DirectoryInfo di1, DirectoryInfo di2, string fileName, IgnoreLines myIgnore, bool isTruncatedChecked = false, bool foundFileFg = false)
mschill marked this conversation as resolved Outdated
mschill commented 2026-09-02 16:01:16 -04:00
Outdated
Review
Copy link
Copy source

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.
plarsen commented 2026-09-02 16:25:24 -04:00
Outdated
Review
Copy link
Copy source

I removed foundFileFg

I removed foundFileFg
{
//if (isTruncatedChecked) // C2026-041 is the "Use Truncated Data" checked
//{
// if (!foundFileFg) // flag to indicate if the correct DebugMeta file has been found.
// {
// fileName = getDebubMetaFile(di1, di2, ref foundFileFg); // C2026-041 Check if the DebugMeta_Truncate.txt file is found in the baseline bench mark and the new release being tested.
// }
//}
foreach (DirectoryInfo diChild1 in di1.GetDirectories())
foreach (DirectoryInfo diChild1 in di1.GetDirectories())
{
DirectoryInfo diChild2 = new DirectoryInfo(Path.Combine(di2.FullName, diChild1.Name));
if (diChild2.Exists)
FillByCompare(diChild1, diChild2, fileName,myIgnore, isTruncatedChecked, foundFileFg);// Recursively work on Sub-Folders
mschill commented 2026-09-02 16:01:45 -04:00
Outdated
Review
Copy link
Copy source

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.

foundFileFg is an added paramater but it is not used - if not used it shoul be removed.
plarsen commented 2026-09-02 16:25:26 -04:00
Outdated
Review
Copy link
Copy source

I removed foundFileFg

I removed foundFileFg
}
//foreach (FileInfo fiChild1 in di1.GetFiles(fileName))
//{
// FileInfo fiChild2 = new FileInfo(Path.Combine(di2.FullName, fiChild1.Name));
// if (fiChild2.Exists)
// {
// if (CompareFile(fiChild1, fiChild2, myIgnore))
// Add(new FindFile(fiChild1.FullName, fiChild2.FullName));// Process Each File
// }
//}
foreach (FileInfo fiChild1 in di1.GetFiles(fileName))
{
mschill marked this conversation as resolved Outdated
mschill commented 2026-09-02 14:51:16 -04:00
Outdated
Review
Copy link
Copy source

Commented out code should be removed

Commented out code should be removed
plarsen commented 2026-09-02 15:56:18 -04:00
Outdated
Review
Copy link
Copy source

I cleaned this up

I cleaned this up
FileInfo fiChild2 = new FileInfo(Path.Combine(di2.FullName, fiChild1.Name));
2
 @@ -1027,29 +1003,6 @@ namespace Baseline
}
}
}
private string getDebubMetaFile(DirectoryInfo di1, DirectoryInfo di2, ref bool foundFileFg) // C2026-041
{
string flnm;
DirectoryInfo dr1 = di1.GetDirectories()[0]; // get first folder for test of which DebugMeta file to use. The DebugMeta files are found only ineach proc set folder.
if (!dr1.Name.Substring(0, 8).Contains("VEPROMS_") && !foundFileFg)
{
if (File.Exists(Path.Combine(dr1.FullName, "DebugMeta_Truncated.txt")) && File.Exists(Path.Combine(di2.FullName, dr1.Name, "DebugMeta_Truncated.txt"))) // if DebugMeta_Truncate.txt file is found.
{
flnm = "DebugMeta_Truncated.txt";
foundFileFg = true;
}
else
{
flnm = "DebugMeta.txt";
foundFileFg = true;
}
}
else
{
flnm = "DebugMeta.txt";
}
return flnm;
}
private bool CompareFile(FileInfo fiChild1, FileInfo fiChild2,IgnoreLines myIgnore)
{
if (fiChild1.Name == "DebugMeta.txt" || fiChild1.Name == "DebugMeta_Truncated.txt")
2