Volian/SourceCode
8
0 Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C2026-041-invisible-position-changes-as-differences #807

Merged
jjenko merged 14 commits from C2026-041-invisible-position-changes-as-differences into Development 2026-09-03 08:56:33 -04:00
Conversation 16 Commits 14 Files Changed 9
-12
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 21c4936ee8 - Show all commits
PROMS/Volian.Base.Library/DebugPrint.cs
-12
View File
@@ -1,9 +1,7 @@
using DevComponents.DotNetBar;
using Org.BouncyCastle.Utilities;
using System;
mschill marked this conversation as resolved Outdated
jjenko commented 2026-08-24 11:43:44 -04:00
Outdated
Review
Copy link
Copy source

Looks like Visual Studio was trying to be "helpful". I don't think BouncyCastle is needed.

Looks like Visual Studio was trying to be "helpful". I don't think BouncyCastle is needed.
using System.Collections.Generic;
using System.IO;
using System.Net.NetworkInformation;
using System.Text;
mschill marked this conversation as resolved Outdated
jjenko commented 2026-08-24 11:47:55 -04:00
Outdated
Review
Copy link
Copy source

is System.Net.NetworkInformation needed?

is System.Net.NetworkInformation needed?
mschill commented 2026-08-24 11:53:29 -04:00
Outdated
Review
Copy link
Copy source

Agreed should be removing unnecessary usings.

Agreed should be removing unnecessary usings.
mschill commented 2026-08-24 14:01:57 -04:00
Outdated
Review
Copy link
Copy source

What is DevComponents.DotNetBar needed for?

What is DevComponents.DotNetBar needed for?
mschill commented 2026-08-26 11:22:23 -04:00
Outdated
Review
Copy link
Copy source

This was removed but it looks like another unneeded using was added. This is still an open item as of 8/26

This was removed but it looks like another unneeded using was added. This is still an open item as of 8/26
plarsen commented 2026-08-27 09:43:51 -04:00
Outdated
Review
Copy link
Copy source

Which using are you referring to?

Which using are you referring to?
mschill commented 2026-08-27 10:36:07 -04:00
Outdated
Review
Copy link
Copy source

From the above - it looks like you added:
using System.Windows.Forms;
to
[PROMS/Volian.Base.Library/DebugPrint.cs]

that being said, in VIsual Studio, should be clicking on the side item and selecting remove unnecessary usings. I will forward the emails related to this / the Technical Debt cleanup

From the above - it looks like you added: using System.Windows.Forms; to [PROMS/Volian.Base.Library/DebugPrint.cs] that being said, in VIsual Studio, should be clicking on the side item and selecting remove unnecessary usings. I will forward the emails related to this / the Technical Debt cleanup
namespace Volian.Base.Library
@@ -161,11 +159,8 @@ namespace Volian.Base.Library
_MyDebugPrint_Truncated.Close(); }
public static void Write(string format, params object[] args)
{
if (args.Length > 8)
{
if (args[args.GetUpperBound(0)] == "truncate_false" || args[args.GetUpperBound(0)] == "truncate_true") // if there is a 9th element test the value for truncated data.
mschill marked this conversation as resolved
mschill commented 2026-09-02 08:28:16 -04:00
Review
Copy link
Copy source

Write should be removed - it is not called from anywhere.

Write should be removed - it is not called from anywhere.
zero_references.jpg
113 KiB
zero_references.jpg
{
int myvalue = args.GetUpperBound(0);
// test and save untruncated and truncated version of the data.
if (args[args.GetUpperBound(0)] == "truncate_false")// when untruncated data is being saved
{
@@ -182,13 +177,6 @@ namespace Volian.Base.Library
_MyDebugPrint.Write(format, args); // there is a 9th element, but not for truncated data
}
}
else // test if asgs does not have a 9th element save data (no truncate data is available)
{
_MyDebugPrint_Truncated.Write(format, args);
_MyDebugPrint.Write(format, args);
}
}
public static void WriteLine(string format, params object[] args)
{
4