Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 #762

Merged
jjenko merged 3 commits from B2026-042-Fix-Null-Error-for-Set_At_All_Level-in-the-Applicability-tab-evaluate-having-the-button-grayed-out-for-the-RNO-column-4 into Development 2026-05-04 09:11:34 -04:00
Conversation 6 Commits 3 Files Changed 1
+18 -12
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1b1dc78548 - Show all commits
PROMS/Volian.Controls.Library/DisplayApplicability.cs
+18 -12
View File
@@ -69,13 +69,16 @@ namespace Volian.Controls.Library
{
MyItemInfo = _MyDisplayTabItem.MyItemInfo;
}
if (MyItemInfo.IsRNOPart == true)
if (MyItemInfo != null)
{
btnApplicabilitychg.Enabled = false;
}
else
{
btnApplicabilitychg.Enabled = true;
if (MyItemInfo.IsRNOPart == true) // Check if step is an RNO disable "Set All To Level" button.
{
btnApplicabilitychg.Enabled = false;
}
else
{
btnApplicabilitychg.Enabled = true;
}
}
}
}
@@ -402,13 +405,16 @@ namespace Volian.Controls.Library
if (_MyItemInfo != null)
{
if (this.Visible == false) return;
if (_MyItemInfo.IsRNOPart == true) // Check if step is an RNO disable "Set All To Level" button.
if (MyItemInfo != null)
mschill commented 2026-05-01 06:57:30 -04:00
Outdated
Review
Copy Link
Copy Source

Also, I am not sure how this would ever get hit as isn't this basically the same check as line 405?

Also, I am not sure how this would ever get hit as isn't this basically the same check as line 405?
jjenko commented 2026-05-01 09:17:08 -04:00
Outdated
Review
Copy Link
Copy Source

in addition to Matt's comment, the MyItemInfo references should be "_MyItemInfo" as we are in the Set portion of "MyItemInfo". All of the other references in this Set code use "_MyItemInfo".

in addition to Matt's comment, the MyItemInfo references should be "_MyItemInfo" as we are in the Set portion of "MyItemInfo". All of the other references in this Set code use "_MyItemInfo".
plarsen commented 2026-05-01 16:05:53 -04:00
Outdated
Review
Copy Link
Copy Source

The default is enabled. If there _MyItemInfo is null, then the users have not entered a step yet.

The default is enabled. If there _MyItemInfo is null, then the users have not entered a step yet.
mschill commented 2026-05-04 05:54:36 -04:00
Outdated
Review
Copy Link
Copy Source

As mentioned above this 2nd if statement that you added is unnecessary - I took a screenshot and attached here to re-illustrate. The part with a purple square is unnecessary because that is already done by the part in the red square.

As mentioned above this 2nd if statement that you added is unnecessary - I took a screenshot and attached here to re-illustrate. The part with a purple square is unnecessary because that is already done by the part in the red square.
CodeReview_5_4_2026.jpg
54 KiB
CodeReview_5_4_2026.jpg
{
btnApplicabilitychg.Enabled = false;
}
else
{
btnApplicabilitychg.Enabled = true;
if (MyItemInfo.IsRNOPart == true) // Check if step is an RNO disable "Set All To Level" button.
{
btnApplicabilitychg.Enabled = false;
}
else
{
btnApplicabilitychg.Enabled = true;
}
}
IItemConfig cfg = _MyItemInfo.MyConfig as IItemConfig;
List<int> apples = cfg.MasterSlave_Applicability.GetFlags();