Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C024-039_Button_on_Applicability_Tab_to_change_all_at_same_level_for_setting_the_item_mode-2 #714

Merged
jjenko merged 5 commits from C024-039_Button_on_Applicability_Tab_to_change_all_at_same_level_for_setting_the_item_mode-2 into Development 2026-02-20 09:06:02 -05:00
Conversation 9 Commits 5 Files Changed 2 -4
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2aaaa55e42 - Show all commits

4
PROMS/Volian.Controls.Library/DisplayApplicability.cs
View File

@@ -64,7 +64,6 @@ namespace Volian.Controls.Library
if (_MyDisplayTabItem.MyStepTabPanel != null)
{
MyItemInfo = _MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedItemInfo;
MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;
}
mschill marked this conversation as resolved Outdated
mschill commented 2026-02-19 13:59:58 -05:00
Outdated
Review
Copy Link

Not sure if I am missing something, but I am not seeing where this is used? -- is MyEditItem needed?

Not sure if I am missing something, but I am not seeing where this is used? -- is MyEditItem needed?
plarsen commented 2026-02-19 14:18:24 -05:00
Outdated
Review
Copy Link

Looking over this, it looks like it is not need here. I will remove it.

Looking over this, it looks like it is not need here. I will remove it.
else
{
@@ -283,7 +282,6 @@ namespace Volian.Controls.Library
}
private void BtnApplicabilitychg_Click(object sender, System.EventArgs e)
{
EditItem topEditItem = MyEditItem;
Volian.Base.Library.BigNum MasterSlave_ApplicabilityTmp;
StepConfig sc = MyItemInfo.MyConfig as StepConfig;
MasterSlave_ApplicabilityTmp = sc.MasterSlave_Applicability;
mschill marked this conversation as resolved
mschill commented 2026-02-19 11:17:54 -05:00
Review
Copy Link

Remove commented out code

Remove commented out code
@@ -291,8 +289,6 @@ namespace Volian.Controls.Library
MyEditItem = MyDisplayTabItem.MyStepTabPanel.MyStepPanel.SelectedEditItem;
mschill marked this conversation as resolved
mschill commented 2026-02-19 15:42:26 -05:00
Review
Copy Link

Is this still needed?

Is this still needed?
plarsen commented 2026-02-19 16:13:51 -05:00
Review
Copy Link

It was needed in one solution, but no longer needed.

It was needed in one solution, but no longer needed.
ItemInfo startitm = MyItemInfo.FirstSibling;
mschill marked this conversation as resolved
mschill commented 2026-02-19 11:17:51 -05:00
Review
Copy Link

Remove commented out code

Remove commented out code
topEditItem = MyEditItem.MyStepPanel._LookupEditItems[startitm.ItemID];
while (startitm != null)
{
StepConfig sc2 = startitm.MyConfig as StepConfig;
mschill marked this conversation as resolved
mschill commented 2026-02-19 13:59:11 -05:00
Review
Copy Link

Not sure if I am missing something, but I am not seeing where this is used? -- is topEditItem needed?

Not sure if I am missing something, but I am not seeing where this is used? -- is topEditItem needed?
plarsen commented 2026-02-19 14:57:59 -05:00
Review
Copy Link

Looking over this, it looks like it is not need here. I will remove it.

Looking over this, it looks like it is not need here. I will remove it.