Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

C2024-005-Annotations-Cleanup #353

Closed
plarsen wants to merge 6 commits from C2024-005-Annotations-Cleanup into Development
pull from: C2024-005-Annotations-Cleanup
merge into: Volian:Development
Conversation 2 Commits 6 Files Changed 25 +1372075 -420
plarsen commented 2024-07-16 16:37:28 -04:00
Owner
Copy Link

C2024-005 Add a tool to the Admin tools that would facilitate the cleanup of Annotations by type.

C2024-005 Add a tool to the Admin tools that would facilitate the cleanup of Annotations by type.
C2024-005 Clean up Annotations.docx
89 KiB
djankowski was assigned by plarsen 2024-07-16 16:37:28 -04:00
jjenko was assigned by plarsen 2024-07-16 16:37:28 -04:00
mvickers was assigned by plarsen 2024-07-16 16:37:28 -04:00
plarsen added 4 commits 2024-07-16 16:37:28 -04:00
plarsen requested review from jjenko 2024-07-16 16:37:49 -04:00
plarsen added 1 commit 2024-07-16 16:57:48 -04:00
plarsen removed review request for jjenko 2024-07-16 16:58:12 -04:00
plarsen requested review from kruffing 2024-07-16 16:58:22 -04:00
kruffing requested changes 2024-07-17 07:47:59 -04:00
kruffing left a comment
Owner
Copy Link

  1. promsfixes:

    a) USE VEPROMS_BRAIDWOOD - should not be in there
    b) why is Kevn's stuff shown as addition in Paul's branch? is there a conflict with what he just put on?
    c) the compatibility level is changed
    d) don't understnd the FROM Ann part of this, I guess this is so that the join can be done? (question that probably doesn't requre a change)
    -- Delete Annotations
    DELETE FROM Ann
    FROM tblAnnotations Ann INNER JOIN @Annotationitems AI ON Ann.itemid = AI.AllItemIDs WHERE TypeID = @typeid
    GO
    e) using STRING_SPLIT rather than volian sql function in deleteAnnotationProcByType

  2. why is the licenses.licx file from VEPROMS User Interface/Properties included?

  3. should we by included a csproj file (again in VEPROMS User Interface)

  4. frmAnnotationsCleanup.cs - no comments: removed commented out code

  5. frmBatchRefresh.cs - no comments; remove commented out code & extra whitspace; what is idea behind loading bottom level folders only? 'TODO' in comment, is there something that needs done?

  6. Why is anything being checked in that references Bradwood or BWD? - in VEPROMS.CSLA.Library and Volian.Controls.Library

1) promsfixes: a) USE VEPROMS_BRAIDWOOD - should not be in there b) why is Kevn's stuff shown as addition in Paul's branch? is there a conflict with what he just put on? c) the compatibility level is changed d) don't understnd the FROM Ann part of this, I guess this is so that the join can be done? (question that probably doesn't requre a change) -- Delete Annotations DELETE FROM Ann FROM tblAnnotations Ann INNER JOIN @Annotationitems AI ON Ann.itemid = AI.AllItemIDs WHERE TypeID = @typeid GO e) using STRING_SPLIT rather than volian sql function in deleteAnnotationProcByType 2) why is the licenses.licx file from VEPROMS User Interface/Properties included? 3) should we by included a csproj file (again in VEPROMS User Interface) 4) frmAnnotationsCleanup.cs - no comments: removed commented out code 5) frmBatchRefresh.cs - no comments; remove commented out code & extra whitspace; what is idea behind loading bottom level folders only? 'TODO' in comment, is there something that needs done? 6) Why is anything being checked in that references Bradwood or BWD? - in VEPROMS.CSLA.Library and Volian.Controls.Library
klaskey commented 2024-07-17 08:58:30 -04:00
Owner
Copy Link

related to #5. - I left some TODO items for me because I will be taking on the delete folders part of the ticket after Paul is complete with annotations. Also for deleting folders we only want to allow folders to be selected (although we did find that some locations have nested folders, so I will have to work on those when the branch comes back to me).

related to #5. - I left some TODO items for me because I will be taking on the delete folders part of the ticket after Paul is complete with annotations. Also for deleting folders we only want to allow folders to be selected (although we did find that some locations have nested folders, so I will have to work on those when the branch comes back to me).
plarsen added 1 commit 2024-07-17 09:09:39 -04:00
klaskey self-assigned this 2024-07-17 09:10:25 -04:00
plarsen closed this pull request 2024-07-17 13:18:37 -04:00
plarsen deleted branch C2024-005-Annotations-Cleanup 2024-07-17 13:18:47 -04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
kruffing
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees djankowski jjenko mvickers klaskey
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#353
No description provided.
Delete Branch "C2024-005-Annotations-Cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?