Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Development #138

Closed
cglavan wants to merge 0 commits from Development into master
pull from: Development
merge into: Volian:master
Conversation 1 Commits - Files Changed -
+54 -7
cglavan commented 2023-10-18 09:08:46 -04:00
Contributor
Copy Link
Copy Source
No description provided.
cglavan added 8 commits 2023-10-18 09:08:46 -04:00
B2023-101 & 102: Incoming Transition & Copy/Paste Replace with Incoming Transitionis crashes 3b88b78b34
Merge pull request 'B2023-101 & 102: Incoming Transition & Copy/Paste Replace with Incoming Transitionis crashes' (#134) from GenWork into Development 928fba3b37 
Passed code review.  OK to generate test executable.
C2023-019 Added a message box to install the latest PROMSFixes for when PROMS opens a database that does not have the needed Stored Procedures that allow for displaying only the formats related to that plant. fedbb698ab
B2023-104 Import procedure and Go To RO a79819bb65 
Added a check for a bad RO link when trying to do a Go To RO. A message box pops up telling the user to re-link that RO.

Fixed the Import logic so that an old RO link reference can be replaced with the new one that is generated when a procedure is processed during the Import function.  The Import caused the Bad RO link reported in this bug.  This bug was introduced when the ROID was standardized in length and formatting (new RO logic in 2022).
Merge pull request 'B2023-104 Import procedure and Go To RO' (#136) from B2023-104_GoTo_RO_Crash into Development a94fb328de 
Reviewed-on: #136
Code review completed successfully.
Merge pull request 'C2023-019 Added a message box to install the latest PROMSFixes for when PROMS opens a database that does not have the needed Stored Procedures that allow for displaying only the formats related to that plant.' (#135) from C2023-019_Cant_Load_db_Old_PROMSFixes into Development bf3ddcc122 
Merging C2023-019 into Development after successful code review.
~Fixed ALTER TABLE statement that adds the ApplicablePlant column to the Formats table so that it checks if the column exists f320c8a865
Merge pull request '~Fixed ALTER TABLE statement that adds the ApplicablePlant column to the Formats table so that it checks if the column exists' (#137) from C2023-017 into Development 22e70d03ad 
Merging into Development.  No code review needed.
djankowski was assigned by cglavan 2023-10-18 09:09:07 -04:00
mvickers commented 2023-10-18 09:18:54 -04:00
Member
Copy Link
Copy Source

Works as expected. No issues found.

Works as expected. No issues found.
mvickers closed this pull request 2023-10-18 09:18:54 -04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees djankowski
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#138
Delete Branch "Development"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?