Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C2026-054 Text change for Open Tabs from Previous Session dialog box #815

Merged
mschill merged 3 commits from C2026-054-Text-change-for-Open-Tabs-from-Previous-Session into Development 2026-09-14 05:36:51 -04:00
Conversation 5 Commits 3 Files Changed 1
+10 -9
plarsen commented 2026-09-10 16:02:13 -04:00
Owner
Copy Link
Copy Source
No description provided.
C2026-054-Text-change-for-Open-Tabs-from-Previous-Session.docx
70 KiB
plarsen requested review from jjenko 2026-09-10 16:02:22 -04:00
plarsen self-assigned this 2026-09-10 16:02:35 -04:00
djankowski was assigned by plarsen 2026-09-10 16:02:35 -04:00
jjenko was assigned by plarsen 2026-09-10 16:02:35 -04:00
mvickers was assigned by plarsen 2026-09-10 16:02:35 -04:00
plarsen commented 2026-09-10 16:03:54 -04:00
Author
Owner
Copy Link
Copy Source

C2026-054 Text change for Open Tabs from Previous Session dialog box

C2026-054 Text change for Open Tabs from Previous Session dialog box
C2026-054-Text-change-for-Open-Tabs-from-Previous-Session.docx
61 KiB
plarsen closed this pull request 2026-09-10 16:03:54 -04:00
plarsen reopened this pull request 2026-09-10 16:04:07 -04:00
plarsen closed this pull request 2026-09-10 16:06:08 -04:00
plarsen reopened this pull request 2026-09-10 16:06:32 -04:00
plarsen added 1 commit 2026-09-10 16:06:45 -04:00
C2026-054-Text-change-for-Open-Tabs-from-Previous-Session d5859f2a01
jjenko requested changes 2026-09-10 16:20:56 -04:00
Dismissed
jjenko left a comment
Owner
Copy Link
Copy Source

I don't think you put the Note next in the correct place. I'm pretty sure we wanted to make the entire dialog window's height bigger and then add the Note text between the question and that checkbox panel. Also put a blank line before and after the Note text

I don't think you put the Note next in the correct place. I'm pretty sure we wanted to make the entire dialog window's height bigger and then add the Note text between the question and that checkbox panel. Also put a blank line before and after the Note text
mschill requested changes 2026-09-11 05:35:26 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

Agree with John's comment - this Note should probably be overall as it is not just related to the checkbox. Also, may want to think a little about wording / format and use a thesaurus to word a little differently as it looks weird to me having Note as part of a sentence and NOTE: a line or two later in different casing / usage.

Agree with John's comment - this Note should probably be overall as it is not just related to the checkbox. Also, may want to think a little about wording / format and use a thesaurus to word a little differently as it looks weird to me having Note as part of a sentence and NOTE: a line or two later in different casing / usage.
plarsen added 1 commit 2026-09-11 12:09:57 -04:00
C2026-054-Text-change-for-Open-Tabs-from-Previous-Session 44c86e5d80
mschill requested changes 2026-09-11 13:28:50 -04:00
Dismissed
mschill left a comment
Owner
Copy Link
Copy Source

Remove unnecessary usings

Remove unnecessary usings
PROMS/VEPROMS User Interface/dlgCheckOpenTabs.Designer.cs
@@ -1,4 +1,6 @@

using System;
mschill commented 2026-09-11 13:23:27 -04:00
Owner
Copy Link
Copy Source

Remove unnecessary usings

Remove unnecessary usings
plarsen commented 2026-09-11 14:00:18 -04:00
Author
Owner
Copy Link
Copy Source

using System is required for this file.

using System is required for this file.
plarsen commented 2026-09-11 14:12:59 -04:00
Author
Owner
Copy Link
Copy Source

Environment.NewLine requires System

Environment.NewLine requires System
plarsen added 1 commit 2026-09-12 07:44:45 -04:00
C2026-054-Text-change-for-Open-Tabs-from-Previous-Session 2f5affabbe
jjenko approved these changes 2026-09-13 19:16:58 -04:00
jjenko left a comment
Owner
Copy Link
Copy Source

Changes look good

Changes look good
mschill approved these changes 2026-09-14 05:36:42 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

Looks Good. Ready for QA.

Looks Good. Ready for QA.
mschill merged commit 14a8922976 into Development 2026-09-14 05:36:51 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
mschill
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees plarsen djankowski jjenko mvickers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#815