Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

C2026-047 Improved the efficiency of retrieving Alarm Point Table information. #799

Merged
mschill merged 1 commits from C2026-047_AlarmPointTableProcessing into Development 2026-08-03 05:36:27 -04:00
Conversation 0 Commits 1 Files Changed 2
+10 -11
jjenko commented 2026-07-31 13:46:31 -04:00
Owner
Copy Link
Copy Source

C2026-047
Improved the efficiency of retrieving Alarm Point Table information.

C2026-047 Improved the efficiency of retrieving Alarm Point Table information.
C2026-047 Alarm Point Table Processing.docx
215 KiB
djankowski was assigned by jjenko 2026-07-31 13:46:31 -04:00
mschill was assigned by jjenko 2026-07-31 13:46:31 -04:00
mvickers was assigned by jjenko 2026-07-31 13:46:31 -04:00
jjenko added 1 commit 2026-07-31 13:46:32 -04:00
C2026-047 Improved the efficiency of retrieving Alarm Point Table information. 1b9b63412c
jjenko requested review from mschill 2026-07-31 13:46:32 -04:00
mschill approved these changes 2026-08-03 05:36:09 -04:00
mschill left a comment
Owner
Copy Link
Copy Source

Looks Good - Ready for QA.

Looks Good - Ready for QA.
PROMS/Volian.Print.Library/VlnSvgPageHelper.cs
@@ -1664,1 +1662,3 @@
ROFSTLookup.rochild roc = myLookup.GetROChildByAccPageID("<" + accpgid + "." + multiid + ">", MySection.MyDocVersion.DocVersionConfig.RODefaults_setpointprefix, MySection.MyDocVersion.DocVersionConfig.RODefaults_graphicsprefix);
//C2026-047 first try the RO Lookup with the ascii dash character in the accpageid. If not found, try again with the unicode dash
ROFSTLookup.rochild roc = myLookup.GetROChildByAccPageID("<" + accpageid.Replace(@"\u8209?", "-") + "." + multiid + ">", MySection.MyDocVersion.DocVersionConfig.RODefaults_setpointprefix, MySection.MyDocVersion.DocVersionConfig.RODefaults_graphicsprefix);
mschill commented 2026-08-03 05:35:45 -04:00
Owner
Copy Link
Copy Source

We should convert this to string interpolation - I will try to keep an eye out for it / retouch this next week.

We should convert this to string interpolation - I will try to keep an eye out for it / retouch this next week.
PROMS/Volian.Print.Library/VlnSvgPageHelper.cs
@@ -1668,2 +1668,2 @@
accpgid = accpgid.Replace(@"\u8209?", "-");
roc = myLookup.GetROChildByAccPageID("<" + accpgid + "." + multiid + ">", MySection.MyDocVersion.DocVersionConfig.RODefaults_setpointprefix, MySection.MyDocVersion.DocVersionConfig.RODefaults_graphicsprefix);
// try again but this time with the unicode dash
roc = myLookup.GetROChildByAccPageID("<" + accpageid + "." + multiid + ">", MySection.MyDocVersion.DocVersionConfig.RODefaults_setpointprefix, MySection.MyDocVersion.DocVersionConfig.RODefaults_graphicsprefix);
mschill commented 2026-08-03 05:35:51 -04:00
Owner
Copy Link
Copy Source

We should convert this to string interpolation - I will try to keep an eye out for it / retouch this next week.

We should convert this to string interpolation - I will try to keep an eye out for it / retouch this next week.
mschill merged commit 478d35890d into Development 2026-08-03 05:36:27 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees djankowski mschill mvickers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#799