Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash #730

Merged
jjenko merged 3 commits from B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash into Development 2026-03-09 14:41:04 -04:00
Conversation 4 Commits 3 Files Changed 1 +4 -2
plarsen commented 2026-03-08 22:53:10 -04:00
Owner
Copy Link

B2026-028 Selecting to Go To on an RO causes PROMS to crash

B2026-028 Selecting to Go To on an RO causes PROMS to crash
B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash.docx
32 KiB
plarsen self-assigned this 2026-03-08 22:53:10 -04:00
jjenko was assigned by plarsen 2026-03-08 22:53:10 -04:00
mschill was assigned by plarsen 2026-03-08 22:53:10 -04:00
mvickers was assigned by plarsen 2026-03-08 22:53:10 -04:00
plarsen added 2 commits 2026-03-08 22:53:11 -04:00
Development 4656ec30af
B2026-028 Selecting to Go To on an RO causes PROMS to crash d79dd908f6
plarsen requested review from jjenko 2026-03-08 22:53:23 -04:00
mschill requested changes 2026-03-09 07:17:43 -04:00
Dismissed
mschill left a comment
Owner
Copy Link

see note ---- could parsing the character as an int cause an exception if it can't be parsed or is null?

see note ---- could parsing the character as an int cause an exception if it can't be parsed or is null?
PROMS/Volian.Controls.Library/DisplayRO.cs Outdated
@@ -380,3 +380,3 @@
if (chld.value != null)
{
RoUsageInfo SavROLink = null;
chld.value = Regex.Replace(chld.value, @"\\u([0-9]{1,4})\?", m => Convert.ToChar(int.Parse(m.Groups[1].Value)).ToString());
mschill commented 2026-03-09 07:16:42 -04:00
Owner
Copy Link

Could there be an exception here with the int.Parse?

Should this be something like:

chld.value = Regex.Replace(chld.value, @"\u([0-9]{1,4})?", m => int.TryParse(m?.Groups[1]?.Value, out int result) ? Convert.ToChar(result).ToString() : "");

Could there be an exception here with the int.Parse? Should this be something like: chld.value = Regex.Replace(chld.value, @"\\u([0-9]{1,4})\?", m => int.TryParse(m?.Groups[1]?.Value, out int result) ? Convert.ToChar(result).ToString() : "");
jjenko commented 2026-03-09 08:27:44 -04:00
Owner
Copy Link

I agree. It would be safter to do the TryParse as suggested

I agree. It would be safter to do the TryParse as suggested
plarsen commented 2026-03-09 08:49:08 -04:00
Author
Owner
Copy Link

I can add the tryparse, but since the match is only looking for integers [0-9]{1,4} why would the tryparese be needed?

I can add the tryparse, but since the match is only looking for integers [0-9]{1,4} why would the tryparese be needed?
mschill marked this conversation as resolved
plarsen added 1 commit 2026-03-09 13:41:02 -04:00
B2026-028 Selecting to Go To on an RO causes PROMS to crash. 95737d05e1
mschill approved these changes 2026-03-09 14:32:14 -04:00
mschill left a comment
Owner
Copy Link

Looks good. Ready for QA.

Looks good. Ready for QA.
jjenko approved these changes 2026-03-09 14:38:56 -04:00
jjenko left a comment
Owner
Copy Link

change looks good

change looks good
jjenko merged commit fa114f4467 into Development 2026-03-09 14:41:04 -04:00
mvickers commented 2026-03-10 12:12:54 -04:00
Member
Copy Link

Tested with version 2.3.2603.914 the null reference error has been corrected.

Tested with version 2.3.2603.914 the null reference error has been corrected.
Sign in to join this conversation.
Reviewers
No Reviewers
mschill
jjenko
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees plarsen jjenko mschill mvickers
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#730
Delete Branch "B2026-028_Selecting_to_Go_To_on_an_RO_causes_PROMS_to_crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?