B2025-018 PROMS - Issues with folder order in tree view. #526

Merged
jjenko merged 1 commits from B2025-018 into Development 2025-02-21 16:05:19 -05:00
Owner

B2025-018 PROMS - Issues with folder order in tree view.

Note this was found in Michelle’s ACME db when she attempted to move the folder “” to 2nd from the top, it appeared to revert position when closing and re-opening PROMS. After research, it was determined that this was due to a data issue. However, we should make some changes to try to prevent this data issue from occurring in the future.

Description of Data issue: The table Folders (in SQL) has a column called ManualOrder. When multiple items have the same ManualOrder, PROMS has no way to know the order / insert an item in between 2 items with the same “position” so when reading from the db it just picks one to be first / etc… Also, when a folder (other than the root - VEPROMS) has a ManualOrder of null, it results in inaccurate / inconsistent sorting.

Summary of Changes: Changes will include:
• Attempt to avoid inserting a Folder with a ManualOrder of null – if one would be inserted, insert it at the end.
• If a folder is the be created (or moved) to a location, store a ManualOrder that is halfway between the item above it and the next highest ManualOrder (with that same parent item)

B2025-018 PROMS - Issues with folder order in tree view. Note this was found in Michelle’s ACME db when she attempted to move the folder “” to 2nd from the top, it appeared to revert position when closing and re-opening PROMS. After research, it was determined that this was due to a data issue. However, we should make some changes to try to prevent this data issue from occurring in the future. Description of Data issue: The table Folders (in SQL) has a column called ManualOrder. When multiple items have the same ManualOrder, PROMS has no way to know the order / insert an item in between 2 items with the same “position” so when reading from the db it just picks one to be first / etc… Also, when a folder (other than the root - VEPROMS) has a ManualOrder of null, it results in inaccurate / inconsistent sorting. Summary of Changes: Changes will include: • Attempt to avoid inserting a Folder with a ManualOrder of null – if one would be inserted, insert it at the end. • If a folder is the be created (or moved) to a location, store a ManualOrder that is halfway between the item above it and the next highest ManualOrder (with that same parent item)
mschill added 1 commit 2025-02-21 15:52:21 -05:00
djankowski was assigned by mschill 2025-02-21 15:52:28 -05:00
jjenko was assigned by mschill 2025-02-21 15:52:28 -05:00
mvickers was assigned by mschill 2025-02-21 15:52:29 -05:00
mschill requested review from jjenko 2025-02-21 15:52:33 -05:00
jjenko approved these changes 2025-02-21 16:05:04 -05:00
jjenko left a comment
Owner

changes look good

changes look good
jjenko merged commit f65644f553 into Development 2025-02-21 16:05:19 -05:00
Member

Tested with version 2.2.2502.2116. Works as expected.

Tested with version 2.2.2502.2116. Works as expected.
Sign in to join this conversation.
No Reviewers
No Label
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#526
No description provided.