Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2023-112: Search All Procedure Sets does not always work #158

Merged
jjenko merged 1 commits from GenWork into Development 2023-11-20 10:33:09 -05:00
Conversation 2 Commits 1 Files Changed 1
+23 -7
kruffing commented 2023-11-20 10:25:06 -05:00
Owner
Copy Link
Copy Source

B2023-112: Search All Procedures Sets does not always work. Also, if Search all Sets was selected and a user then unselected a particular set, Proms would crash. Changes were made to DisplaySearch.cs, a list, lstCheckedDocVersions, is used to keep track of the sets that are selected, but it is an empty list for ‘All’. Changes were made so that list size AND checkbox for ‘All’ are used to determine whether ‘All’ are selected. Note that some of coloring of Search’s procedure sets tree view nodes was commented out, it seems to not be working correctly and needs further work.

B2023-112: Search All Procedures Sets does not always work. Also, if Search all Sets was selected and a user then unselected a particular set, Proms would crash. Changes were made to DisplaySearch.cs, a list, lstCheckedDocVersions, is used to keep track of the sets that are selected, but it is an empty list for ‘All’. Changes were made so that list size AND checkbox for ‘All’ are used to determine whether ‘All’ are selected. Note that some of coloring of Search’s procedure sets tree view nodes was commented out, it seems to not be working correctly and needs further work.
B2023-112.docx
128 KiB
kruffing added 1 commit 2023-11-20 10:25:07 -05:00
B2023-112: Search All Procedure Sets does not always work e45c373920
kruffing requested review from jjenko 2023-11-20 10:25:16 -05:00
jjenko approved these changes 2023-11-20 10:32:43 -05:00
jjenko left a comment
Owner
Copy Link
Copy Source

code commented well and changes look good.
OK to proceed with testing

code commented well and changes look good. OK to proceed with testing
jjenko merged commit cf6507aa71 into Development 2023-11-20 10:33:09 -05:00
djankowski was assigned by jjenko 2023-11-20 10:33:17 -05:00
mvickers was assigned by djankowski 2023-11-20 10:38:03 -05:00
mvickers commented 2023-11-22 09:35:55 -05:00
Member
Copy Link
Copy Source

Tested with no issues.

Tested with no issues.
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
djankowski (Devin Jankowski) jjenko (John Jenko) lbutler (Lydia Butler) mschill (Matthew Schill) mvickers (Michelle Vickers) plarsen (Paul Larsen)
No Assignees djankowski mvickers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#158