C2023-017: Added logic to filter the format list when selecting a format to be applied to a section #126

cglavan · 2023-10-02T09:36:47-04:00

cglavan commented

2023-10-02 09:36:47 -04:00

This update consists of the attached database script first being executed against the database for the plant being tested.

The attached script performs multiple database updates as follows:

Updates the CONFIG value for the top-level folder to include a Formats element in the XML value.
Adds a new field to the Formats table named ApplicablePlant.
Updates the Formats table and sets ApplicablePlant to a pre-determined number.
Updates all format-related stored procedures to include the newly created field

Once the script has been executed and database has been updated PROMS will use these values to filter the list of formats in the dropdown list. Because of the way that PROMS stores the selected format, if a plant uses a format that is no longer available to them after this update, the previously-selected format will continue to be used unless the user selects a different format and saves it.

NOTE
The generic update statements from the attached script that need applied to the all customer databases have been included in the PROMSFixes.sql file in the repository. When building a release and sending it to the customer, the only portion of the script that needs to be modified and executed against their database is the first update statement section which updates the CONFIG value of the Folders table. This will need done for the initial release of this code to each customer.

**This update consists of the attached database script first being executed against the database for the plant being tested.** The attached script performs multiple database updates as follows: 1. Updates the CONFIG value for the top-level folder to include a Formats element in the XML value. 2. Adds a new field to the Formats table named ApplicablePlant. 3. Updates the Formats table and sets ApplicablePlant to a pre-determined number. 4. Updates all format-related stored procedures to include the newly created field Once the script has been executed and database has been updated PROMS will use these values to filter the list of formats in the dropdown list. Because of the way that PROMS stores the selected format, if a plant uses a format that is no longer available to them after this update, the previously-selected format will continue to be used unless the user selects a different format and saves it. **NOTE** The generic update statements from the attached script that need applied to the all customer databases have been included in the PROMSFixes.sql file in the repository. When building a release and sending it to the customer, the only portion of the script that needs to be modified and executed against their database is the first update statement section which updates the CONFIG value of the Folders table. This will need done for the initial release of this code to each customer.

C2023-017.docx

15 KiB

C2023-017_UpdateFormats.txt

10 KiB

cglavan added 1 commit 2023-10-02 09:36:48 -04:00

C2023-017: Added logic to filter the format list when selecting a format to be applied to a section b83ec3520b

cglavan requested review from jjenko 2023-10-02 09:36:54 -04:00

cglavan requested review from kruffing 2023-10-02 09:36:54 -04:00

jjenko approved these changes 2023-10-02 10:54:28 -04:00

jjenko left a comment

Code and the attached SQL script (attached to the Git check-in) looks good for generating test executable

jjenko commented

2023-10-02 10:59:13 -04:00

Kathy,

I think the code looks good for proceed onto the testing phase.
if your review is good than please do the Create merge commit.

~ John

Kathy, I think the code looks good for proceed onto the testing phase. if your review is good than please do the Create merge commit. ~ John

kruffing commented

2023-10-03 08:52:41 -04:00

The code that gets the list of formats for a particular plant that was added to frmProcedureProperties.cs also needs to be added to other forms that get this list, i.e. frmSectionProperties.cs, frmVersionProperties.cs and frmFolderProperties.cs

cglavan added 1 commit 2023-10-03 09:02:49 -04:00

C2023-017: 55a78eb845

~Moved original code for populating the filtered list to a separate static class named FormatUtility in Volian.Controls.Library
~Renamed method to GetFilteredFormatList
~Updated code to reference new static class and method
~Added logic to other applicable forms

cglavan requested review from jjenko 2023-10-03 09:06:36 -04:00

kruffing approved these changes 2023-10-03 09:11:29 -04:00

kruffing left a comment

Previous recommendation to add plant format list to all dialogs that have the format list has been done. The code has been successfully reviewed.

cglavan added 1 commit 2023-10-03 09:18:37 -04:00

~Added database changes to PROMSFixes.sql 4be7cdc6c7

cglavan added 1 commit 2023-10-03 11:09:32 -04:00

~Restructured PROMSFixes.sql to add updates above section that lists RevDate and RevDescription cbcf7c845d

cglavan requested review from kruffing 2023-10-03 11:09:51 -04:00

jjenko approved these changes 2023-10-03 11:11:39 -04:00

jjenko left a comment

Changes look good.

kruffing approved these changes 2023-10-03 11:13:30 -04:00

kruffing left a comment

PromsFixes changes have been reviewed successfully.

djankowski was assigned by cglavan

2023-10-03 11:25:12 -04:00

cglavan merged commit b34fb42f94 into Development

2023-10-03 11:34:24 -04:00

cglavan referenced this issue from a commit

2023-10-03 11:34:25 -04:00

Merge pull request 'C2023-017: Added logic to filter the format list when selecting a format to be applied to a section' (#126) from C2023-017 into Development

mvickers was assigned by djankowski

2023-10-03 11:42:07 -04:00

mvickers commented

2023-10-06 10:02:11 -04:00

This tested successfully.

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Volian/SourceCode#126