B2024-063-Invalid-Format-message-box-displays-when-rev-date-empty

PROMS/VEPROMS User Interface/DlgPrintProcedure.cs

@@ -231,6 +231,7 @@ namespace VEPROMS
 			cbxOpenAfterCreate2.Visible = oneProcedure;
 			cbxOpenAfterCreate2.Checked = false;
 			cbxOverwritePDF2.Visible = oneProcedure;
+			cbxOverwritePDF2.Checked = true;
 			gpnlDebug.Visible = Volian.Base.Library.VlnSettings.DebugMode;
 			swtbtnGeneratePlacekeeper.Value = false;
 			cbxGenerateConActSum.Checked = false;
@@ -1224,6 +1225,9 @@ namespace VEPROMS
 			return true;
 		}
 
+
+
+
 		private void txbRevDate_Enter(object sender, EventArgs e)
 		{
 			txbDate = txbRevDate;

PROMS/VEPROMS User Interface/dlgExportImport.cs

@@ -425,9 +425,9 @@ namespace VEPROMS
 				MessageBox.Show(msg, "Import Completed", MessageBoxButtons.OK, MessageBoxIcon.Information); // C2020-042 changed mesage box title
 																											//MessageBox.Show(string.Format("Finished Importing:\n\n{0}", txtImport.Text.Substring(txtImport.Text.LastIndexOf("\\") + 1)), "Import", MessageBoxButtons.OK, MessageBoxIcon.Information);
 			}
-			if (canceledPressed || !isImported)
+			if (canceledPressed)
 			{
-				MessageBox.Show(string.Format("Cancelling the import of:\n\n{0}", txtImport.Text.Substring(txtImport.Text.LastIndexOf("\\") + 1)), "Cancelling Import", MessageBoxButtons.OK, MessageBoxIcon.Information);
+				MessageBox.Show(string.Format("Canceling the import of:\n\n{0}", txtImport.Text.Substring(txtImport.Text.LastIndexOf("\\") + 1)), "Import", MessageBoxButtons.OK, MessageBoxIcon.Information);
 				btnCloseImport.PerformClick();
 			}
 		}
@@ -906,8 +906,8 @@ namespace VEPROMS
 				// C2020-032: Import Procedure set when existing name exists, allow user to import with 'Copy (#) of'. 
 				//	This is similar functionality to the import of a procedure without the overwrite part.
 				string msg = string.Format("The procedure set you are importing, {0}, already exists.\n\nDo you want to import {0} as a COPY of the existing set?\n\nThis will prefix the name with \"Copy (#) of\"", name);
-				DialogResult dr = MessageBox.Show(this, msg, "Create Copy Of Existing Procedure Set", MessageBoxButtons.OKCancel, MessageBoxIcon.Stop);
-				if (dr == DialogResult.OK)
+				DialogResult dr = MessageBox.Show(this, msg, "Create Copy Of Existing Procedure Set", MessageBoxButtons.YesNoCancel, MessageBoxIcon.Stop);
+				if (dr == DialogResult.Yes)
 				{
 					string number = "";
 					int max = -1;
@@ -931,11 +931,6 @@ namespace VEPROMS
 
 					ff = AddFolder(Folder.Get(MyFolder.FolderID), xd, name);
 				}
-				//else if (dr == System.Windows.Forms.DialogResult.Cancel)
-				//{
-				//	//canceledPressed = true;
-				//	//resolvedProcNum = false;
-				//}
 				else
 					return false;
 			}

PROMS/VEPROMS User Interface/frmBatchRefresh.cs

@@ -11,7 +11,6 @@ using Volian.Controls.Library;
 using DevComponents.DotNetBar;
 using JR.Utils.GUI.Forms;
 using Volian.Controls.Library;
-using System.Linq;
 
 namespace VEPROMS
 {
@@ -1800,21 +1799,6 @@ namespace VEPROMS
 				}
 			}
 
-			//B2024-074 If only deleting annotations from an individual procedure, verify can check out procedure.
-			string msgpi = string.Empty;
-			foreach (ProcedureInfo pi in pil)
-			{
-				//LINQ used for 1st check of if statement
-				//basically check if procedure was already part of a docVersionsFolder
-				//before checking if procedure was checked out already
-				//to avoid duplicate messages for checked out procedures
-				if (!dvil.Any(x => x.Procedures.Any(y => y.ItemID == pi.ItemID)) && !MySessionInfo.CanCheckOutItem(pi.ItemID, CheckOutType.Procedure, ref msgpi))
-				{
-					sbDocVersions.AppendLine(msgpi);
-					cancelledOut = true;
-				}
-			}
-
 			if (cancelledOut)
 			{
 				StringBuilder sb = new StringBuilder();

PROMS/VEPROMS User Interface/frmVersionsProperties.cs

@@ -511,7 +511,7 @@ namespace VEPROMS
 
 		private void btnPC_Click(object sender, EventArgs e)
 		{
-			if (MessageBox.Show(this, "Are you sure you want to add Applicability to this Working Draft?", "Add Applicability", MessageBoxButtons.YesNo, MessageBoxIcon.Stop) == DialogResult.Yes)
+			if (MessageBox.Show(this, "Are you sure you want to add Applicability to this Working Draft?", "Add Applicability", MessageBoxButtons.YesNoCancel, MessageBoxIcon.Stop) == DialogResult.Yes)
 			{
 				btnApplicability.Visible = true;
 				tiApplicability.Visible = true;

PROMS/VEPROMS.CSLA.Library/Extension/MultiUserExt.cs

@@ -156,38 +156,32 @@ namespace VEPROMS.CSLA.Library
 				SessionInfoList sil = DataPortal.Fetch<SessionInfoList>(new SessionInfoList.CanCheckOutItemCriteria(objectID, objectType));
 				if (sil.Count == 0)
 					return true;
-				if (objectType == CheckOutType.Session)
-				{
-					if (sil.Count == 1)
-					{
-						OwnerInfoList oil = OwnerInfoList.GetBySessionID(sil[0].SessionID);
-						if (oil.Count == 0)
-							return true;
-						else
-						{
-							message = "Export Procedure Set and Import Procedure Set are not available because you have open procedures or documents";
-							return false;
-						}
-					}
-					else
-					{
-						message = "Export Procedure Set and Import Procedure Set are not available because there are other sessions open in the database";
-						return false;
-					}
-				}
+        if (objectType == CheckOutType.Session)
+        {
+          if (sil.Count == 1)
+          {
+            OwnerInfoList oil = OwnerInfoList.GetBySessionID(sil[0].SessionID);
+            if (oil.Count == 0)
+              return true;
+            else
+            {
+              message = "Export Procedure Set and Import Procedure Set are not available because you have open procedures or documents";
+              return false;
+            }
+          }
+          else
+          {
+            message = "Export Procedure Set and Import Procedure Set are not available because there are other sessions open in the database";
+            return false;
+          }
+        }
 				bool rv = true;
 				// C2015-022 part of separate windows logic, check the processID instead of the sessionID
 				foreach (SessionInfo si in sil)
 				{
 					if (si.ProcessID != this.ProcessID && objectType == CheckOutType.Procedure)
 					{
-						//B2024-074 If no Number for Procedure, Display Title
-						ProcedureInfo tmpproc = ItemInfo.Get(objectID).MyProcedure;
-						string name = tmpproc.DisplayNumber;
-						if (string.IsNullOrEmpty(name))
-						{ name = tmpproc.DisplayText; }
-
-						message = string.Format("The procedure {0} is already checked out to {1}", name, si.UserID);
+						message = string.Format("The procedure {0} is already checked out to {1}", ItemInfo.Get(objectID).MyProcedure.DisplayNumber, si.UserID);
 						rv = rv && false;
 					}
 					else if (si.ProcessID != this.ProcessID && objectType == CheckOutType.Document)
@@ -201,16 +195,8 @@ namespace VEPROMS.CSLA.Library
 						OwnerInfo oi = OwnerInfo.GetBySessionIDandVersionID(si.SessionID, objectID);
 						if (oi == null)
 							message = message + string.Format("The working draft is already checked out to {0}", si.UserID) + Environment.NewLine;
-						else if (oi.OwnerType == 0)
-						{
-							//B2024-074 If no Number for Procedure, Display Title
-							ProcedureInfo tmpproc = ItemInfo.Get(oi.OwnerItemID).MyProcedure;
-							string name = tmpproc.DisplayNumber;
-							if (string.IsNullOrEmpty(name))
-							{ name = tmpproc.DisplayText; }
-
-							message = message + string.Format("The procedure {0} is already checked out to {1}", name, si.UserID) + Environment.NewLine;
-						}
+						else if(oi.OwnerType == 0)
+							message = message + string.Format("The procedure {0} is already checked out to {1}", ItemInfo.Get(oi.OwnerItemID).MyProcedure.DisplayNumber, si.UserID) + Environment.NewLine;
 						else if (oi.OwnerType == 1)
 							message = message + string.Format("The document {0} is already checked out to {1}", DocumentInfo.Get(oi.OwnerItemID).DocumentEntries[0].MyContent.Text, si.UserID) + Environment.NewLine;
 						else if (oi.OwnerType == 2)
@@ -225,15 +211,7 @@ namespace VEPROMS.CSLA.Library
 						if (oi != null)
 						{
 							if (oi.OwnerType == 0)
-							{
-								//B2024-074 If no Number for Procedure, Display Title
-								ProcedureInfo tmpproc = ItemInfo.Get(oi.OwnerItemID).MyProcedure;
-								string name = tmpproc.DisplayNumber;
-								if (string.IsNullOrEmpty(name))
-								{ name = tmpproc.DisplayText; }
-
-								message = message + string.Format("The procedure {0} is already checked out to {1}", name, si.UserID) + Environment.NewLine;
-							}
+								message = message + string.Format("The procedure {0} is already checked out to {1}", ItemInfo.Get(oi.OwnerItemID).MyProcedure.DisplayNumber, si.UserID) + Environment.NewLine;
 							else if (oi.OwnerType == 1)
 								message = message + string.Format("The document {0} is already checked out to {1}", DocumentInfo.Get(oi.OwnerItemID).DocumentEntries[0].MyContent.Text, si.UserID) + Environment.NewLine;
 							else if (oi.OwnerType == 2)

PROMS/Volian.Controls.Library/AnnotationDetails.cs

@@ -277,27 +277,17 @@ namespace Volian.Controls.Library
 
 		private void btnRemoveAnnotation_Click(object sender, EventArgs e)
 		{
-			// CSM B2024-068 / B2024-069 - check if current annotation is not selected before removal of annotation
-			if (CurrentAnnotation != null)
-			{
-				//using (Annotation annotation = CurrentAnnotation.Get())
-				//{
-				//				annotation.Delete();
-				_AnnotationSearch.LoadingList = true;
-				Annotation.DeleteAnnotation(CurrentAnnotation);
-				//				annotation.Save();
-				_AnnotationSearch.LoadingList = false;
-				CurrentAnnotation = null;
-				UpdateAnnotationGrid();
-				_AnnotationSearch.UpdateAnnotationSearchResults(); // B2019-004: update search results list when an annotation is removed.
-																   //}
-			}
-			else
-			{
-				FlexibleMessageBox.Show("You Must Select an Annotation To Remove", "Annotation Not Selected", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
-				return;
-			}
-
+			//using (Annotation annotation = CurrentAnnotation.Get())
+			//{
+			//				annotation.Delete();
+			_AnnotationSearch.LoadingList = true;
+			Annotation.DeleteAnnotation(CurrentAnnotation);
+			//				annotation.Save();
+			_AnnotationSearch.LoadingList = false;
+			CurrentAnnotation = null;
+			UpdateAnnotationGrid();
+			_AnnotationSearch.UpdateAnnotationSearchResults(); // B2019-004: update search results list when an annotation is removed.
+			//}
 		}
 
 		private void btnSaveAnnotation_Click(object sender, EventArgs e)

PROMS/Volian.Controls.Library/DisplayReports.Designer.cs

@@ -503,7 +503,7 @@ namespace Volian.Controls.Library
 			this.cbxSortBySetpointID.Size = new System.Drawing.Size(121, 23);
 			this.cbxSortBySetpointID.Style = DevComponents.DotNetBar.eDotNetBarStyle.StyleManagerControlled;
 			this.cbxSortBySetpointID.TabIndex = 11;
-			this.cbxSortBySetpointID.Text = "Sort By Setpoint ID";
+			this.cbxSortBySetpointID.Text = "Sort By Sepoint ID";
 			this.cbxSortBySetpointID.Visible = false;
 			// 
 			// DisplayReports

PROMS/Volian.Controls.Library/DisplaySearch.Designer.cs

@@ -270,7 +270,7 @@ namespace Volian.Controls.Library
 			this.cbxTranCategory.Name = "cbxTranCategory";
 			this.cbxTranCategory.Size = new System.Drawing.Size(215, 21);
 			this.cbxTranCategory.TabIndex = 1;
-			this.cbxTranCategory.WatermarkText = "Select Category of Transitions";
+			this.cbxTranCategory.WatermarkText = "Select Cateogry of Transitions";
 			// 
 			// lblTranCategory
 			// 
@@ -402,7 +402,7 @@ namespace Volian.Controls.Library
 			this.cbxTranCategory.Name = "cbxTranCategory";
 			this.cbxTranCategory.Size = new System.Drawing.Size(215, 21);
 			this.cbxTranCategory.TabIndex = 1;
-			this.cbxTranCategory.WatermarkText = "Select Category of Transitions";
+			this.cbxTranCategory.WatermarkText = "Select Cateogry of Transitions";
 			// 
 			// lblTranCategory
 			// 

PROMS/Volian.Controls.Library/DisplayTags.cs

@@ -103,7 +103,7 @@ namespace Volian.Controls.Library
 		public string TbFSwd
 		{
 			get	{return tbFSWd.Text;}
-			set { tbFSWd.Text = value; tbFSWd.Refresh(); } //  trBarFS.Value = Convert.ToInt32(value);
+			set { tbFSWd.Text = value; tbFSWd.Refresh(); trBarFS.Value = Convert.ToInt32(value); }
 		}
 
 		public string TbFSht
@@ -111,7 +111,7 @@ namespace Volian.Controls.Library
 			get { return tbFSHt.Text; }
 			set { tbFSHt.Text = value; tbFSHt.Refresh(); _origFigureSizeRatio = float.Parse(value) / float.Parse(tbFSWd.Text); }
 		}
-
+	
 		#endregion
 		#region Constructor
 		public DisplayTags()

PROMS/Volian.Controls.Library/EditItem.cs

@@ -285,7 +285,7 @@ namespace Volian.Controls.Library
 		}
 		public EditItem ActiveParent
 		{
-			get { return _MyParentEditItem != null ? _MyParentEditItem : _MyPreviousEditItem?.ActiveParent; }
+			get { return _MyParentEditItem != null ? _MyParentEditItem : _MyPreviousEditItem.ActiveParent; }
 		}
 		/// <summary>
 		/// Return the Parent EditItem

PROMS/Volian.Controls.Library/ImageItem.cs

@@ -256,8 +256,7 @@ namespace Volian.Controls.Library
 		private int _origCfgHt = 0;	// keep track if original size was stored in cfg
 		private int _origCfgWd = 0;
 		private bool _pastedNew = false;   // need this for flagging newly pasted image (may need to clear cfg)
-		private DisplayTags _displayTags = new DisplayTags();
-		//House myhouse = new House();
+		private DisplayTags _displayTags;
 
 		#endregion
 		#region Constructors
@@ -317,11 +316,8 @@ namespace Volian.Controls.Library
 		}
 		private void SetWidthsAndHeights(System.Drawing.Image img)
 		{
-
 			int wd = img.Width * MyStepPanel.DPI / 72; // converts from screen resolution's DPI to image's points (72/inch)
 			int ht = img.Height * MyStepPanel.DPI / 72;
-
-
 			if (MyItemInfo.MyContent.MyImage != null)   // image is null if creating new.
 			{
 				ImageConfig ic = new ImageConfig(MyItemInfo.MyContent.MyImage);
@@ -344,9 +340,9 @@ namespace Volian.Controls.Library
 				_displayTags.TbFSwd = wd.ToString();
 				_displayTags.TbFSht = ht.ToString();
 			}
+
+
 		}
-
-
 		// the following gets called for 'NEW' images
 		private E_ImageSource InsType = E_ImageSource.None;
 		public ImageItem(ItemInfo itemInfo, StepPanel myStepPanel, EditItem myParentEditItem, ChildRelation myChildRelation, bool expand, EditItem nextEditItem, ImageItem.E_ImageSource insType, DisplayTags displayTags)